-
Notifications
You must be signed in to change notification settings - Fork 103
Remove networkx stubs in favor of typeshed #369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I believe this will resolve my issue here with deprecated signatures But Pylance shows me an error with its built in stubs in 2025.5.1 |
…into remove-networkx
I think once python/typeshed#14256 is merged, I'll feel comfortable enough removing networkx from microsoft/python-type-stubs. There would still be lots of param types missing from typeshed (done in python/typeshed#14038), but these here stubs are full of incorrect or overly restrictive annotations anyway, |
@Avasam, FYI, your recent typeshed changes are in Pylance prerelease 2025.6.102. We're planning to ship a stable release with these changes next week. |
…into remove-networkx
@Avasam, is there anything else you want to do or wait for before I merge this? |
Nope. Feel free to go ahead! |
Thanks for your work on this @Avasam! |
networkx stubs have been added to typeshed in python/typeshed#10544 almost two years ago.
Many improvements since then.
In python/typeshed#14038 I'm currently merging what's left of these stubs that isn't present in typeshed to ensure no false-positive regressions to Pylance users. (and to not loose any work done here)
I already added all missing symbols in python/typeshed#14084
In python/typeshed#14256 I added all return type stubs