Skip to content

Conversation

@yury-s
Copy link
Member

@yury-s yury-s commented May 8, 2025

* Bumped yauzl 2.10.0 -> 3.2.0 as thejoshwolfe/yauzl#114 is fixed in v3 and yauzl does not depend on fd-slicer any more.
* Vendored in extract-zip as it still depends on yauzl 2.10.0. This can be reverted if max-mapper/extract-zip#146 is merged.
@yury-s yury-s requested review from mxschmitt and pavelfeldman May 8, 2025 16:58
@github-actions

This comment has been minimized.

@github-actions
Copy link
Contributor

github-actions bot commented May 8, 2025

Test results for "tests 1"

1 failed
❌ [firefox-page] › page/page-evaluate.spec.ts:424:3 › should throw for too deep reference chain @firefox-ubuntu-22.04-node18

5 flaky ⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-ubuntu-22.04-node18
⚠️ [webkit-library] › library/browsercontext-pages.spec.ts:82:3 › should click the button with offset with page scale @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › library/ignorehttpserrors.spec.ts:30:3 › should isolate contexts @webkit-ubuntu-22.04-node18
⚠️ [webkit-page] › page/page-screenshot.spec.ts:345:5 › page screenshot › should work while navigating @webkit-ubuntu-22.04-node18
⚠️ [playwright-test] › ui-mode-test-watch.spec.ts:145:5 › should watch all @windows-latest-node18-1

39142 passed, 803 skipped
✔️✔️✔️

Merge workflow run.

@yury-s
Copy link
Member Author

yury-s commented May 8, 2025

@microsoft-github-policy-service rerun

@yury-s yury-s merged commit 1d181ae into microsoft:main May 8, 2025
28 of 29 checks passed
@yury-s yury-s deleted the vendor-extract-zip branch May 8, 2025 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants