Skip to content

chore: fix list-files #22609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 24, 2023
Merged

chore: fix list-files #22609

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 15 additions & 31 deletions packages/playwright-test/src/runner/runner.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,13 +34,26 @@ export class Runner {
}

async listTestFiles(projectNames: string[] | undefined): Promise<any> {
type ProjectConfigWithFiles = {
name: string;
testDir: string;
use: { testIdAttribute?: string };
files: string[];
};

type ConfigListFilesReport = {
projects: ProjectConfigWithFiles[];
};

const projects = filterProjects(this._config.projects, projectNames);
const report: any = {
const report: ConfigListFilesReport = {
projects: []
};
for (const project of projects) {
report.projects.push({
...sanitizeConfigForJSON(project, new Set()),
name: project.project.name,
testDir: project.project.testDir,
use: { testIdAttribute: project.project.use.testIdAttribute },
files: await collectFilesForProject(project)
});
}
Expand Down Expand Up @@ -99,32 +112,3 @@ export class Runner {
return await runUIMode(config);
}
}

function sanitizeConfigForJSON(object: any, visited: Set<any>): any {
const type = typeof object;
if (type === 'function' || type === 'symbol')
return undefined;
if (!object || type !== 'object')
return object;

if (object instanceof RegExp)
return String(object);
if (object instanceof Date)
return object.toISOString();

if (visited.has(object))
return undefined;
visited.add(object);

if (Array.isArray(object))
return object.map(a => sanitizeConfigForJSON(a, visited));

const result: any = {};
const keys = Object.keys(object).slice(0, 100);
for (const key of keys) {
if (key.startsWith('_'))
continue;
result[key] = sanitizeConfigForJSON(object[key], visited);
}
return result;
}