fix: check common name for incompatible plugin #294
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the plugins check for the full names of the other plugin (
pytest_playwright.pytest_playwright
in async, andpytest_playwright_asyncio.pytest_playwright
in sync) against thePytestPluginManager
's name-to-plugindict
, in order to error if the other, incompatible, plugin has been loaded.However, in my project (and it seems like this is pretty common), plugins will be registered under the "common" name:
And so this will fail to raise the error, and we will get this one instead which is much less helpful:
This PR does an additional check for the "common" name, and then checks that the plugin itself has the matching canonical name, which should now handle this case.
As far as I can see, I couldn't find a decent way to register a plugin under a different name as part of the
pytest
invocation, and so I haven't added the additional test case.In the given example above though, this now gives us the expected error:
