Skip to content

Conversation

@justinchuby
Copy link
Collaborator

@justinchuby justinchuby commented Oct 29, 2025

Filter out size-0 tensors. When there is only one input, create an identity op instead of a concat op.

Fix #2660

Signed-off-by: Justin Chu <[email protected]>
@justinchuby justinchuby added the module: torchlib Related to the torch/aten function lib in development label Oct 29, 2025
@justinchuby justinchuby added this to the 0.5.5 milestone Oct 29, 2025
@justinchuby justinchuby enabled auto-merge (squash) October 29, 2025 02:30
@codecov
Copy link

codecov bot commented Oct 29, 2025

Codecov Report

❌ Patch coverage is 63.63636% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 70.41%. Comparing base (69025f7) to head (a421f57).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
onnxscript/function_libs/torch_lib/ops/core.py 63.63% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2661      +/-   ##
==========================================
- Coverage   70.41%   70.41%   -0.01%     
==========================================
  Files         224      224              
  Lines       26591    26600       +9     
  Branches     2641     2645       +4     
==========================================
+ Hits        18725    18730       +5     
- Misses       6943     6945       +2     
- Partials      923      925       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@justinchuby justinchuby merged commit 45b5189 into main Oct 29, 2025
33 checks passed
@justinchuby justinchuby deleted the justinchu/fix-concat branch October 29, 2025 05:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

module: torchlib Related to the torch/aten function lib in development

Projects

Development

Successfully merging this pull request may close these issues.

[torchlib] Filter out (0,) shaped tensors in aten_concat

4 participants