Skip to content

Conversation

@justinchuby
Copy link
Collaborator

@justinchuby justinchuby commented Oct 14, 2025

I forgot to remove the previous registration. Also fix aten.sub.Scalar.

Although I don't think we see the Scalar overload for these ops because we run the FX type promotion pass.

@justinchuby justinchuby added the module: torchlib Related to the torch/aten function lib in development label Oct 14, 2025
@justinchuby justinchuby enabled auto-merge (squash) October 14, 2025 02:05
Added scalar addition and subtraction operations for tensors.
@justinchuby justinchuby changed the title Remove redundant registration of operator::add Remove redundant registration of operator::add and fix sub.Scalar Oct 14, 2025
@justinchuby justinchuby added this to the 0.5.4 milestone Oct 14, 2025
@codecov
Copy link

codecov bot commented Oct 14, 2025

Codecov Report

❌ Patch coverage is 60.00000% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 70.38%. Comparing base (dd14682) to head (4fdd167).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
onnxscript/function_libs/torch_lib/ops/core.py 60.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2631      +/-   ##
==========================================
- Coverage   70.39%   70.38%   -0.01%     
==========================================
  Files         222      222              
  Lines       26281    26289       +8     
  Branches     2629     2629              
==========================================
+ Hits        18500    18504       +4     
- Misses       6861     6865       +4     
  Partials      920      920              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@justinchuby justinchuby merged commit b6a2d02 into main Oct 14, 2025
32 checks passed
@justinchuby justinchuby deleted the justinchuby-patch-2 branch October 14, 2025 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

module: torchlib Related to the torch/aten function lib in development

Projects

Development

Successfully merging this pull request may close these issues.

3 participants