Skip to content

python3.8 support #2233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
yokosyun opened this issue Apr 28, 2025 · 1 comment · Fixed by #2354
Closed

python3.8 support #2233

yokosyun opened this issue Apr 28, 2025 · 1 comment · Fixed by #2354

Comments

@yokosyun
Copy link

Issue

ptyhon3.8 is not compatible for onnxscript>0.2.3

type annotation is introduced from python3.9

related ticket

Solution

a. drop python3.8 support for onnxscript>0.2.3

b. use typeannotation from typing
@justinchuby justinchuby mentioned this issue Apr 28, 2025
Closed
@justinchuby
Copy link
Collaborator

Thank you - dropping python 3.8 support in #2234

@OYCN OYCN mentioned this issue May 19, 2025
Closed
@justinchuby justinchuby mentioned this issue May 29, 2025
Merged
justinchuby added a commit that referenced this issue May 29, 2025
@justinchuby
Formally drop python 3.8 support (#2354)
881369f 
Python 3.8 has reached EOL.

Fix #2233
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@justinchuby @yokosyun