Skip to content

[torchlib] Implement aten.embedding_bag.padding_idx #2219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
justinchuby opened this issue Apr 22, 2025 · 0 comments
Open

[torchlib] Implement aten.embedding_bag.padding_idx #2219

justinchuby opened this issue Apr 22, 2025 · 0 comments
Labels
contribution welcome We welcome code contributions for this good first issue Good for newcomers module: torchlib Related to the torch/aten function lib in development

Comments

@justinchuby
Copy link
Collaborator

justinchuby commented Apr 22, 2025

Model dlrm

ERR_export: Failed to convert the exported program to an ONNX model. [96mThis is step 3/3[0m of exporting the model to ONNX. Next steps:- If there is a missing ONNX function implement it and register it to the registry.- If there is an internal error during ONNX conversion debug the error and summit a PR to PyTorch.- Create an error report with torch.onnx.export(... report=True) and save the ExportedProgram as a pt2 file. Create an issue in the PyTorch GitHub repository against the [96monnx[0m component. Attach the error report and the pt2 model.## Exception summary<class 'AssertionError'>: padding_idx must not be None. This is likely a dispatcher error<class 'torch.onnx._internal.exporter._errors.GraphConstructionError'>: Error when calling function 'TracedOnnxFunction(<function aten_embedding_bag_padding_idx at 0x7f265502ff40>)' with args '[SymbolicTensor('p_model_emb_l_0_weight' type=Tensor(FLOAT16) shape=[100000064] producer=None index=None) SymbolicTensor('args_2_0' type=Tensor(INT64) shape=[100] producer=None index=None) SymbolicTensor('select' type=Tensor(INT64) shape=[1] producer=node_Gather_5 index=0) False 0 True None False None]' and kwargs '{}'<class 'torch.onnx._internal.exporter._errors.ConversionError'>: Error when translating node %embedding_bag : [num_users=1] = call_function[target=torch.ops.aten.embedding_bag.padding_idx](args = (%p_model_emb_l_0_weight %args_2_0 %select False 0 True None False None) kwargs = {}). See the stack trace for more information.(Refer to the full stack trace above for more information.)

@justinchuby justinchuby added contribution welcome We welcome code contributions for this module: torchlib Related to the torch/aten function lib in development good first issue Good for newcomers labels Apr 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution welcome We welcome code contributions for this good first issue Good for newcomers module: torchlib Related to the torch/aten function lib in development
Projects
None yet
Development

No branches or pull requests

1 participant