Skip to content

better error display #1344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
baywet merged 3 commits into from
Mar 8, 2022
Merged

better error display #1344

baywet merged 3 commits into from
Mar 8, 2022

Conversation

@baywet
Copy link
Member

@baywet baywet commented Mar 7, 2022 •
edited
Loading

fixes #1269

  • passes the cancellation token all the way from the system.command line host to async APIs to avoid getting task cancelled exceptions when users press ctrl + c
  • formats all the logging to use templates instead of doing string interpolation so logging APIs can do sampling and metrics
  • adds a global try catch/log to log a proper error message instead of throwing an exception to the user.

image

@MaggieKimani1 you might want to replicate this onto hidi.

@baywet baywet added this to the Community Preview milestone Mar 7, 2022
@baywet baywet added the generator Issues or improvements relater to generation capabilities. label Mar 7, 2022
@baywet baywet self-assigned this Mar 7, 2022
@baywet baywet enabled auto-merge March 7, 2022 20:35
@baywet baywet force-pushed the bugfix/error-display branch from 40e67d8 to f44d46a Compare March 7, 2022 20:54
@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 7, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

73.5% 73.5% Coverage
0.0% 0.0% Duplication

@baywet baywet merged commit 9344658 into main Mar 8, 2022
@baywet baywet deleted the bugfix/error-display branch March 8, 2022 05:55
@MaggieKimani1
Copy link

MaggieKimani1 commented Mar 8, 2022

@baywet yeah this would help us handle our errors in hidi better.

@baywet
Copy link
Member Author

baywet commented Mar 8, 2022

@MaggieKimani1 can you create an issue in OpenApi.net linking to this PR so your PM can track and schedule it please?

@MaggieKimani1
Copy link

MaggieKimani1 commented Mar 8, 2022

@baywet Already done. Adding you to the PR to review

@MaggieKimani1 MaggieKimani1 mentioned this pull request Mar 8, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@darrelmiller darrelmiller Awaiting requested review from darrelmiller

@zengin zengin Awaiting requested review from zengin

@MIchaelMainer MIchaelMainer Awaiting requested review from MIchaelMainer

@ddyett ddyett Awaiting requested review from ddyett

@peombwa peombwa Awaiting requested review from peombwa

@nikithauc nikithauc Awaiting requested review from nikithauc

@ramsessanchez ramsessanchez Awaiting requested review from ramsessanchez

1 more reviewer

@andrueastman andrueastman andrueastman approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@baywet baywet

Labels

generator Issues or improvements relater to generation capabilities.

Projects

None yet

Milestone

Community Preview

Development

Successfully merging this pull request may close these issues.

Improve handling of exceptions

4 participants

@baywet @MaggieKimani1 @andrueastman