This repository was archived by the owner on Jun 14, 2024. It is now read-only.
Add CoveringIndexTrait and CoveringIndexConfigTrait #516
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clee704
approved these changes
Dec 13, 2021
Comment on lines
+33
to
+34
| val schema: StructType | ||
| val includedColumns: Seq[String] |
There was a problem hiding this comment.
nit: I would rather not use val in traits unless there is a specific reason.
Refs:
Collaborator
Author
There was a problem hiding this comment.
Thanks! I'll address your comments in the next PR.
|
|
||
| override def statistics(extended: Boolean = false): Map[String, String] = { | ||
| simpleStatistics ++ (if (extended) extendedStatistics else Map.empty) | ||
| protected def copyIndex( |
| override def canHandleDeletedFiles: Boolean = hasLineageColumn | ||
|
|
||
| override def write(ctx: IndexerContext, indexData: DataFrame): Unit = { | ||
| protected def write(ctx: IndexerContext, indexData: DataFrame, mode: SaveMode): Unit = { |
| sortColumnNames = indexedColumns)) | ||
|
|
||
| private def simpleStatistics: Map[String, String] = { | ||
| protected def simpleStatistics: Map[String, String] = { |
| } | ||
|
|
||
| private def extendedStatistics: Map[String, String] = { | ||
| protected def extendedStatistics: Map[String, String] = { |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the context for this pull request?
What changes were proposed in this pull request?
CoveringIndex refactoring to support other covering index type - ZOrderCoveringIndex (#495)
Added CoveringIndexTrait & CoveringIndexConfigTrait to reduce duplicate code.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Refactoring change - tested by existing tests