Skip to content

Conversation

Saadnajmi
Copy link
Collaborator

@Saadnajmi Saadnajmi commented Mar 11, 2022

Platforms Impacted

  • iOS
  • macOS
  • win32 (Office)
  • windows
  • android

Description of changes

CAUTION: Don't merge until downstream dependencies are updated to RN 0.66 first

This change updates the entire repo to React Native 0.66. Because this is a fairly large change, I tried to have each individual commit to be easy-to-read steps.

Working:

  • iOS and macOS test apps boot fine and seem to work

Open issues:

  • We use "Picker" from React Native in several places. In RN 0.66, it is removed from Core and must be consumed from the community module. Furthermore, I think Picker just doesn't exist anymore for react-native-win32 so we need to move all usage of that in our repo away.
  • Windows crashes on boot. Probably because of the reason above, but we can autolink the community module for windows at least.

Verification

Ran the iOS and macOS test app. Still need to run Android, Windows, Win32

Pull request checklist

This PR has considered (when applicable):

  • Automated Tests
  • Documentation and examples
  • Keyboard Accessibility
  • Voiceover
  • Internationalization and Right-to-left Layouts

@Saadnajmi Saadnajmi requested a review from a team as a code owner March 11, 2022 23:27
@samuelfreiberg
Copy link
Contributor

I'd like to formulate a testing plan before this gets merged. I'm going to do a gap analysis on what we have in automation testing vs. everything we want to test. With an update this big, I think verification is super important. Perhaps we can sync early next week and discuss and testing plan with the whole team

@samuelfreiberg
Copy link
Contributor

And you mentioned: "Don't merge until downstream dependencies are updated to RN 0.66 first". How long do we intend that to take?

@Saadnajmi Saadnajmi mentioned this pull request Apr 9, 2022
10 tasks
Copy link
Contributor

@ValentinaKozlova ValentinaKozlova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How are we going to replace Picker? I see that there are a lot of suggestions to use react-native-picker-select. What do you think? I know we don't want to use a lot of third-party libraries but this one doesn't look bad

@ksiler
Copy link
Contributor

ksiler commented Jun 17, 2022

How are we going to replace Picker? I see that there are a lot of suggestions to use react-native-picker-select. What do you think? I know we don't want to use a lot of third-party libraries but this one doesn't look bad

@nabil-k is working on replacing the Picker control with either FURN Menu or FURN MenuButton on macOS and Win32 and using @react-native-community/picker for iOS and Android.

@nabil-k nabil-k mentioned this pull request Jun 30, 2022
10 tasks
@Saadnajmi
Copy link
Collaborator Author

Closing in favor of #1809

@Saadnajmi Saadnajmi closed this Jun 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants