-
Notifications
You must be signed in to change notification settings - Fork 168
Update to React Native 0.66 #1511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I'd like to formulate a testing plan before this gets merged. I'm going to do a gap analysis on what we have in automation testing vs. everything we want to test. With an update this big, I think verification is super important. Perhaps we can sync early next week and discuss and testing plan with the whole team |
And you mentioned: "Don't merge until downstream dependencies are updated to RN 0.66 first". How long do we intend that to take? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How are we going to replace Picker? I see that there are a lot of suggestions to use react-native-picker-select
. What do you think? I know we don't want to use a lot of third-party libraries but this one doesn't look bad
@nabil-k is working on replacing the Picker control with either FURN Menu or FURN MenuButton on macOS and Win32 and using @react-native-community/picker for iOS and Android. |
Closing in favor of #1809 |
Platforms Impacted
Description of changes
CAUTION: Don't merge until downstream dependencies are updated to RN 0.66 first
This change updates the entire repo to React Native 0.66. Because this is a fairly large change, I tried to have each individual commit to be easy-to-read steps.
Working:
Open issues:
Verification
Ran the iOS and macOS test app. Still need to run Android, Windows, Win32
Pull request checklist
This PR has considered (when applicable):