This repository was archived by the owner on Mar 4, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 53
chore: add TS support and remove hardcoded values from visual tests config #817
Merged
kuzhelov
merged 12 commits into
master
from
feat/add-ts-support-to-screener-interaction-tests
Feb 1, 2019
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
f763c05
add TS support
kuzhelov-ms a538f4f
fix port value
kuzhelov-ms ea146c5
adjust host URL values
kuzhelov-ms 5cb7fa8
Merge branch 'master' into feat/add-ts-support-to-screener-interactio…
kuzhelov b52c2f6
simplify steps extraction logic
kuzhelov-ms cf5785e
nit: improve readability
kuzhelov-ms e90f525
Merge branch 'feat/add-ts-support-to-screener-interaction-tests' of h…
kuzhelov-ms cb5f3f0
Update screener.config.js
layershifter 013019b
fix merge problem
kuzhelov-ms 2e3ad45
Merge branch 'master' into feat/add-ts-support-to-screener-interactio…
kuzhelov 8f92180
upd
kuzhelov-ms 317d720
Merge branch 'master' into feat/add-ts-support-to-screener-interactio…
kuzhelov File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
7 changes: 0 additions & 7 deletions
7
.../src/examples/components/Dropdown/Types/DropdownExampleSingleSelection.shorthand.steps.js
This file was deleted.
Oops, something went wrong.
13 changes: 13 additions & 0 deletions
13
.../src/examples/components/Dropdown/Types/DropdownExampleSingleSelection.shorthand.steps.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
import { Dropdown, Button, List } from '../../../../../../src' | ||
|
||
const steps = [ | ||
steps => steps.click(`.${Dropdown.className} .${Button.className}`).snapshot('Shows list'), | ||
steps => steps.click(`.${List.className} li:nth-child(3)`).snapshot('Selects an element'), | ||
steps => | ||
steps | ||
.click(`.${Dropdown.className} .${Button.className}`) | ||
.snapshot('Opens with selected element highlighted'), | ||
steps => steps.hover(`.${List.className} li:nth-child(2)`).snapshot('Highlights another element'), | ||
] | ||
|
||
export default steps |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we use just this?
If it requires
tsconfig
, this should work:There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let me check..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unfortunately, this doesn't help - but, actually, I would also expect that it should. Will take another look tomorrow, thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
taking this as a general problem (import expressions like this one could be met quite often in the code), will clean up this stuff in the dedicated PR. Currently wasn't able to come up with resolution, but will spend additional time today