This repository was archived by the owner on Mar 4, 2020. It is now read-only.
chore: add TS support and remove hardcoded values from visual tests config #817
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuzhelov
requested review from
dvdzkwsk,
layershifter,
levithomason,
miroslavstastny and
mnajdova
as code owners
kuzhelov
changed the title
kuzhelov
changed the title
kuzhelov
changed the title
Generated by 🚫 dangerJS |
…ttps://github.com/stardust-ui/react into feat/add-ts-support-to-screener-interaction-tests
| @@ -0,0 +1,13 @@ | |||
| import { Dropdown, Button, List } from '../../../../../../src' | |||
There was a problem hiding this comment.
Suggested change
| import { Dropdown, Button, List } from '../../../../../../src' | |
| import { Dropdown, Button, List } from '@stardust-ui/react' |
Can we use just this?
If it requires tsconfig, this should work:
require("ts-node").register({
project: "build/tsconfig.common.json",
});There was a problem hiding this comment.
unfortunately, this doesn't help - but, actually, I would also expect that it should. Will take another look tomorrow, thank you!
There was a problem hiding this comment.
taking this as a general problem (import expressions like this one could be met quite often in the code), will clean up this stuff in the dedicated PR. Currently wasn't able to come up with resolution, but will spend additional time today
layershifter
approved these changes
Jan 31, 2019
layershifter
deleted the
feat/add-ts-support-to-screener-interaction-tests
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces ability to consume TS modules in Screener configuration file.
This move allows to consume configuration parameters from
configmodule, as well as to remove hardcoded class selectors from specs of interactive tests.