This repository was archived by the owner on Mar 4, 2020. It is now read-only.
feat(pxToRem): remove global overrides for document styles #789
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuzhelov
requested review from
dvdzkwsk,
layershifter,
levithomason,
miroslavstastny and
mnajdova
as code owners
kuzhelov
changed the title
kuzhelov
changed the title
miroslavstastny
approved these changes
Jan 30, 2019
mnajdova
approved these changes
Jan 30, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO
Dropdown,RadioGroup) and font size declared in site variables.This PR aims to remove any global 'set' effects of Stardust font size utility (
pxToRem). The following changes are introducedsetFontSizefunctionality that allows to change global font size of HTML documentThese steps are necessary to ensure that each theme that is loaded by Stardust provider won't affect already existed font size styles (defined by the host HTML document).
Removed
htmlFontSizevariable will be introduced as part of theme (or Provider's) prop, so that this parameter could be customized individually for each loaded theme (without affecting other styles rendered on the page) - this is removed as currently this prop is unable to produce desired effect: it just changes the global font size of the HTML document