Skip to content
This repository was archived by the owner on Mar 4, 2020. It is now read-only.

docs: Removing Semantic UI from Stardust- DocSite #679

Merged
merged 81 commits into from
Feb 18, 2019

Conversation

hughreeling
Copy link
Contributor

@hughreeling hughreeling commented Jan 3, 2019

Removes all references to Semantic UI from Stardust.

Updates code to use Stardust controls.

Attempts some basic accessibility fixes.

Breaking change
Removes reliance on Semantic UI for Font Awesome icons, instead references them directly.
Code using them would need to include them implicitly.

Updated Dark Theme to include variants for List and Menu

Known issues:

  • find a way to isolate the component examples in the docSite to not interfere with the docSite theme (use an iframe for this purpose)

  • update documentation on limitation of Provider usage (is there any issue if using more than a certain number of Providers?)

  • themes switching dropdown doesn't show the list items on the first render
    image

  • reenable searching for components in sidebar
    image

  • active state of the links in the sidebar menu is missing

  • fix the theming switch - the examples headers are changing background but not the text
    image

  • bring back the right floating menu
    image

  • address the code optimization suggestions marked as TODO: in docs

@alinais
Copy link
Contributor

alinais commented Feb 18, 2019

most of comments are divided in 2 categories:

  • comments that should be addressed in this PR are marked with TO ADDRESS NOW
  • comments that are there for tracking upcoming work: For tracking

Comments have been addressed. @Bugaa92 , for the record, it is not a good practice to request for changes and not check whether they were addressed.

@mnajdova, thank you for your help with review/ verification.

@alinais alinais merged commit 0263f73 into master Feb 18, 2019
@layershifter layershifter deleted the hueland/stardustDocSite branch February 19, 2019 09:14
@bmdalex
Copy link
Collaborator

bmdalex commented Feb 19, 2019

Comments have been addressed. @Bugaa92 , for the record, it is not a good practice to request for changes and not check whether they were addressed.

@alinais Generally speaking, I'd argue that it is the responsibility of the developer that created the PR to update reviewers that their comments have been addressed. It's unrealistic to expect a reviewer to refresh and check for updates all their reviews on multiple PRs.

Specifically, I was on vacation until today and comments were still not addressed before I left. A good practice would be to contact me directly regarding this kind of issues.

Thanks for addressing the comments!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants