-
Notifications
You must be signed in to change notification settings - Fork 53
docs: Removing Semantic UI from Stardust- DocSite #679
Conversation
…eland/stardustDocSite
…eland/stardustDocSite
…eland/stardustDocSite
…-ui/react into hueland/stardustDocSite
…eland/stardustDocSite
docs/src/components/ComponentDoc/ComponentExample/ComponentExample.tsx
Outdated
Show resolved
Hide resolved
…-ui/react into hueland/stardustDocSite
Comments have been addressed. @Bugaa92 , for the record, it is not a good practice to request for changes and not check whether they were addressed. @mnajdova, thank you for your help with review/ verification. |
@alinais Generally speaking, I'd argue that it is the responsibility of the developer that created the PR to update reviewers that their comments have been addressed. It's unrealistic to expect a reviewer to refresh and check for updates all their reviews on multiple PRs. Specifically, I was on vacation until today and comments were still not addressed before I left. A good practice would be to contact me directly regarding this kind of issues. Thanks for addressing the comments! |
Removes all references to Semantic UI from Stardust.
Updates code to use Stardust controls.
Attempts some basic accessibility fixes.
Breaking change
Removes reliance on Semantic UI for Font Awesome icons, instead references them directly.
Code using them would need to include them implicitly.
Updated Dark Theme to include variants for List and Menu
Known issues:
find a way to isolate the component examples in the docSite to not interfere with the docSite theme (use an iframe for this purpose)
update documentation on limitation of Provider usage (is there any issue if using more than a certain number of Providers?)
themes switching dropdown doesn't show the list items on the first render

reenable searching for components in sidebar

active state of the links in the sidebar menu is missing
fix the theming switch - the examples headers are changing background but not the text

bring back the right floating menu

address the code optimization suggestions marked as
TODO:
in docs