This repository was archived by the owner on Mar 4, 2020. It is now read-only.
chore(eslint): add lint rule to disable access modifiers #1458
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ore/add-modifiers-lint # Conflicts: # docs/src/components/ExternalExampleLayout.tsx # packages/react/src/components/Attachment/Attachment.tsx # packages/react/src/components/Chat/Chat.tsx # packages/react/src/components/Chat/ChatMessage.tsx # packages/react/src/components/List/ListItem.tsx # packages/react/src/components/Menu/MenuItem.tsx # packages/react/src/components/Popup/Popup.tsx # packages/react/src/components/Portal/Portal.tsx # packages/react/src/components/RadioGroup/RadioGroup.tsx # packages/react/src/components/Tree/TreeTitle.tsx
Changed dependencies in
Generated by 🚫 dangerJS |
layershifter
requested review from
dvdzkwsk,
kuzhelov,
levithomason,
miroslavstastny and
mnajdova
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1458 +/- ##
=======================================
Coverage 73.14% 73.14%
=======================================
Files 805 805
Lines 6073 6073
Branches 1794 1794
=======================================
Hits 4442 4442
Misses 1625 1625
Partials 6 6
Continue to review full report at Codecov.
|
| */ | ||
| function checkMethodAccessibilityModifier(methodDefinition) { | ||
| let nodeType = 'method definition' | ||
| switch (methodDefinition.kind) { |
There was a problem hiding this comment.
if (['get', 'set'].includes(methodDefinition.kind)
miroslavstastny
approved these changes
Jun 6, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #936.
This PR adds a new rule that disallows to use access modifiers (
private,public,protected) for.tsxfiles.It also adds a new package
@stardust-ui/eslint-pluginbecause it's required by ESLint, i.e. you can't simply place a file with rules somewhere, only in the package that has correct naming:https://eslint.org/docs/developer-guide/working-with-plugins