Skip to content

Conversation

kaibocai
Copy link
Member

@kaibocai kaibocai commented Dec 15, 2023

This PR is a follow-up PR for #46. It include some updates to support reuse ID policy in dapr workflow

Related issue #42

create alias for protos type

update test

move duplicate code outside backend implementation

update paramter name
@kaibocai kaibocai marked this pull request as ready for review December 15, 2023 18:04
@kaibocai kaibocai requested a review from cgillum December 15, 2023 18:05
@kaibocai
Copy link
Member Author

tag @ItalyPaleAle , @RyanLettieri for review.

Copy link
Member

@cgillum cgillum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few questions from me:

@kaibocai kaibocai force-pushed the kaibocai/reuse-id-dapr branch 2 times, most recently from 76c6eeb to fde7991 Compare December 15, 2023 21:50
simplify status check

update tests

clean up

fix test
@kaibocai kaibocai force-pushed the kaibocai/reuse-id-dapr branch from fde7991 to 12222af Compare December 15, 2023 21:54
Copy link
Member

@cgillum cgillum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Glad to have this change! Let's wait to merge until the Dapr PR which uses it is also signed off.

@cgillum cgillum changed the title Reuse ID policy support for Dapr workflow Orchestration ID reuse policies Dec 18, 2023
@kaibocai kaibocai merged commit d7bb0ed into main Dec 18, 2023
@cgillum cgillum deleted the kaibocai/reuse-id-dapr branch December 18, 2023 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants