Clarify TDD doesn't mean write *all* tests first #1083
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was already written well, and the separate article ./tdd.md is excellent. However, I think the language could be a little clearer to dispell the common misconception that TDD means you write all your tests first. I trust this is clear to TDD practitioners, but I commonly see "senior" engineers misunderstand this. Kent Beck sees this so commonly that he wrote a [little article](https://tidyfirst.substack.com/p/canon-tdd) on the subject. My org was using this document for training engineers, and am hoping this small change will make it even more helpful.
joshua-koehler
requested review from
TessFerrandez,
nyouens and
shiranr
as code owners
nyouens
approved these changes
Jan 22, 2025
shiranr
approved these changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was already written well, and the separate article
./tdd.mdis excellent. However, I think the language could be a little clearer to dispell the common misconception that TDD means you write all your tests first. I trust this is clear to TDD practitioners, but I commonly see "senior" engineers misunderstand this.Kent Beck sees this so commonly that he wrote a little article on the subject.
My org was using this document for training engineers, and am hoping this small change will make it even more helpful.
I also made a minor change to the first sentence. I understand it to be conveying one benefit of TDD, namely that it makes the code more testable, and thought it could be made more succinct. Furthermore, many tout TDD as a mechanism for design, so explicitly negating that benefit is perhaps likely to cause unintended controversy.