Skip to content

Conversation

@PawelWMS
Copy link
Contributor

@PawelWMS PawelWMS commented Feb 26, 2022

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/tools/cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./SPECS/LICENSES-AND-NOTICES/data/licenses.json, ./SPECS/LICENSES-AND-NOTICES/LICENSES-MAP.md, ./SPECS/LICENSES-AND-NOTICES/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge

Summary

We have a growing need to use Mariner's packages in distroless containers and one of the frequently hit issues is that packages have a an implicit dependency on the shell either by having a %(post|pre) section or by containing scripts, which depend on an interpreted through the #! line. This PR removes shell dependencies from the icu and krb5 packages. The assumption is that distroless images do not include a shell, so there's no expectation to be able to run any shell scripts and non-distroless images always have a shell (Bash) installed, so it's present anyway.

Change Log
  • Removed dependency on a shell from icu and krb5.
Does this affect the toolchain?

No.

Test Methodology
  • Local package builds.

@PawelWMS PawelWMS requested review from a team and jslobodzian February 26, 2022 01:24
Copy link
Member

@mfrw mfrw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
I was able to build normally but mock build seemed to fail.
Let's probably tread with care :)

@PawelWMS PawelWMS force-pushed the pawelwi/making_packages_distroless branch from 6e61087 to a5c43b8 Compare February 28, 2022 21:59
@PawelWMS PawelWMS changed the title [main] Separating 'distroless' packages. [main] Removing shell dependency from icu and krb5 packages. Feb 28, 2022
@PawelWMS PawelWMS merged commit d658bfa into microsoft:main Feb 28, 2022
@PawelWMS PawelWMS deleted the pawelwi/making_packages_distroless branch February 28, 2022 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants