User/getrou/lottieisland #340
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've added a few comments to the PR. Can you update to address them? #Closed |
jeffstall
reviewed
May 7, 2024
Samples/Islands/DrawingIsland/DrawingCsTestApp/LottieIslandScenario.cs
Outdated
Show resolved
Hide resolved
Samples/Islands/DrawingIsland/DrawingCsTestApp/LottieIslandScenario.cs
Outdated
Show resolved
Hide resolved
| using CommunityToolkit.WinAppSDK.LottieIsland; | ||
| using CommunityToolkit.WinAppSDK.LottieWinRT; | ||
| using CommunityToolkit.WinUI.Lottie; | ||
| using System.Diagnostics; |
There was a problem hiding this comment.
Put System. namespaces at the top, above Microsoft. namespaces. #Closed
Samples/Islands/DrawingIsland/DrawingCppTestApp/LottieIslandScenario.cpp
Outdated
Show resolved
Hide resolved
jeffstall
reviewed
May 8, 2024
| </packageRestore> | ||
| <packageSources> | ||
| <clear /> | ||
| <add key="nuget.org" value="https://api.nuget.org/v3/index.json" /> |
There was a problem hiding this comment.
What does removing this do to all of the other NuGets in the repo? For example, how other samples are bringing in WinAppSDK?
|
[heart] Geoffrey Trousdale (THEY/THEM) reacted to your message:
…________________________________
From: Jeffrey Stall ***@***.***>
Sent: Wednesday, May 8, 2024 4:53:32 AM
To: microsoft/WindowsAppSDK-Samples ***@***.***>
Cc: Geoffrey Trousdale (THEY/THEM) ***@***.***>; Author ***@***.***>
Subject: Re: [microsoft/WindowsAppSDK-Samples] User/getrou/lottieisland (PR #340)
Merged #340<#340> into user/jeffstall/drawingisland.
—
Reply to this email directly, view it on GitHub<#340 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AMUHEYDNFV6MONCB5JIF4ATZBGVUZAVCNFSM6AAAAABHJ5NAP6VHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJSG4ZTQMJWHE3DSOI>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add LottieIsland to the DrawingIsland Sample