Skip to content

Swap q from a reference to an import #9556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 7, 2016
Merged

Swap q from a reference to an import #9556

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4b5f7e5
Swap q from a reference to an import
weswigham Jul 7, 2016
f9102d0
Update comment to reflect new dependency
weswigham Jul 7, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions Gulpfile.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,4 @@
/// <reference path="scripts/types/ambient.d.ts" />
/// <reference types="q" />

import * as cp from "child_process";
import * as path from "path";
import * as fs from "fs";
Expand All @@ -20,9 +18,9 @@ declare module "gulp-typescript" {
}
import * as insert from "gulp-insert";
import * as sourcemaps from "gulp-sourcemaps";
import Q = require("q");
declare global {
// This is silly. We include Q because orchestrator (a part of gulp) depends on it, but its not included.
// `del` further depends on `Promise` (and is also not included), so we just, patch the global scope's Promise to Q's
// `del` further depends on `Promise` (and is also not included), so we just, patch the global scope's Promise to Q's (which we already include in our deps because gulp depends on it)
type Promise<T> = Q.Promise<T>;
}
import del = require("del");
Expand Down