[Transforms] Do not emit ES6 import/export inside namespaces #8027
+35
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ES6 imports and exports are illegal inside namespaces. In order to emit syntactically legal code, skip emit for these incorrect statements.
sandersn
changed the title
| (node.kind === SyntaxKind.ImportEqualsDeclaration && | ||
| (<ImportEqualsDeclaration>node).moduleReference.kind === SyntaxKind.ExternalModuleReference)) { | ||
| // do not emit ES6 imports and exports since they are illegal inside a namespace | ||
| return createNotEmittedStatement(node); |
There was a problem hiding this comment.
just curious, why createNotEmittedStatements instead of just return undefined? Do we really need to preserve comments for illegally placed nodes?
There was a problem hiding this comment.
Well, I was trying to minimise the number of differences with the old emit, but createNotEmittedStatement didn't seem to work. I can definitely go back to return undefined.
|
Assuming you address @vladima's comment above, 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7874
ES6 imports and exports are illegal inside namespaces. In order to emit syntactically legal code, skip emit for these incorrect statements.
Fixes tests:
*Still has some incorrect, unrelated emit at the end of the module