[Transforms] Fix for incorrect namespace qualification. #7977
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if (fs.existsSync(localBaseline)) { | ||
| jake.rmRf(localBaseline); | ||
| } | ||
| if (!environmentVariableIsDisabled("CLEAN_TESTS")) { |
There was a problem hiding this comment.
instead of checking an environment variable to skip cleaning, a separate task called "runtest-dirty" or "runtest-noclean" would be safer. At least if somebody does $env:CLEAN_TESTS = "no" and forgets, they'll get very confusing baseline-accept runs later.
| case SyntaxKind.ExportDeclaration: | ||
| const exportClause = (<ExportDeclaration>node).exportClause; | ||
| return exportClause && forEach(exportClause.elements, isValueAliasDeclaration); | ||
| case SyntaxKind.ExportAssignment: | ||
| return (<ExportAssignment>node).expression && (<ExportAssignment>node).expression.kind === SyntaxKind.Identifier ? isAliasResolvedToValue(getSymbolOfNode(node)) : true; |
There was a problem hiding this comment.
this line is way too long to read on github
|
👍 for this change, although |
|
I can modify emitter to no longer use |
|
👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves a lot of the
getOriginalNodechecks to the emit resolver to simplify the transformers.This also fixes namespace qualification issues for module declarations (#7868).
Fixes the following failing tests: