[Transforms] Correct destructuring assignment to empty object #7970
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, chained destructuring object assignments would fail when the leftmost target was empty because the shortcut code would forget to check whether the right-hand side was also a destructuring assignment.
|
👍 No update on the baselines? |
sandersn
changed the title
|
Good idea. I'll see if any are completely fixed. |
|
Fixed emptyAssignmentPatterns02_ES5 and emptyAssignmentPatterns03_ES5. 02 removes some unneeded parentheses too; there is no change for 03. |
|
Look good :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7863
Previously, chained destructuring object assignments would fail when the leftmost target was empty because the shortcut code would forget to check whether the right-hand side was also a destructuring assignment.