Skip to content

Additional fixes for JSX transforms #7842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 6, 2016
Merged

Conversation

rbuckton
Copy link
Contributor

@rbuckton rbuckton commented Apr 5, 2016

This fixes qualified names for JSX emit, formatting for TSX emit, and a few other odds and ends with the JSX transforms.

@rbuckton rbuckton changed the title Transforms fix jsx2 Additional fixes for JSX transforms Apr 5, 2016
@rbuckton rbuckton added the Domain: Transforms Relates to the public transform API label Apr 5, 2016
@rbuckton
Copy link
Contributor Author

rbuckton commented Apr 5, 2016

CC: @vladima, @DanielRosenwasser, @yuit

@@ -1536,7 +1534,7 @@ const _super = (function (geti, seti) {
write("interface ");
emit(node.name);
emitTypeParameters(node, node.typeParameters);
emitList(node, node.heritageClauses, ListFormat.SingleLine);
emitList(node, node.heritageClauses, ListFormat.HeritageClauses);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems unrelated to JSX?

@RyanCavanaugh
Copy link
Member

👍

@DanielRosenwasser
Copy link
Member

LGTM

@rbuckton rbuckton merged commit 35a4c42 into transforms Apr 6, 2016
@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Domain: Transforms Relates to the public transform API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants