Fix generic default construct signature inheritance #7569
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When getting a default construct signature, if there is base with a generic construct signature, the signature needs to be instantiated with the type parameters from the derived class. When doing this however, the target should not refer back to the base class -- the default construct signature is considered separate from the base's signature. Unset the instantiated signature's target to make this happen.
|
The correct fix is in #8713. The fix is not to unset the target, but to remove the target-following code in |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6783
When getting a default construct signature, if there is base with a generic construct signature, the signature needs to be instantiated with the type parameters from the derived class. When doing this however, the target should not refer back to the base class -- the default construct signature is considered separate from the base's signature.
Unset the instantiated signature's target to make this happen.