-
Notifications
You must be signed in to change notification settings - Fork 12.8k
Fix find all references for salsa #6632
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+110
−0
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
e4ab2db
Fix find all references for salsa
zhengbli b389e9c
Fix for thisProperty
zhengbli 9a6815f
add tests
zhengbli 10f9a85
Merge branch 'master' of https://github.com/Microsoft/TypeScript into…
zhengbli 646e46e
Fix build error
zhengbli 5ced4c4
Merge branch 'master' of https://github.com/Microsoft/TypeScript into…
zhengbli bf897c2
Add more tests and comments
zhengbli File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
/// <reference path='fourslash.ts'/> | ||
|
||
// @allowJs: true | ||
// @Filename: a.js | ||
////exports.[|area|] = function (r) { return r * r; } | ||
|
||
// @Filename: b.ts | ||
////import { [|area|] } from './a'; | ||
////var t = /**/[|area|](10); | ||
|
||
goTo.marker(); | ||
verify.renameLocations( /*findInStrings*/ false, /*findInComments*/ false); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
/// <reference path='fourslash.ts'/> | ||
|
||
// @allowJs: true | ||
// @Filename: a.js | ||
////exports./**/[|area|] = function (r) { return r * r; } | ||
|
||
// @Filename: b.ts | ||
////import { [|area|] } from './a'; | ||
////var t = [|area|](10); | ||
|
||
goTo.marker(); | ||
verify.renameLocations( /*findInStrings*/ false, /*findInComments*/ false); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
/// <reference path='fourslash.ts'/> | ||
|
||
// @allowJs: true | ||
// @Filename: a.js | ||
////exports.[|area|] = function (r) { return r * r; } | ||
|
||
// @Filename: b.js | ||
////var mod = require('./a'); | ||
////var t = mod./**/[|area|](10); | ||
|
||
goTo.marker(); | ||
verify.renameLocations( /*findInStrings*/ false, /*findInComments*/ false); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
/// <reference path='fourslash.ts'/> | ||
|
||
// @allowJs: true | ||
// @Filename: a.js | ||
////exports./**/[|area|] = function (r) { return r * r; } | ||
|
||
// @Filename: b.js | ||
////var mod = require('./a'); | ||
////var t = mod.[|area|](10); | ||
|
||
goTo.marker(); | ||
verify.renameLocations( /*findInStrings*/ false, /*findInComments*/ false); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
/// <reference path='fourslash.ts'/> | ||
|
||
// @allowJs: true | ||
// @Filename: a.js | ||
////function bar() { | ||
////} | ||
////bar.prototype.[|x|] = 10; | ||
////var t = new bar(); | ||
////t./**/[|x|] = 11; | ||
|
||
goTo.marker(); | ||
verify.renameLocations( /*findInStrings*/ false, /*findInComments*/ false); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
/// <reference path='fourslash.ts'/> | ||
|
||
// @allowJs: true | ||
// @Filename: a.js | ||
////function bar() { | ||
////} | ||
////bar.prototype./**/[|x|] = 10; | ||
////var t = new bar(); | ||
////t.[|x|] = 11; | ||
|
||
goTo.marker(); | ||
verify.renameLocations( /*findInStrings*/ false, /*findInComments*/ false); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
/// <reference path='fourslash.ts'/> | ||
|
||
// @allowJs: true | ||
// @Filename: a.js | ||
////function bar() { | ||
//// this.[|x|] = 10; | ||
////} | ||
////var t = new bar(); | ||
////t./**/[|x|] = 11; | ||
|
||
goTo.marker(); | ||
verify.renameLocations( /*findInStrings*/ false, /*findInComments*/ false); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
/// <reference path='fourslash.ts'/> | ||
|
||
// @allowJs: true | ||
// @Filename: a.js | ||
////function bar() { | ||
//// this./**/[|x|] = 10; | ||
////} | ||
////var t = new bar(); | ||
////t.[|x|] = 11; | ||
|
||
goTo.marker(); | ||
verify.renameLocations( /*findInStrings*/ false, /*findInComments*/ false); |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume in most cases it won't be a "specialPropertyAssignmentKind" and you will just fall through here? Can you make this clear in the code by explicitly adding a
default:
with just a comment to this effect, or wrapping theswitch
in anif(specialPropertyAssignmentKind...)
?