Fix find all refs in shorthand properties for imports and exports #6376
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return declaration.kind === SyntaxKind.ImportSpecifier || declaration.kind === SyntaxKind.ExportSpecifier; | ||
| }); | ||
| function isImportSpecifierSymbol(symbol: Symbol) { | ||
| return (symbol.flags & SymbolFlags.Alias) && forEach(symbol.declarations, declaration => declaration.kind === SyntaxKind.ImportSpecifier); |
There was a problem hiding this comment.
Use getDeclarationOfKind
|
@DanielRosenwasser any more comments? |
|
would this address #3688 as well? |
|
Nice catch @adidahiya! I think it should. @mhegazy can you confirm that? Consider adding a document highlights test if you think it would be appropriate. I'm still not huge on the naming, but if you think it's fine, 👍 |
|
@mhegazy friendly ping here. would be great to have this fixed in 1.8. thanks |
|
this does not handle #3688. i will need to send a different PR for that one. |
mhegazy
added a commit
that referenced
this pull request
Jan 14, 2016
Fix find all refs in shorthand properties for imports and exports
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to the issue reported in #6367. the change include:
SymbolFlags.Aliasto the search ingetShorthandAssignmentValueSymbolto avoid resolving import aliases to their target.