Fix incorrectly emitting underscore of imported property #6194
Conversation
src/compiler/utilities.ts
Outdated
There was a problem hiding this comment.
I liked the short form better, although putting it in its own function is nice.
|
I don't see the tests yet. |
…peScript into fix4867_transpiling
There was a problem hiding this comment.
add a comment why do we need to unescape the text here
src/compiler/utilities.ts
Outdated
There was a problem hiding this comment.
prefixedWithUnderscores
There was a problem hiding this comment.
Below we use identifier.length >= 3 so make these align.
|
@DanielRosenwasser @sandersn @vladima any comment? |
src/compiler/utilities.ts
Outdated
There was a problem hiding this comment.
What is the purpose of changing the comparison from identifier.length >= 2 to identifier.length >= 3? With this change, we won't escape __a to ___a. Is that expected?
There was a problem hiding this comment.
Thanks @rbuckton for pointing this out. we don't really need the check any more since we will unescape anyway
|
👍 |
|
:+!: |
Fix incorrectly emitting underscore of imported property
Fix #4867