Skip to content

Fix --showConfig to show transitively implied options that vary from the default config #60240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 16, 2024

Conversation

andrewbranch
Copy link
Member

Fixes #59442

#56701 made it so --showConfig shows implied compiler options if their implied value differs from what you’d get with no config. However, it mistakenly only showed implied options that were affected by an explicitly set option, while failing to show implied options that were affected by other implied options. For example, setting --module nodenext implies --moduleResolution nodenext, which implies --resolvePackageJsonExports. But --resolvePackageJsonExports previously didn’t show up with --module nodenext --showConfig.

@typescript-bot typescript-bot added Author: Team For Milestone Bug PRs that fix a bug with a specific milestone labels Oct 15, 2024
Copy link
Member

@jakebailey jakebailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In any case, LGTM, the seen thing is a cleanup

@andrewbranch andrewbranch merged commit b8e4ed8 into microsoft:main Oct 16, 2024
32 checks passed
@andrewbranch andrewbranch deleted the bug/59442 branch October 16, 2024 18:18
@sandersn sandersn removed this from PR Backlog Apr 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Author: Team For Milestone Bug PRs that fix a bug with a specific milestone
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Potentially wrong 'showConfig' results for default values, as it's used in the checker differently.
3 participants