Revert "Fix incorrect condition of noLib" (PR 58867) #58935

jakebailey · 2024-06-19T18:42:42Z

It looks like #58867 caused some regressions; vscode benchmark crashes on --diagnostics, and even if that crash is fixed, it fails to resolve lib and gets more errors.

This reverts commit 4239025.

jakebailey · 2024-06-19T18:42:52Z

@typescript-bot test it

typescript-bot · 2024-06-19T18:42:55Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`test top400`	✅ Started	✅ Results
`user test this`	✅ Started	✅ Results
`run dt`	✅ Started	✅ Results
`perf test this faster`	✅ Started	👀 Results

typescript-bot · 2024-06-19T19:03:36Z

Hey @jakebailey, the results of running the DT tests are ready.

Everything looks the same!

You can check the log here.

typescript-bot · 2024-06-19T19:06:19Z

@jakebailey Here are the results of running the user tests with tsc comparing main and refs/pull/58935/merge:

Everything looks good!

typescript-bot · 2024-06-19T19:24:48Z

@jakebailey
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-Unions - node (v18.15.0, x64)}
_Errors	₃₀	₃₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_62,153	_62,153	_~	_~	_~	_{p=1.000 n=6}
_Types	_50,242	_50,242	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{192,673k (± 0.76%)}	_{192,749k (± 0.79%)}	_~	_192,112k	_195,843k	_{p=0.575 n=6}
_{Parse Time}	_{1.94s (± 2.19%)}	_{1.95s (± 1.47%)}	_~	_1.90s	_1.98s	_{p=0.745 n=6}
_{Bind Time}	_{1.06s (± 0.77%)}	_{1.05s (± 1.15%)}	_~	_1.04s	_1.07s	_{p=0.157 n=6}
_{Check Time}	_{13.84s (± 0.54%)}	_{13.83s (± 0.43%)}	_~	_13.72s	_13.88s	_{p=0.466 n=6}
_{Emit Time}	_{4.10s (± 3.50%)}	_{4.03s (± 1.20%)}	_~	_3.94s	_4.07s	_{p=0.744 n=6}
_{Total Time}	_{20.94s (± 0.76%)}	_{20.87s (± 0.34%)}	_~	_20.77s	_20.94s	_{p=0.521 n=6}
_{angular-1 - node (v18.15.0, x64)}
_Errors	₅	₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_944,114	_944,114	_~	_~	_~	_{p=1.000 n=6}
_Types	_407,051	_407,051	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{1,218,298k (± 0.00%)}	_{1,218,300k (± 0.00%)}	_~	_1,218,249k	_1,218,348k	_{p=1.000 n=6}
_{Parse Time}	_{7.95s (± 0.33%)}	_{7.94s (± 0.57%)}	_~	_7.89s	_8.00s	_{p=0.573 n=6}
_{Bind Time}	_{2.23s (± 0.87%)}	_{2.23s (± 0.44%)}	_~	_2.22s	_2.25s	_{p=0.934 n=6}
_{Check Time}	_{35.74s (± 0.33%)}	_{35.68s (± 0.36%)}	_~	_35.50s	_35.80s	_{p=0.377 n=6}
_{Emit Time}	_{16.11s (± 0.51%)}	_{16.11s (± 0.35%)}	_~	_16.03s	_16.19s	_{p=1.000 n=6}
_{Total Time}	_{62.03s (± 0.22%)}	_{61.96s (± 0.21%)}	_~	_61.77s	_62.14s	_{p=0.423 n=6}
_{mui-docs - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,133,420	_2,133,420	_~	_~	_~	_{p=1.000 n=6}
_Types	_926,456	_926,456	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,115,588k (± 0.00%)}	_{2,115,476k (± 0.00%)}	_{-112k (- 0.01%)}	_2,115,389k	_2,115,656k	_{p=0.031 n=6}
_{Parse Time}	_{7.85s (± 0.39%)}	_{7.85s (± 0.56%)}	_~	_7.80s	_7.90s	_{p=0.808 n=6}
_{Bind Time}	_{2.74s (± 0.50%)}	_{2.74s (± 0.64%)}	_~	_2.72s	_2.76s	_{p=1.000 n=6}
_{Check Time}	_{83.52s (± 0.40%)}	_{83.32s (± 0.45%)}	_~	_82.88s	_83.84s	_{p=0.378 n=6}
_{Emit Time}	_{0.15s (± 3.53%)}	_{0.16s (± 4.65%)}	_~	_0.15s	_0.17s	_{p=0.137 n=6}
_{Total Time}	_{94.26s (± 0.35%)}	_{94.06s (± 0.37%)}	_~	_93.65s	_94.53s	_{p=0.378 n=6}
_{self-build-src - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,230,762	_1,230,692	_{-70 (- 0.01%)}	_~	_~	_{p=0.001 n=6}
_Types	_261,187	_261,165	_{-22 (- 0.01%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,345,950k (± 0.05%)}	_{2,356,136k (± 1.04%)}	_~	_2,344,282k	_2,406,139k	_{p=0.378 n=6}
_{Parse Time}	_{6.02s (± 0.86%)}	_{5.95s (± 0.89%)}	_~	_5.90s	_6.04s	_{p=0.054 n=6}
_{Bind Time}	_{2.26s (± 1.23%)}	_{2.27s (± 1.50%)}	_~	_2.23s	_2.32s	_{p=1.000 n=6}
_{Check Time}	_{39.66s (± 0.31%)}	_{39.75s (± 0.20%)}	_~	_39.63s	_39.86s	_{p=0.128 n=6}
_{Emit Time}	_{3.18s (± 2.57%)}	_{3.13s (± 3.58%)}	_~	_3.01s	_3.32s	_{p=0.229 n=6}
_{Total Time}	_{51.14s (± 0.34%)}	_{51.13s (± 0.22%)}	_~	_50.94s	_51.28s	_{p=0.688 n=6}
_{self-build-src-public-api - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,230,762	_1,230,692	_{-70 (- 0.01%)}	_~	_~	_{p=0.001 n=6}
_Types	_261,187	_261,165	_{-22 (- 0.01%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,432,208k (± 1.00%)}	_{2,423,048k (± 0.02%)}	_~	_2,422,320k	_2,423,641k	_{p=0.689 n=6}
_{Parse Time}	_{7.73s (± 0.84%)}	_{7.65s (± 0.58%)}	_~	_7.58s	_7.70s	_{p=0.066 n=6}
_{Bind Time}	_{2.50s (± 2.04%)}	_{2.47s (± 1.04%)}	_~	_2.43s	_2.50s	_{p=0.374 n=6}
_{Check Time}	_{49.44s (± 0.47%)}	_{49.42s (± 0.31%)}	_~	_49.15s	_49.59s	_{p=0.936 n=6}
_{Emit Time}	_{3.88s (± 2.87%)}	_{3.83s (± 1.02%)}	_~	_3.78s	_3.90s	_{p=0.470 n=6}
_{Total Time}	_{63.57s (± 0.52%)}	_{63.39s (± 0.25%)}	_~	_63.14s	_63.57s	_{p=0.298 n=6}
_{self-compiler - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_258,573	_258,573	_~	_~	_~	_{p=1.000 n=6}
_Types	_104,819	_104,819	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{428,184k (± 0.02%)}	_{428,194k (± 0.00%)}	_~	_428,173k	_428,215k	_{p=0.230 n=6}
_{Parse Time}	_{3.31s (± 0.90%)}	_{3.34s (± 0.92%)}	_~	_3.30s	_3.39s	_{p=0.196 n=6}
_{Bind Time}	_{1.30s (± 0.90%)}	_{1.33s (± 1.23%)}	_{+0.03s (+ 1.92%)}	_1.31s	_1.35s	_{p=0.023 n=6}
_{Check Time}	_{17.80s (± 0.35%)}	_{17.77s (± 0.23%)}	_~	_17.73s	_17.83s	_{p=0.229 n=6}
_{Emit Time}	_{1.35s (± 0.86%)}	_{1.36s (± 0.72%)}	_~	_1.35s	_1.37s	_{p=0.181 n=6}
_{Total Time}	_{23.77s (± 0.32%)}	_{23.79s (± 0.20%)}	_~	_23.72s	_23.84s	_{p=0.572 n=6}
_{ts-pre-modules - node (v18.15.0, x64)}
_Errors	₃₅	₃₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_224,565	_224,565	_~	_~	_~	_{p=1.000 n=6}
_Types	_93,734	_93,734	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{369,454k (± 0.04%)}	_{369,508k (± 0.04%)}	_~	_369,383k	_369,764k	_{p=0.575 n=6}
_{Parse Time}	_{2.75s (± 0.95%)}	_{2.76s (± 1.84%)}	_~	_2.70s	_2.84s	_{p=1.000 n=6}
_{Bind Time}	_{1.58s (± 0.62%)}	_{1.58s (± 0.69%)}	_~	_1.57s	_1.60s	_{p=0.865 n=6}
_{Check Time}	_{15.42s (± 0.44%)}	_{15.40s (± 0.32%)}	_~	_15.32s	_15.45s	_{p=0.747 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{19.75s (± 0.36%)}	_{19.74s (± 0.44%)}	_~	_19.61s	_19.84s	_{p=1.000 n=6}
_{vscode - node (v18.15.0, x64)}
_Errors	₀	₁₃₉	_~	_~	_~	_{p=1.000 n=0+6}
_Symbols	₀	_2,846,102	_~	_~	_~	_{p=1.000 n=0+6}
_Types	₀	_973,724	_~	_~	_~	_{p=1.000 n=0+6}
_{Memory used}	_0k	_{3,038,830k (± 0.00%)}	_~	_3,038,741k	_3,038,922k	_{p=1.000 n=0+6}
_{Parse Time}	_0s	_{16.71s (± 0.45%)}	_~	_16.65s	_16.86s	_{p=1.000 n=0+6}
_{Bind Time}	_0s	_{5.10s (± 0.57%)}	_~	_5.06s	_5.14s	_{p=1.000 n=0+6}
_{Check Time}	_0s	_{90.86s (± 1.91%)}	_~	_89.87s	_94.39s	_{p=1.000 n=0+6}
_{Emit Time}	_0s	_{28.41s (± 6.54%)}	_~	_24.62s	_29.26s	_{p=1.000 n=0+6}
_{Total Time}	_0s	_{141.08s (± 0.16%)}	_~	_140.74s	_141.41s	_{p=1.000 n=0+6}
_{webpack - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_267,116	_267,116	_~	_~	_~	_{p=1.000 n=6}
_Types	_108,756	_108,756	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{411,596k (± 0.01%)}	_{411,638k (± 0.03%)}	_~	_411,474k	_411,812k	_{p=0.575 n=6}
_{Parse Time}	_{4.70s (± 0.54%)}	_{4.70s (± 0.51%)}	_~	_4.67s	_4.74s	_{p=0.808 n=6}
_{Bind Time}	_{2.08s (± 0.95%)}	_{2.08s (± 0.88%)}	_~	_2.06s	_2.11s	_{p=0.739 n=6}
_{Check Time}	_{20.75s (± 0.51%)}	_{20.86s (± 0.39%)}	_~	_20.75s	_20.95s	_{p=0.093 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{27.54s (± 0.38%)}	_{27.64s (± 0.31%)}	_~	_27.52s	_27.73s	_{p=0.127 n=6}
_{xstate-main - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_523,765	_523,765	_~	_~	_~	_{p=1.000 n=6}
_Types	_178,055	_178,055	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{461,898k (± 0.10%)}	_{462,146k (± 0.02%)}	_~	_462,035k	_462,309k	_{p=0.810 n=6}
_{Parse Time}	_{2.64s (± 0.39%)}	_{2.63s (± 0.62%)}	_~	_2.61s	_2.65s	_{p=0.869 n=6}
_{Bind Time}	_{0.99s (± 0.52%)}	_0.98s	_{-0.01s (- 0.68%)}	_~	_~	_{p=0.025 n=6}
_{Check Time}	_{15.18s (± 0.36%)}	_{15.24s (± 0.43%)}	_~	_15.14s	_15.33s	_{p=0.228 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{18.81s (± 0.30%)}	_{18.85s (± 0.39%)}	_~	_18.74s	_18.94s	_{p=0.261 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Compiler-Unions - node (v18.15.0, x64)
angular-1 - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-build-src-public-api - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
ts-pre-modules - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate-main - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

typescript-bot · 2024-06-19T20:28:08Z

@jakebailey Here are the results of running the top 400 repos with tsc comparing main and refs/pull/58935/merge:

Everything looks good!

jakebailey · 2024-06-19T21:31:44Z

Going to merge this to unblock benchmarking (per DM); I have a change locally that would also fix the original crash the PR solved, but I think there's more going on here.

Revert "Fix incorrect condition of noLib (microsoft#58867)"

0d99e31

This reverts commit 4239025.

typescript-bot assigned jakebailey Jun 19, 2024

typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Jun 19, 2024

jakebailey marked this pull request as ready for review June 19, 2024 21:30

jakebailey changed the title ~~Revert "Fix incorrect condition of noLib (#58867)"~~ Revert "Fix incorrect condition of noLib" (PR 58867) Jun 19, 2024

jakebailey merged commit aa249c0 into microsoft:main Jun 19, 2024
28 checks passed

jakebailey deleted the revert-58867 branch June 19, 2024 21:31

jakebailey mentioned this pull request Jun 19, 2024

Fix incorrect condition of noLib #58867

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Revert "Fix incorrect condition of noLib" (PR 58867) #58935

Revert "Fix incorrect condition of noLib" (PR 58867) #58935

jakebailey commented Jun 19, 2024 •

edited

Loading

jakebailey commented Jun 19, 2024

typescript-bot commented Jun 19, 2024 •

edited

Loading

typescript-bot commented Jun 19, 2024

typescript-bot commented Jun 19, 2024

typescript-bot commented Jun 19, 2024

tsc

typescript-bot commented Jun 19, 2024

jakebailey commented Jun 19, 2024

Revert "Fix incorrect condition of noLib" (PR 58867) #58935

Revert "Fix incorrect condition of noLib" (PR 58867) #58935

Conversation

jakebailey commented Jun 19, 2024 • edited Loading

jakebailey commented Jun 19, 2024

typescript-bot commented Jun 19, 2024 • edited Loading

typescript-bot commented Jun 19, 2024

typescript-bot commented Jun 19, 2024

typescript-bot commented Jun 19, 2024

tsc

typescript-bot commented Jun 19, 2024

jakebailey commented Jun 19, 2024

jakebailey commented Jun 19, 2024 •

edited

Loading

typescript-bot commented Jun 19, 2024 •

edited

Loading