fix(58801): "Move to file" on global code unnecessarily imports/exports, generates invalid code

[a-tarasyuk]

Fixes #58801
Fixes #58806

[andrewbranch]

This looks right, though it seems like it doesn’t explain the export export export export export export function bug 😄 Was there any clue about why that happened as you were debugging?

[a-tarasyuk]

@andrewbranch The moveToFile refactoring adds the same symbol to each declaration...

targetFileImportsFromOldFile.set(symbol, isValidTypeOnlyUseSite);

TypeScript/src/services/refactors/moveToFile.ts

Lines 901 to 912 in d8086f1

	for (const decl of symbol.declarations) {
	if (isInImport(decl)) {
	const prevIsTypeOnly = oldImportsNeededByTargetFile.get(symbol);
	oldImportsNeededByTargetFile.set(symbol, [
	prevIsTypeOnly === undefined ? isValidTypeOnlyUseSite : prevIsTypeOnly && isValidTypeOnlyUseSite,
	tryCast(decl, (d): d is codefix.ImportOrRequireAliasDeclaration => isImportSpecifier(d) || isImportClause(d) || isNamespaceImport(d) || isImportEqualsDeclaration(d) || isBindingElement(d) || isVariableDeclaration(d)),
	]);
	}
	else if (isTopLevelDeclaration(decl) && sourceFileOfTopLevelDeclaration(decl) === oldFile && !movedSymbols.has(symbol)) {
	targetFileImportsFromOldFile.set(symbol, isValidTypeOnlyUseSite);
	}
	}

[a-tarasyuk]

It looks like these changes fix the crash mentioned in #58806., the moveToNewFile_global3.ts test covers this case.

[andrewbranch]

Good to merge as soon as @navya9singh signs off!

[DanielRosenwasser]

I think I'm good with this, and I'd like to get it in for 5.5.2.

[DanielRosenwasser]

@typescript-bot cherry-pick this to release-5.5 and LKG

[typescript-bot]

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
cherry-pick this to release-5.5 and LKG	✅ Started	✅ Results

[typescript-bot]

Hey, @DanielRosenwasser! I've created #58923 for you.