Treat the input file name from referenced project as "ts" rather than file extension it is when determining eliding file for program construction #58308
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… file output file but input file Fixes #57652
typescript-bot
added
Author: Team
For Uncommitted Bug
sheetalkamat
changed the title
jakebailey
reviewed
Apr 24, 2024
| const isFromNodeModulesSearch = resolution.isExternalLibraryImport; | ||
| const isJsFile = !resolutionExtensionIsTSOrJson(resolution.extension); | ||
| // If this is js file source of project reference, dont treat it as js file but as d.ts | ||
| const isJsFile = !resolutionExtensionIsTSOrJson(resolution.extension) && !getProjectReferenceRedirectProject(resolution.resolvedFileName); |
There was a problem hiding this comment.
I feel like I don't quite understand how this works; "is JS" seems like it should just be "has the JS extension", but this would say that if it came from a referenced project, we don't treat it as such? So, won't we misinterpret later checks regarding node module checks?
Is it the case that an equivalent fix would just be calling getProjectReferenceRedirectProject below in the shouldAddFile checks?
There was a problem hiding this comment.
for all purposes we will be adding ".d.ts" file so we are treating it as such. That happens in findSourceFile where we map the "original file name" to output "d.ts" file name
jakebailey
approved these changes
Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During
tsc -bthe resolutions are shared across projects if the setting match. This means that if you resolved your own package name before building the project, you will get the "input" file as the resolution. And when we go to project that references this package and config, the input file will be used as resolution. This normally works out because we have rule to redirect to d.ts file and report error. But the issue is that if the input file is js file, it has rules for eliding imports. So if the file is input file name from referenced project, treat it as d.ts file for purpose of deciding eliding of imports and whether to include file or not.Fixes #57652