Ensure that we are checking if correct file with resolved path is present in the new program when removing the existing packageJson watching #57988
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sent in the new program when removing the existing packageJson watching Fixes #57986
typescript-bot
added
Author: Team
For Uncommitted Bug
jakebailey
approved these changes
Mar 28, 2024
Member
jakebailey
left a comment
jakebailey
left a comment
There was a problem hiding this comment.
I was hoping the first commit would add a baseline for the second to have a diff on, but the first commit shows that there's a debug failure, darn
Member
Author
|
Yeah i forgot to generate baseline disabling incremental verifier. Which is what i had done in another PR. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The file's resolved path might not be same if "referenced tsconfig" gets deleted. So we need to ensure that file we get from program has same resolvedPath as what we are looking for, if not remove the existing watched locations
Fixes #57986