preserve declarations if @internal is mentioned in unrelated comment #57960

Zzzen · 2024-03-27T16:55:55Z

typescript-bot · 2024-03-27T16:56:11Z

Looks like you're introducing a change to the public API surface area. If this includes breaking changes, please document them on our wiki's API Breaking Changes page.

Also, please make sure @DanielRosenwasser and @RyanCavanaugh are aware of the changes, just as a heads up.

src/compiler/utilitiesPublic.ts

Co-authored-by: Jake Bailey <[email protected]>

jakebailey · 2024-06-14T23:28:49Z

Merged main for you.

As far as I'm concerned, this PR is correct; I tested dtsBundler with it and it still correctly strips internal declarations via isInternalDeclaration.

But I know we're pretty iffy on whether or not @internal is even supported or not. Only recently did I make the function to check the tag public, and this PR formalizes it into our API.

I'm personally still for it, regardless, but I'll bring this one up in a design meeting just to double check.

src/compiler/parser.ts

jakebailey

I have no idea how it isn't breaking the tests, but this PR will need to modify scanner.ts to update jsDocSeeOrLink to also treat @internal as a JSDoc comment that needs to be parsed in TS files and an update to the docs for JSDocParsingMode to say that @internal is also parsed. Along with testing in jsDocParsing.ts.

Probably need to make ParseForTypeErrors the default in the compiler tests... Really thought I did that already.

jakebailey

Oops, meant to mark as needing changes.

jakebailey · 2024-06-19T00:29:13Z

Close/reopening to rerun CI and show the failure.

jakebailey · 2024-06-27T04:51:21Z

Took the liberty to apply the described change.

jakebailey · 2024-06-27T16:52:42Z

Just checking:

@typescript-bot test it

typescript-bot · 2024-06-27T16:52:45Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`test top400`	✅ Started	✅ Results
`user test this`	✅ Started	👀 Results
`run dt`	✅ Started	👀 Results
`perf test this faster`	✅ Started	👀 Results

typescript-bot · 2024-06-27T17:13:05Z

Hey @jakebailey, the results of running the DT tests are ready.

There were interesting changes:

Branch only errors:

Package: react
Error:

TypeError: Cannot read properties of undefined (reading 'kind')
Occurred while linting /mnt/vss/_work/1/DefinitelyTyped/types/react/index.d.ts:7
Rule: "@definitelytyped/expect"
    at getCannotFindNameDiagnosticForName (/mnt/vss/_work/1/s/built/local/typescript.js:72148:25)
    at resolveEntityName (/mnt/vss/_work/1/s/built/local/typescript.js:52801:119)
    at resolveJSDocMemberName (/mnt/vss/_work/1/s/built/local/typescript.js:89561:20)
    at checkJSDocLinkLikeTag (/mnt/vss/_work/1/s/built/local/typescript.js:85107:7)
    at checkSourceElementWorker (/mnt/vss/_work/1/s/built/local/typescript.js:88784:16)
    at checkSourceElement (/mnt/vss/_work/1/s/built/local/typescript.js:88679:7)
    at /mnt/vss/_work/1/s/built/local/typescript.js:88888:11
    at forEach (/mnt/vss/_work/1/s/built/local/typescript.js:2402:22)
    at checkJSDocCommentWorker (/mnt/vss/_work/1/s/built/local/typescript.js:88886:7)
    at /mnt/vss/_work/1/s/built/local/typescript.js:88691:11

Package: porty
Error:

TypeError: Cannot read properties of undefined (reading 'kind')
Occurred while linting /mnt/vss/_work/1/DefinitelyTyped/types/porty/index.d.ts:1
Rule: "@definitelytyped/expect"
    at getCannotFindNameDiagnosticForName (/mnt/vss/_work/1/s/built/local/typescript.js:72148:25)
    at resolveEntityName (/mnt/vss/_work/1/s/built/local/typescript.js:52801:119)
    at resolveJSDocMemberName (/mnt/vss/_work/1/s/built/local/typescript.js:89561:20)
    at checkJSDocLinkLikeTag (/mnt/vss/_work/1/s/built/local/typescript.js:85107:7)
    at checkSourceElementWorker (/mnt/vss/_work/1/s/built/local/typescript.js:88784:16)
    at checkSourceElement (/mnt/vss/_work/1/s/built/local/typescript.js:88679:7)
    at /mnt/vss/_work/1/s/built/local/typescript.js:88888:11
    at forEach (/mnt/vss/_work/1/s/built/local/typescript.js:2402:22)
    at checkJSDocCommentWorker (/mnt/vss/_work/1/s/built/local/typescript.js:88886:7)
    at /mnt/vss/_work/1/s/built/local/typescript.js:88691:11

You can check the log here.

jakebailey

Those new DT errors are interesting; seems like a bug in the PR somewhere.

typescript-bot · 2024-06-27T17:18:07Z

@jakebailey Here are the results of running the user tests with tsc comparing main and refs/pull/57960/merge:

Something interesting changed - please have a look.

Details

azure-sdk

/mnt/ts_downloads/_/m/azure-sdk/build.sh

[MISSING] error TS2322: Type 'string' is not assignable to type 'never'.
- /mnt/ts_downloads/_/m/azure-sdk/test/narrowedTypes.ts(59,9)
- /mnt/ts_downloads/_/m/azure-sdk/test/narrowedTypes.ts(213,9)
- /mnt/ts_downloads/_/m/azure-sdk/test/narrowedTypes.ts(254,11)

typescript-bot · 2024-06-27T17:29:34Z

@jakebailey
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-Unions - node (v18.15.0, x64)}
_Errors	₃₀	₃₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_62,153	_62,153	_~	_~	_~	_{p=1.000 n=6}
_Types	_50,242	_50,243	_{+1 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{193,456k (± 0.91%)}	_{194,017k (± 0.01%)}	_~	_193,992k	_194,044k	_{p=0.378 n=6}
_{Parse Time}	_{1.32s (± 0.57%)}	_{1.28s (± 0.85%)}	_{-0.04s (- 2.91%)}	_1.26s	_1.29s	_{p=0.004 n=6}
_{Bind Time}	_0.71s	_0.73s	_{+0.02s (+ 2.82%)}	_~	_~	_{p=0.001 n=6}
_{Check Time}	_{9.42s (± 0.21%)}	_{9.45s (± 0.45%)}	_~	_9.39s	_9.50s	_{p=0.296 n=6}
_{Emit Time}	_{2.76s (± 0.44%)}	_{2.96s (± 0.72%)}	_{🔻+0.20s (+ 7.38%)}	_2.93s	_2.98s	_{p=0.004 n=6}
_{Total Time}	_{14.21s (± 0.12%)}	_{14.41s (± 0.35%)}	_{+0.21s (+ 1.45%)}	_14.32s	_14.46s	_{p=0.005 n=6}
_{angular-1 - node (v18.15.0, x64)}
_Errors	₅	₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_944,114	_944,114	_~	_~	_~	_{p=1.000 n=6}
_Types	_407,050	_407,050	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{1,218,315k (± 0.00%)}	_{1,218,668k (± 0.00%)}	_{+353k (+ 0.03%)}	_1,218,623k	_1,218,745k	_{p=0.005 n=6}
_{Parse Time}	_{6.68s (± 0.43%)}	_{6.72s (± 0.51%)}	_~	_6.67s	_6.77s	_{p=0.109 n=6}
_{Bind Time}	_{1.86s (± 0.65%)}	_{1.88s (± 0.43%)}	_{+0.02s (+ 1.07%)}	_1.87s	_1.89s	_{p=0.017 n=6}
_{Check Time}	_{30.61s (± 0.44%)}	_{30.62s (± 0.42%)}	_~	_30.43s	_30.79s	_{p=1.000 n=6}
_{Emit Time}	_{13.57s (± 0.29%)}	_{13.55s (± 0.55%)}	_~	_13.44s	_13.67s	_{p=0.568 n=6}
_{Total Time}	_{52.72s (± 0.27%)}	_{52.77s (± 0.28%)}	_~	_52.58s	_52.93s	_{p=0.575 n=6}
_{mui-docs - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,133,050	_2,133,050	_~	_~	_~	_{p=1.000 n=6}
_Types	_926,444	_926,444	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,115,475k (± 0.01%)}	_{2,115,640k (± 0.01%)}	_{+166k (+ 0.01%)}	_2,115,488k	_2,115,734k	_{p=0.045 n=6}
_{Parse Time}	_{6.63s (± 0.60%)}	_{6.63s (± 0.48%)}	_~	_6.57s	_6.67s	_{p=0.936 n=6}
_{Bind Time}	_{2.31s (± 1.31%)}	_{2.31s (± 1.11%)}	_~	_2.28s	_2.34s	_{p=0.934 n=6}
_{Check Time}	_{70.75s (± 0.26%)}	_{70.92s (± 0.61%)}	_~	_70.44s	_71.56s	_{p=0.689 n=6}
_{Emit Time}	_{0.13s (± 3.87%)}	_{0.14s (± 4.51%)}	_~	_0.13s	_0.15s	_{p=0.091 n=6}
_{Total Time}	_{79.83s (± 0.21%)}	_{79.99s (± 0.50%)}	_~	_79.50s	_80.55s	_{p=0.630 n=6}
_{self-build-src - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,231,640	_1,231,878	_{+238 (+ 0.02%)}	_~	_~	_{p=0.001 n=6}
_Types	_261,187	_261,206	_{+19 (+ 0.01%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,347,778k (± 0.02%)}	_{2,385,972k (± 0.04%)}	_{+38,193k (+ 1.63%)}	_2,384,749k	_2,386,783k	_{p=0.005 n=6}
_{Parse Time}	_{5.05s (± 1.08%)}	_{5.37s (± 0.66%)}	_{🔻+0.33s (+ 6.47%)}	_5.32s	_5.41s	_{p=0.005 n=6}
_{Bind Time}	_{1.92s (± 1.29%)}	_{1.95s (± 0.65%)}	_{+0.03s (+ 1.65%)}	_1.93s	_1.96s	_{p=0.024 n=6}
_{Check Time}	_{34.28s (± 0.20%)}	_{34.18s (± 0.21%)}	_~	_34.09s	_34.25s	_{p=0.093 n=6}
_{Emit Time}	_{2.72s (± 2.15%)}	_{2.73s (± 2.77%)}	_~	_2.66s	_2.85s	_{p=0.936 n=6}
_{Total Time}	_{43.96s (± 0.12%)}	_{44.24s (± 0.19%)}	_{+0.28s (+ 0.63%)}	_44.14s	_44.39s	_{p=0.005 n=6}
_{self-build-src-public-api - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,231,640	_1,231,878	_{+238 (+ 0.02%)}	_~	_~	_{p=0.001 n=6}
_Types	_261,187	_261,206	_{+19 (+ 0.01%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,423,712k (± 0.07%)}	_{2,462,611k (± 0.04%)}	_{+38,899k (+ 1.60%)}	_2,460,874k	_2,463,556k	_{p=0.005 n=6}
_{Parse Time}	_{6.25s (± 0.88%)}	_{6.59s (± 0.73%)}	_{🔻+0.33s (+ 5.33%)}	_6.54s	_6.67s	_{p=0.005 n=6}
_{Bind Time}	_{2.05s (± 0.27%)}	_{2.32s (± 1.48%)}	_{🔻+0.28s (+13.53%)}	_2.27s	_2.36s	_{p=0.005 n=6}
_{Check Time}	_{40.54s (± 0.33%)}	_{40.26s (± 0.24%)}	_{-0.28s (- 0.70%)}	_40.11s	_40.38s	_{p=0.005 n=6}
_{Emit Time}	_{3.29s (± 4.48%)}	_{3.17s (± 1.60%)}	_~	_3.13s	_3.27s	_{p=0.065 n=6}
_{Total Time}	_{52.14s (± 0.42%)}	_{52.36s (± 0.21%)}	_~	_52.26s	_52.54s	_{p=0.065 n=6}
_{self-compiler - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_258,818	_258,836	_{+18 (+ 0.01%)}	_~	_~	_{p=0.001 n=6}
_Types	_104,842	_104,853	_{+11 (+ 0.01%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{428,245k (± 0.00%)}	_{430,708k (± 0.01%)}	_{+2,463k (+ 0.58%)}	_430,665k	_430,783k	_{p=0.005 n=6}
_{Parse Time}	_{4.09s (± 0.45%)}	_{4.26s (± 0.69%)}	_{+0.16s (+ 3.99%)}	_4.22s	_4.29s	_{p=0.005 n=6}
_{Bind Time}	_{1.60s (± 1.07%)}	_{1.63s (± 0.98%)}	_{+0.03s (+ 1.87%)}	_1.62s	_1.66s	_{p=0.023 n=6}
_{Check Time}	_{22.00s (± 0.46%)}	_{21.97s (± 0.31%)}	_~	_21.88s	_22.06s	_{p=0.689 n=6}
_{Emit Time}	_{1.72s (± 1.67%)}	_{1.69s (± 1.32%)}	_~	_1.67s	_1.72s	_{p=0.138 n=6}
_{Total Time}	_{29.42s (± 0.32%)}	_{29.55s (± 0.19%)}	_{+0.13s (+ 0.46%)}	_29.49s	_29.62s	_{p=0.030 n=6}
_{ts-pre-modules - node (v18.15.0, x64)}
_Errors	₃₅	₃₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_224,565	_224,565	_~	_~	_~	_{p=1.000 n=6}
_Types	_93,734	_93,734	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{369,444k (± 0.02%)}	_{369,507k (± 0.01%)}	_~	_369,433k	_369,586k	_{p=0.173 n=6}
_{Parse Time}	_{2.77s (± 1.36%)}	_{2.71s (± 0.63%)}	_{-0.05s (- 1.99%)}	_2.68s	_2.73s	_{p=0.012 n=6}
_{Bind Time}	_{1.58s (± 0.93%)}	_{1.58s (± 0.74%)}	_~	_1.57s	_1.60s	_{p=0.933 n=6}
_{Check Time}	_{15.51s (± 0.34%)}	_{15.48s (± 0.24%)}	_~	_15.43s	_15.52s	_{p=0.257 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{19.86s (± 0.32%)}	_{19.77s (± 0.23%)}	_{-0.09s (- 0.46%)}	_19.71s	_19.81s	_{p=0.036 n=6}
_{vscode - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,878,629	_2,878,629	_~	_~	_~	_{p=1.000 n=6}
_Types	_975,177	_975,177	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{3,042,150k (± 0.00%)}	_{3,042,429k (± 0.00%)}	_{+279k (+ 0.01%)}	_3,042,394k	_3,042,459k	_{p=0.005 n=6}
_{Parse Time}	_{13.57s (± 0.44%)}	_{13.60s (± 0.35%)}	_~	_13.56s	_13.66s	_{p=0.226 n=6}
_{Bind Time}	_{4.22s (± 1.83%)}	_{4.22s (± 2.03%)}	_~	_4.16s	_4.39s	_{p=1.000 n=6}
_{Check Time}	_{73.36s (± 0.43%)}	_{73.60s (± 1.74%)}	_~	_72.72s	_76.18s	_{p=0.468 n=6}
_{Emit Time}	_{24.08s (± 0.47%)}	_{23.51s (± 4.72%)}	_{-0.57s (- 2.39%)}	_21.25s	_24.06s	_{p=0.037 n=6}
_{Total Time}	_{115.22s (± 0.29%)}	_{114.93s (± 0.28%)}	_~	_114.46s	_115.42s	_{p=0.230 n=6}
_{webpack - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_267,117	_267,117	_~	_~	_~	_{p=1.000 n=6}
_Types	_108,775	_108,775	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{411,547k (± 0.01%)}	_{411,614k (± 0.02%)}	_~	_411,539k	_411,739k	_{p=0.109 n=6}
_{Parse Time}	_{3.84s (± 0.63%)}	_{3.84s (± 0.58%)}	_~	_3.81s	_3.87s	_{p=0.871 n=6}
_{Bind Time}	_{1.70s (± 0.81%)}	_{1.69s (± 0.65%)}	_~	_1.68s	_1.71s	_{p=0.491 n=6}
_{Check Time}	_{16.76s (± 0.36%)}	_{16.75s (± 0.24%)}	_~	_16.69s	_16.80s	_{p=0.419 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{22.30s (± 0.36%)}	_{22.29s (± 0.11%)}	_~	_22.24s	_22.30s	_{p=0.361 n=6}
_{xstate-main - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_525,251	_525,251	_~	_~	_~	_{p=1.000 n=6}
_Types	_178,574	_178,574	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{462,735k (± 0.08%)}	_{462,930k (± 0.07%)}	_~	_462,418k	_463,282k	_{p=0.378 n=6}
_{Parse Time}	_{3.17s (± 0.63%)}	_{3.16s (± 1.29%)}	_~	_3.11s	_3.22s	_{p=0.628 n=6}
_{Bind Time}	_{1.16s (± 1.04%)}	_{1.17s (± 0.54%)}	_~	_1.16s	_1.18s	_{p=0.340 n=6}
_{Check Time}	_{17.94s (± 0.42%)}	_{17.90s (± 0.34%)}	_~	_17.82s	_17.97s	_{p=0.378 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{22.27s (± 0.32%)}	_{22.23s (± 0.42%)}	_~	_22.11s	_22.36s	_{p=0.466 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Compiler-Unions - node (v18.15.0, x64)
angular-1 - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-build-src-public-api - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
ts-pre-modules - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate-main - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

typescript-bot · 2024-06-27T18:44:25Z

@jakebailey Here are the results of running the top 400 repos with tsc comparing main and refs/pull/57960/merge:

Everything looks good!

Zzzen · 2024-06-28T17:41:06Z

The DT errors should have been fixed.

jakebailey · 2024-06-28T17:41:19Z

@typescript-bot test it

typescript-bot · 2024-06-28T17:41:22Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`test top400`	✅ Started
`user test this`	✅ Started
`run dt`	✅ Started
`perf test this faster`	✅ Started

jakebailey · 2024-06-28T18:28:05Z

@typescript-bot test it

typescript-bot · 2024-06-28T18:28:09Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`test top400`	✅ Started	✅ Results
`user test this`	✅ Started	✅ Results
`run dt`	✅ Started	✅ Results
`perf test this faster`	✅ Started	👀 Results

typescript-bot · 2024-06-28T18:49:29Z

Hey @jakebailey, the results of running the DT tests are ready.

Everything looks the same!

You can check the log here.

typescript-bot · 2024-06-28T18:58:29Z

@jakebailey Here are the results of running the user tests with tsc comparing main and refs/pull/57960/merge:

Everything looks good!

typescript-bot · 2024-06-28T19:06:02Z

@jakebailey
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-Unions - node (v18.15.0, x64)}
_Errors	₃₀	₃₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_62,153	_62,153	_~	_~	_~	_{p=1.000 n=6}
_Types	_50,242	_50,243	_{+1 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{192,920k (± 0.73%)}	_{194,749k (± 0.75%)}	_{+1,829k (+ 0.95%)}	_193,998k	_197,702k	_{p=0.045 n=6}
_{Parse Time}	_{1.31s (± 0.84%)}	_{1.29s (± 0.63%)}	_{-0.02s (- 1.78%)}	_1.28s	_1.30s	_{p=0.011 n=6}
_{Bind Time}	_0.71s	_{0.73s (± 0.56%)}	_{+0.02s (+ 2.58%)}	_0.72s	_0.73s	_{p=0.002 n=6}
_{Check Time}	_{9.44s (± 0.32%)}	_{9.44s (± 0.32%)}	_~	_9.40s	_9.47s	_{p=1.000 n=6}
_{Emit Time}	_{2.74s (± 0.38%)}	_{2.96s (± 0.56%)}	_{🔻+0.22s (+ 8.04%)}	_2.93s	_2.97s	_{p=0.005 n=6}
_{Total Time}	_{14.19s (± 0.25%)}	_{14.41s (± 0.13%)}	_{+0.21s (+ 1.51%)}	_14.39s	_14.44s	_{p=0.005 n=6}
_{angular-1 - node (v18.15.0, x64)}
_Errors	₅	₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_944,114	_944,114	_~	_~	_~	_{p=1.000 n=6}
_Types	_407,050	_407,050	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{1,218,352k (± 0.00%)}	_{1,218,687k (± 0.00%)}	_{+336k (+ 0.03%)}	_1,218,631k	_1,218,732k	_{p=0.005 n=6}
_{Parse Time}	_{7.97s (± 0.65%)}	_{8.02s (± 0.45%)}	_{+0.05s (+ 0.63%)}	_7.98s	_8.08s	_{p=0.045 n=6}
_{Bind Time}	_{2.22s (± 0.53%)}	_{2.25s (± 0.33%)}	_{+0.03s (+ 1.35%)}	_2.24s	_2.26s	_{p=0.007 n=6}
_{Check Time}	_{35.80s (± 0.26%)}	_{35.88s (± 0.28%)}	_~	_35.75s	_36.03s	_{p=0.225 n=6}
_{Emit Time}	_{16.14s (± 0.32%)}	_{16.21s (± 0.45%)}	_~	_16.08s	_16.29s	_{p=0.077 n=6}
_{Total Time}	_{62.12s (± 0.16%)}	_{62.35s (± 0.17%)}	_{+0.22s (+ 0.36%)}	_62.20s	_62.47s	_{p=0.016 n=6}
_{mui-docs - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,133,039	_2,133,039	_~	_~	_~	_{p=1.000 n=6}
_Types	_926,444	_926,444	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,115,329k (± 0.00%)}	_{2,115,454k (± 0.00%)}	_{+126k (+ 0.01%)}	_2,115,385k	_2,115,525k	_{p=0.005 n=6}
_{Parse Time}	_{7.92s (± 0.26%)}	_{7.91s (± 0.53%)}	_~	_7.86s	_7.97s	_{p=0.466 n=6}
_{Bind Time}	_{2.76s (± 0.42%)}	_{2.76s (± 0.32%)}	_~	_2.75s	_2.77s	_{p=0.933 n=6}
_{Check Time}	_{83.41s (± 0.55%)}	_{83.31s (± 0.68%)}	_~	_82.64s	_83.98s	_{p=0.810 n=6}
_{Emit Time}	_{0.16s (± 4.75%)}	_{0.15s (± 5.39%)}	_~	_0.15s	_0.17s	_{p=0.432 n=6}
_{Total Time}	_{94.25s (± 0.49%)}	_{94.13s (± 0.60%)}	_~	_93.44s	_94.77s	_{p=0.748 n=6}
_{self-build-src - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,224,331	_1,224,580	_{+249 (+ 0.02%)}	_~	_~	_{p=0.001 n=6}
_Types	_261,007	_261,032	_{+25 (+ 0.01%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,337,769k (± 0.05%)}	_{2,374,737k (± 0.02%)}	_{+36,968k (+ 1.58%)}	_2,374,000k	_2,375,421k	_{p=0.005 n=6}
_{Parse Time}	_{5.06s (± 0.90%)}	_{5.35s (± 0.62%)}	_{🔻+0.28s (+ 5.56%)}	_5.30s	_5.40s	_{p=0.005 n=6}
_{Bind Time}	_{1.90s (± 1.13%)}	_{1.94s (± 1.01%)}	_{+0.03s (+ 1.75%)}	_1.91s	_1.97s	_{p=0.023 n=6}
_{Check Time}	_{34.16s (± 0.66%)}	_{34.18s (± 0.20%)}	_~	_34.09s	_34.25s	_{p=0.230 n=6}
_{Emit Time}	_{2.73s (± 3.11%)}	_{2.72s (± 2.83%)}	_~	_2.65s	_2.83s	_{p=0.810 n=6}
_{Total Time}	_{43.88s (± 0.65%)}	_{44.21s (± 0.31%)}	_~	_44.09s	_44.39s	_{p=0.066 n=6}
_{self-build-src-public-api - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,224,331	_1,224,580	_{+249 (+ 0.02%)}	_~	_~	_{p=0.001 n=6}
_Types	_261,007	_261,032	_{+25 (+ 0.01%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,412,649k (± 0.05%)}	_{2,450,417k (± 0.04%)}	_{+37,768k (+ 1.57%)}	_2,449,039k	_2,451,641k	_{p=0.005 n=6}
_{Parse Time}	_{6.28s (± 0.88%)}	_{6.60s (± 1.02%)}	_{🔻+0.32s (+ 5.15%)}	_6.52s	_6.68s	_{p=0.005 n=6}
_{Bind Time}	_{2.02s (± 0.86%)}	_{2.21s (± 6.02%)}	_{🔻+0.19s (+ 9.31%)}	_2.04s	_2.31s	_{p=0.007 n=6}
_{Check Time}	_{40.74s (± 0.17%)}	_{40.46s (± 0.40%)}	_{-0.28s (- 0.69%)}	_40.28s	_40.68s	_{p=0.008 n=6}
_{Emit Time}	_{3.28s (± 2.53%)}	_{3.24s (± 1.60%)}	_~	_3.16s	_3.29s	_{p=0.471 n=6}
_{Total Time}	_{52.34s (± 0.32%)}	_{52.50s (± 0.14%)}	_{+0.17s (+ 0.32%)}	_52.41s	_52.62s	_{p=0.045 n=6}
_{self-compiler - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_258,166	_258,195	_{+29 (+ 0.01%)}	_~	_~	_{p=0.001 n=6}
_Types	_104,689	_104,706	_{+17 (+ 0.02%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{427,333k (± 0.00%)}	_{429,739k (± 0.01%)}	_{+2,406k (+ 0.56%)}	_429,670k	_429,782k	_{p=0.005 n=6}
_{Parse Time}	_{4.06s (± 0.21%)}	_{4.28s (± 0.45%)}	_{🔻+0.21s (+ 5.25%)}	_4.25s	_4.30s	_{p=0.004 n=6}
_{Bind Time}	_{1.63s (± 1.38%)}	_{1.64s (± 0.71%)}	_~	_1.63s	_1.66s	_{p=0.324 n=6}
_{Check Time}	_{21.96s (± 0.36%)}	_{21.91s (± 0.14%)}	_~	_21.86s	_21.93s	_{p=0.070 n=6}
_{Emit Time}	_{1.75s (± 1.20%)}	_{1.75s (± 1.19%)}	_~	_1.72s	_1.78s	_{p=0.742 n=6}
_{Total Time}	_{29.40s (± 0.33%)}	_{29.57s (± 0.06%)}	_{+0.17s (+ 0.59%)}	_29.55s	_29.60s	_{p=0.045 n=6}
_{ts-pre-modules - node (v18.15.0, x64)}
_Errors	₃₅	₃₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_224,565	_224,565	_~	_~	_~	_{p=1.000 n=6}
_Types	_93,734	_93,734	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{369,551k (± 0.02%)}	_{369,607k (± 0.02%)}	_~	_369,518k	_369,668k	_{p=0.093 n=6}
_{Parse Time}	_{2.30s (± 0.81%)}	_{2.25s (± 0.46%)}	_{-0.04s (- 1.81%)}	_2.24s	_2.27s	_{p=0.006 n=6}
_{Bind Time}	_{1.33s (± 0.88%)}	_{1.30s (± 0.64%)}	_{-0.02s (- 1.76%)}	_1.30s	_1.32s	_{p=0.008 n=6}
_{Check Time}	_{13.15s (± 0.30%)}	_{13.16s (± 0.37%)}	_~	_13.08s	_13.21s	_{p=0.629 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{16.78s (± 0.17%)}	_{16.72s (± 0.28%)}	_~	_16.66s	_16.79s	_{p=0.065 n=6}
_{vscode - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,878,940	_2,878,940	_~	_~	_~	_{p=1.000 n=6}
_Types	_975,074	_975,074	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{3,041,723k (± 0.00%)}	_{3,042,020k (± 0.00%)}	_{+297k (+ 0.01%)}	_3,041,878k	_3,042,123k	_{p=0.005 n=6}
_{Parse Time}	_{11.40s (± 0.26%)}	_{11.49s (± 0.39%)}	_{+0.10s (+ 0.85%)}	_11.45s	_11.55s	_{p=0.005 n=6}
_{Bind Time}	_{3.64s (± 2.46%)}	_{3.57s (± 2.28%)}	_~	_3.51s	_3.69s	_{p=0.189 n=6}
_{Check Time}	_{63.80s (± 1.27%)}	_{63.34s (± 0.36%)}	_~	_63.04s	_63.74s	_{p=0.470 n=6}
_{Emit Time}	_{20.21s (± 3.48%)}	_{20.65s (± 0.78%)}	_~	_20.35s	_20.79s	_{p=0.173 n=6}
_{Total Time}	_{99.04s (± 0.13%)}	_{99.06s (± 0.36%)}	_~	_98.80s	_99.76s	_{p=0.378 n=6}
_{webpack - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_267,117	_267,117	_~	_~	_~	_{p=1.000 n=6}
_Types	_108,775	_108,775	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{411,592k (± 0.01%)}	_{411,639k (± 0.03%)}	_~	_411,505k	_411,815k	_{p=1.000 n=6}
_{Parse Time}	_{3.81s (± 0.52%)}	_{3.82s (± 0.77%)}	_~	_3.77s	_3.85s	_{p=0.418 n=6}
_{Bind Time}	_{1.68s (± 0.62%)}	_{1.69s (± 0.48%)}	_~	_1.68s	_1.70s	_{p=0.865 n=6}
_{Check Time}	_{16.70s (± 0.41%)}	_{16.75s (± 0.36%)}	_~	_16.68s	_16.85s	_{p=0.419 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{22.20s (± 0.35%)}	_{22.26s (± 0.30%)}	_~	_22.19s	_22.37s	_{p=0.173 n=6}
_{xstate-main - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_525,251	_525,251	_~	_~	_~	_{p=1.000 n=6}
_Types	_178,574	_178,574	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{462,924k (± 0.07%)}	_{462,818k (± 0.07%)}	_~	_462,389k	_463,191k	_{p=0.575 n=6}
_{Parse Time}	_{3.19s (± 0.59%)}	_{3.19s (± 0.47%)}	_~	_3.16s	_3.20s	_{p=0.935 n=6}
_{Bind Time}	_{1.17s (± 0.44%)}	_{1.17s (± 0.94%)}	_~	_1.16s	_1.19s	_{p=0.324 n=6}
_{Check Time}	_{17.95s (± 0.35%)}	_{17.93s (± 0.24%)}	_~	_17.87s	_17.98s	_{p=0.748 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{22.31s (± 0.30%)}	_{22.29s (± 0.22%)}	_~	_22.22s	_22.35s	_{p=0.809 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Compiler-Unions - node (v18.15.0, x64)
angular-1 - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-build-src-public-api - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
ts-pre-modules - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate-main - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

jakebailey · 2024-06-28T19:26:13Z

Perf is unfortunately still greatly affected and needs to be looked into.

typescript-bot · 2024-06-28T20:23:17Z

@jakebailey Here are the results of running the top 400 repos with tsc comparing main and refs/pull/57960/merge:

Everything looks good!

Zzzen · 2024-06-29T14:25:57Z

Perf problem is likely caused by the regex change.

const jsDocNeededInTypeScriptFile = /@(?:see|link|internal)/i; is 6% slower than the original one.

perf.link

jakebailey · 2024-06-29T14:39:16Z

Funnily I clicked that link and reran it, and it told me that the new one was 6% faster; I think this particular result is just noisy. Given the benchmark is consistent with so few samples, a profile may provide more insight (which I plan to test).

Zzzen · 2024-06-29T14:45:58Z

LOL. After I executed it many times, I also found that the output result is somewhat random.

sandersn · 2024-07-09T21:39:31Z

Do the random perf results mean this is safe to merge? I'd guess not, unless it's a problem with the perf infrastructure.

jakebailey · 2024-07-09T21:41:21Z

No, there's nothing wrong with the perf infra, there really is a slowdown here that needs to be profiled.

jakebailey · 2024-07-09T22:29:44Z

@typescript-bot perf test this faster

I can't seem to get the slowdown locally...

typescript-bot · 2024-07-09T22:29:47Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`perf test this faster`	✅ Started	👀 Results

typescript-bot · 2024-07-09T23:06:02Z

@jakebailey
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-Unions - node (v18.15.0, x64)}
_Errors	₃₀	₃₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_62,153	_62,153	_~	_~	_~	_{p=1.000 n=6}
_Types	_50,242	_50,243	_{+1 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{193,869k (± 1.04%)}	_{194,705k (± 0.79%)}	_~	_193,996k	_197,837k	_{p=0.689 n=6}
_{Parse Time}	_{1.96s (± 0.56%)}	_{1.93s (± 1.02%)}	_{-0.03s (- 1.28%)}	_1.92s	_1.96s	_{p=0.036 n=6}
_{Bind Time}	_{1.06s (± 0.84%)}	_{1.08s (± 0.70%)}	_{+0.02s (+ 1.73%)}	_1.07s	_1.09s	_{p=0.011 n=6}
_{Check Time}	_{13.85s (± 0.50%)}	_{13.87s (± 0.30%)}	_~	_13.83s	_13.94s	_{p=0.419 n=6}
_{Emit Time}	_{4.07s (± 3.39%)}	_{4.36s (± 1.42%)}	_{🔻+0.30s (+ 7.29%)}	_4.30s	_4.47s	_{p=0.016 n=6}
_{Total Time}	_{20.94s (± 0.74%)}	_{21.25s (± 0.34%)}	_{+0.31s (+ 1.49%)}	_21.17s	_21.34s	_{p=0.020 n=6}
_{angular-1 - node (v18.15.0, x64)}
_Errors	₅	₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_944,114	_944,114	_~	_~	_~	_{p=1.000 n=6}
_Types	_407,050	_407,050	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{1,218,365k (± 0.00%)}	_{1,218,704k (± 0.00%)}	_{+338k (+ 0.03%)}	_1,218,639k	_1,218,746k	_{p=0.005 n=6}
_{Parse Time}	_{7.97s (± 0.39%)}	_{8.00s (± 0.39%)}	_~	_7.95s	_8.03s	_{p=0.126 n=6}
_{Bind Time}	_{2.21s (± 0.25%)}	_{2.22s (± 0.66%)}	_~	_2.20s	_2.24s	_{p=0.091 n=6}
_{Check Time}	_{35.66s (± 0.16%)}	_{35.70s (± 0.18%)}	_~	_35.60s	_35.79s	_{p=0.378 n=6}
_{Emit Time}	_{16.08s (± 0.96%)}	_{16.13s (± 0.27%)}	_~	_16.06s	_16.18s	_{p=0.128 n=6}
_{Total Time}	_{61.92s (± 0.24%)}	_{62.04s (± 0.13%)}	_~	_61.94s	_62.13s	_{p=0.066 n=6}
_{mui-docs - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,130,342	_2,130,342	_~	_~	_~	_{p=1.000 n=6}
_Types	_927,684	_927,684	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,107,288k (± 0.01%)}	_{2,107,326k (± 0.01%)}	_~	_2,107,056k	_2,107,557k	_{p=0.689 n=6}
_{Parse Time}	_{9.71s (± 0.37%)}	_{9.64s (± 0.85%)}	_~	_9.49s	_9.72s	_{p=0.078 n=6}
_{Bind Time}	_{3.41s (± 0.66%)}	_{3.38s (± 0.77%)}	_~	_3.34s	_3.41s	_{p=0.145 n=6}
_{Check Time}	_{101.20s (± 1.39%)}	_{102.15s (± 1.51%)}	_~	_99.07s	_103.10s	_{p=0.298 n=6}
_{Emit Time}	_{0.19s (± 4.22%)}	_{0.40s (±126.52%)}	_~	_0.19s	_1.44s	_{p=0.340 n=6}
_{Total Time}	_{114.50s (± 1.22%)}	_{115.57s (± 0.91%)}	_~	_113.53s	_116.43s	_{p=0.173 n=6}
_{self-build-src - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,225,784	_1,226,033	_{+249 (+ 0.02%)}	_~	_~	_{p=0.001 n=6}
_Types	_261,518	_261,543	_{+25 (+ 0.01%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,341,759k (± 0.03%)}	_{2,378,991k (± 0.04%)}	_{+37,233k (+ 1.59%)}	_2,377,759k	_2,380,394k	_{p=0.005 n=6}
_{Parse Time}	_{6.03s (± 0.72%)}	_{6.39s (± 0.48%)}	_{🔻+0.36s (+ 5.91%)}	_6.33s	_6.42s	_{p=0.005 n=6}
_{Bind Time}	_{2.26s (± 0.87%)}	_{2.29s (± 0.22%)}	_{+0.03s (+ 1.33%)}	_2.29s	_2.30s	_{p=0.012 n=6}
_{Check Time}	_{40.27s (± 0.73%)}	_{40.30s (± 0.67%)}	_~	_39.88s	_40.70s	_{p=0.471 n=6}
_{Emit Time}	_{3.08s (± 2.37%)}	_{3.25s (± 5.44%)}	_~	_3.04s	_3.48s	_{p=0.054 n=6}
_{Total Time}	_{51.66s (± 0.71%)}	_{52.24s (± 0.47%)}	_{+0.59s (+ 1.14%)}	_51.97s	_52.58s	_{p=0.031 n=6}
_{self-build-src-public-api - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,225,784	_1,226,033	_{+249 (+ 0.02%)}	_~	_~	_{p=0.001 n=6}
_Types	_261,518	_261,543	_{+25 (+ 0.01%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,414,879k (± 0.04%)}	_{2,451,359k (± 0.07%)}	_{+36,480k (+ 1.51%)}	_2,449,510k	_2,453,559k	_{p=0.005 n=6}
_{Parse Time}	_{6.28s (± 1.01%)}	_{6.61s (± 0.87%)}	_{🔻+0.32s (+ 5.14%)}	_6.54s	_6.69s	_{p=0.005 n=6}
_{Bind Time}	_{2.02s (± 0.96%)}	_{2.27s (± 3.50%)}	_{🔻+0.25s (+12.30%)}	_2.11s	_2.32s	_{p=0.005 n=6}
_{Check Time}	_{40.65s (± 0.35%)}	_{40.29s (± 0.53%)}	_{-0.36s (- 0.87%)}	_39.99s	_40.58s	_{p=0.013 n=6}
_{Emit Time}	_{3.29s (± 4.80%)}	_{3.31s (± 4.85%)}	_~	_3.12s	_3.57s	_{p=0.810 n=6}
_{Total Time}	_{52.24s (± 0.51%)}	_{52.49s (± 0.61%)}	_~	_51.96s	_52.88s	_{p=0.128 n=6}
_{self-compiler - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_258,268	_258,297	_{+29 (+ 0.01%)}	_~	_~	_{p=0.001 n=6}
_Types	_104,775	_104,792	_{+17 (+ 0.02%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{427,517k (± 0.02%)}	_{429,920k (± 0.01%)}	_{+2,403k (+ 0.56%)}	_429,874k	_429,950k	_{p=0.005 n=6}
_{Parse Time}	_{4.09s (± 0.70%)}	_{4.27s (± 0.34%)}	_{🔻+0.18s (+ 4.40%)}	_4.25s	_4.29s	_{p=0.005 n=6}
_{Bind Time}	_{1.61s (± 1.28%)}	_{1.66s (± 0.83%)}	_{+0.04s (+ 2.48%)}	_1.63s	_1.67s	_{p=0.012 n=6}
_{Check Time}	_{22.05s (± 0.27%)}	_{22.00s (± 0.34%)}	_~	_21.92s	_22.12s	_{p=0.334 n=6}
_{Emit Time}	_{1.58s (± 1.30%)}	_{1.57s (± 0.94%)}	_~	_1.55s	_1.59s	_{p=0.289 n=6}
_{Total Time}	_{29.34s (± 0.34%)}	_{29.50s (± 0.27%)}	_{+0.17s (+ 0.57%)}	_29.40s	_29.62s	_{p=0.013 n=6}
_{ts-pre-modules - node (v18.15.0, x64)}
_Errors	₃₅	₃₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_224,565	_224,565	_~	_~	_~	_{p=1.000 n=6}
_Types	_93,734	_93,734	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{369,515k (± 0.02%)}	_{369,637k (± 0.03%)}	_~	_369,518k	_369,825k	_{p=0.173 n=6}
_{Parse Time}	_{3.44s (± 0.88%)}	_{3.40s (± 1.06%)}	_~	_3.36s	_3.45s	_{p=0.148 n=6}
_{Bind Time}	_{1.94s (± 1.25%)}	_{1.92s (± 0.97%)}	_~	_1.90s	_1.95s	_{p=0.142 n=6}
_{Check Time}	_{19.14s (± 0.22%)}	_{19.18s (± 0.25%)}	_~	_19.12s	_19.25s	_{p=0.261 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{24.52s (± 0.20%)}	_{24.50s (± 0.21%)}	_~	_24.46s	_24.59s	_{p=0.570 n=6}
_{vscode - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,887,752	_2,887,752	_~	_~	_~	_{p=1.000 n=6}
_Types	_977,127	_977,127	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{3,051,720k (± 0.00%)}	_{3,052,001k (± 0.00%)}	_{+281k (+ 0.01%)}	_3,051,944k	_3,052,066k	_{p=0.005 n=6}
_{Parse Time}	_{13.75s (± 0.31%)}	_{13.78s (± 0.22%)}	_~	_13.75s	_13.83s	_{p=0.373 n=6}
_{Bind Time}	_{4.19s (± 0.23%)}	_{4.20s (± 0.18%)}	_{+0.01s (+ 0.32%)}	_4.19s	_4.21s	_{p=0.044 n=6}
_{Check Time}	_{74.52s (± 2.19%)}	_{73.95s (± 0.33%)}	_~	_73.61s	_74.23s	_{p=1.000 n=6}
_{Emit Time}	_{23.28s (± 7.09%)}	_{23.91s (± 0.33%)}	_~	_23.77s	_24.01s	_{p=0.873 n=6}
_{Total Time}	_{115.75s (± 0.35%)}	_{115.84s (± 0.23%)}	_~	_115.53s	_116.18s	_{p=0.689 n=6}
_{webpack - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_267,117	_267,117	_~	_~	_~	_{p=1.000 n=6}
_Types	_108,775	_108,775	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{411,541k (± 0.02%)}	_{411,644k (± 0.02%)}	_~	_411,550k	_411,715k	_{p=0.066 n=6}
_{Parse Time}	_{4.72s (± 0.68%)}	_{4.72s (± 0.72%)}	_~	_4.68s	_4.77s	_{p=1.000 n=6}
_{Bind Time}	_{2.09s (± 0.64%)}	_{2.08s (± 0.84%)}	_~	_2.07s	_2.11s	_{p=0.510 n=6}
_{Check Time}	_{20.76s (± 0.30%)}	_{20.82s (± 0.28%)}	_~	_20.72s	_20.90s	_{p=0.125 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{27.57s (± 0.20%)}	_{27.62s (± 0.34%)}	_~	_27.48s	_27.76s	_{p=0.227 n=6}
_{xstate-main - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_525,251	_525,251	_~	_~	_~	_{p=1.000 n=6}
_Types	_178,574	_178,574	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{462,531k (± 0.06%)}	_{462,903k (± 0.06%)}	_~	_462,448k	_463,133k	_{p=0.065 n=6}
_{Parse Time}	_{2.65s (± 0.60%)}	_{2.64s (± 0.62%)}	_~	_2.62s	_2.66s	_{p=0.190 n=6}
_{Bind Time}	_{0.98s (± 0.53%)}	_{0.97s (± 0.84%)}	_{-0.01s (- 1.02%)}	_0.96s	_0.98s	_{p=0.050 n=6}
_{Check Time}	_{15.16s (± 0.33%)}	_{15.22s (± 0.23%)}	_{+0.06s (+ 0.41%)}	_15.18s	_15.28s	_{p=0.037 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{18.79s (± 0.24%)}	_{18.82s (± 0.21%)}	_~	_18.76s	_18.86s	_{p=0.170 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Compiler-Unions - node (v18.15.0, x64)
angular-1 - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-build-src-public-api - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
ts-pre-modules - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate-main - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

preserve declarations if @internal is mentioned in unrelated comment

9f28ce9

typescript-bot added the For Backlog Bug PRs that fix a backlog bug label Mar 27, 2024

jakebailey reviewed Mar 27, 2024

View reviewed changes

src/compiler/utilitiesPublic.ts Outdated Show resolved Hide resolved

Zzzen and others added 2 commits March 28, 2024 01:00

Update utilitiesPublic.ts

943263e

Co-authored-by: Jake Bailey <[email protected]>

update baseline

fec903e

sandersn requested a review from rbuckton May 9, 2024 22:30

sandersn assigned jakebailey May 9, 2024

Merge branch 'main' into pr-57960

55448b0

Fix baselines

27a0b32

sheetalkamat approved these changes Jun 18, 2024

View reviewed changes

jakebailey reviewed Jun 18, 2024

View reviewed changes

src/compiler/parser.ts Show resolved Hide resolved

jakebailey reviewed Jun 18, 2024

View reviewed changes

jakebailey requested changes Jun 18, 2024

View reviewed changes

jakebailey mentioned this pull request Jun 18, 2024

Set JSDocParsingMode.ParseForTypeErrors in compiler tests #58917

Merged

jakebailey closed this Jun 19, 2024

jakebailey reopened this Jun 19, 2024

jakebailey added 2 commits June 26, 2024 21:44

Merge branch 'main' into fix-internal-tag-in-comment

0621e02

Fix internal tag parsing

6ba683f

sheetalkamat previously approved these changes Jun 27, 2024

View reviewed changes

jakebailey approved these changes Jun 27, 2024

View reviewed changes

jakebailey requested changes Jun 27, 2024

View reviewed changes

fix dt tests

0420b01

Zzzen closed this Jun 28, 2024

Zzzen reopened this Jun 28, 2024

jakebailey added 2 commits July 9, 2024 15:17

Merge branch 'main' into fix-internal-tag-in-comment

5d21ce9

fmt

355c591

Zzzen dismissed sheetalkamat’s stale review via 355c591 March 31, 2025 22:58

preserve declarations if @internal is mentioned in unrelated comment #57960

Are you sure you want to change the base?

preserve declarations if @internal is mentioned in unrelated comment #57960

Conversation

Zzzen commented Mar 27, 2024

Uh oh!

typescript-bot commented Mar 27, 2024

Uh oh!

Uh oh!

jakebailey commented Jun 14, 2024

Uh oh!

Uh oh!

jakebailey left a comment

Choose a reason for hiding this comment

Uh oh!

jakebailey left a comment

Choose a reason for hiding this comment

Uh oh!

jakebailey commented Jun 19, 2024

Uh oh!

jakebailey commented Jun 27, 2024

Uh oh!

jakebailey commented Jun 27, 2024

Uh oh!

typescript-bot commented Jun 27, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Jun 27, 2024

Uh oh!

jakebailey left a comment

Choose a reason for hiding this comment

Uh oh!

typescript-bot commented Jun 27, 2024

azure-sdk

/mnt/ts_downloads/_/m/azure-sdk/build.sh

Uh oh!

typescript-bot commented Jun 27, 2024

tsc

Uh oh!

typescript-bot commented Jun 27, 2024

Uh oh!

Zzzen commented Jun 28, 2024

Uh oh!

jakebailey commented Jun 28, 2024

Uh oh!

typescript-bot commented Jun 28, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jakebailey commented Jun 28, 2024

Uh oh!

typescript-bot commented Jun 28, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Jun 28, 2024

Uh oh!

typescript-bot commented Jun 28, 2024

Uh oh!

typescript-bot commented Jun 28, 2024

tsc

Uh oh!

jakebailey commented Jun 28, 2024

Uh oh!

typescript-bot commented Jun 28, 2024

Uh oh!

Zzzen commented Jun 29, 2024

Uh oh!

jakebailey commented Jun 29, 2024

Uh oh!

Zzzen commented Jun 29, 2024

Uh oh!

sandersn commented Jul 9, 2024

Uh oh!

jakebailey commented Jul 9, 2024

Uh oh!

jakebailey commented Jul 9, 2024

Uh oh!

typescript-bot commented Jul 9, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Jul 9, 2024

typescript-bot commented Jun 27, 2024 •

edited

Loading

typescript-bot commented Jun 28, 2024 •

edited

Loading

typescript-bot commented Jun 28, 2024 •

edited

Loading

typescript-bot commented Jul 9, 2024 •

edited

Loading