fix54092: return replacement ranges for completions on unclosed strings #57839
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typescript-bot
added
Author: Team
For Uncommitted Bug
| //// a["[|foo.b/*3*/|]" | ||
| //// a["[|foo./*4*/b|] | ||
| //// a['[|foo./*5*/b|] | ||
| //// a[`[|foo./*6*/b|] |
There was a problem hiding this comment.
Can you add test cases for when you have foo. (no contents following the dot) and fo (no dot or following contents)?
There was a problem hiding this comment.
added! I also tested manually in vscode to see that the behavior didn't change for the previously working cases, even though it does return a replacementSpan now.
Co-authored-by: Daniel Rosenwasser <[email protected]>
gabritto
approved these changes
Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #54092.
Replacement ranges for string completions will be returned unless the closed string is empty (a single unclosed quote).