Completion for string property doesn't include replacementSpan if string is unclosed

[stefan-lacatus]

monaco-editor version: 0.10.1
Browser: All
OS: All
Steps or JS usage snippet reproducing the issue:
Completions of fields with dot in their name is somewhat broken.
How to reproduce:

1. You have the following object: let x = { "foo.bar": "test" };
2. Typing in x["fo] and pressing ctrl+space, and then selecting foo.bar generates the expected result
3. Typing in x["foo.b and pressing ctrl+space, and selecting foo.bar generates x["foo.foo.bar.

Basically if there is a dot in the field name the issue appears. It only happens in monaco editor. VScode does not have the same bug.

I would gladly fix this if you can point me in the right direction (monaco-typescript most likely, in the completions provider, but i don't really see what the issue is in the code).

[stefan-lacatus]

Still present in 11.1

[nrayburn-tech]

It looks like this happens in vscode as well.
Version 1.41.1 and the current 1.43.0 build.

[nrayburn-tech]

@alexdima I can't seem to find out how exactly to fix this, but I have some information that might help you or somebody else fix it.
If this line, https://github.com/microsoft/vscode/blob/07c33977da255861edf71e65b18249d2f67d0762/extensions/typescript-language-features/src/features/completions.ts#L83, evaluates to false then it seems to fix the issue. I don't think that a property with a . in it should be true for isMemberCompletion, so the response here, https://github.com/microsoft/vscode/blob/07c33977da255861edf71e65b18249d2f67d0762/extensions/typescript-language-features/src/features/completions.ts#L440, should return false for isMemberCompletion.

Let me know if any of that doesn't make sense.

[hediet]

Reproduces in vscode: