Avoid infinite recursion with `inferReverseMappedType` #57837

gabritto · 2024-03-18T21:52:15Z

For reference, the test case reported in the issue loops until stack overflow with the following function calls repeating:

at resolveReverseMappedTypeMembers (src\compiler\checker.ts:13790:69)
at resolveStructuredTypeMembers (src\compiler\checker.ts:14103:21)
at C:\Users\gabrielaa\code\Typescript\src\compiler\checker.ts:17091:148
at some (src\compiler\core.ts:665:21)
at removeSubtypes (src\compiler\checker.ts:17091:50)
at getUnionTypeWorker (src\compiler\checker.ts:17314:27)
at getUnionType (src\compiler\checker.ts:17286:16)
at getTypeFromInference (src\compiler\checker.ts:25353:39)
at inferReverseMappedType (src\compiler\checker.ts:25307:16)

gabritto · 2024-03-18T21:54:27Z

@typescript-bot run dt
@typescript-bot user test this
@typescript-bot test top400
@typescript-bot perf test this

typescript-bot · 2024-03-18T21:54:30Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`run dt`	✅ Started	✅ Results
`user test this`	✅ Started	✅ Results
`test top400`	✅ Started	✅ Results
`perf test this`	✅ Started	👀 Results

typescript-bot · 2024-03-18T22:13:58Z

Hey @gabritto, the results of running the DT tests are ready.
Everything looks the same!
You can check the log here.

typescript-bot · 2024-03-18T22:18:57Z

@gabritto Here are the results of running the user test suite comparing main and refs/pull/57837/merge:

There were infrastructure failures potentially unrelated to your change:

1 instance of "Unknown failure"

Otherwise...

Everything looks good!

typescript-bot · 2024-03-18T23:06:16Z

@gabritto
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Angular - node (v18.15.0, x64)}
_{Memory used}	_{295,753k (± 0.00%)}	_{295,761k (± 0.00%)}	_~	_295,744k	_295,772k	_{p=0.260 n=6}
_{Parse Time}	_{2.66s (± 0.15%)}	_{2.66s (± 0.37%)}	_~	_2.65s	_2.67s	_{p=0.930 n=6}
_{Bind Time}	_{0.83s (± 0.49%)}	_{0.83s (± 0.66%)}	_~	_0.82s	_0.83s	_{p=0.282 n=6}
_{Check Time}	_{8.18s (± 0.26%)}	_{8.18s (± 0.21%)}	_~	_8.15s	_8.20s	_{p=0.870 n=6}
_{Emit Time}	_{7.12s (± 0.48%)}	_{7.14s (± 0.17%)}	_~	_7.12s	_7.15s	_{p=0.293 n=6}
_{Total Time}	_{18.80s (± 0.22%)}	_{18.80s (± 0.11%)}	_~	_18.77s	_18.83s	_{p=0.629 n=6}
_{Compiler-Unions - node (v18.15.0, x64)}
_{Memory used}	_{193,189k (± 0.91%)}	_{193,863k (± 0.99%)}	_~	_191,885k	_195,684k	_{p=0.298 n=6}
_{Parse Time}	_{1.38s (± 1.33%)}	_{1.36s (± 1.10%)}	_~	_1.34s	_1.38s	_{p=0.134 n=6}
_{Bind Time}	_{0.72s (± 0.00%)}	_{0.72s (± 0.00%)}	_~	_0.72s	_0.72s	_{p=1.000 n=6}
_{Check Time}	_{9.46s (± 0.74%)}	_{9.54s (± 0.74%)}	_~	_9.44s	_9.62s	_{p=0.147 n=6}
_{Emit Time}	_{2.66s (± 0.39%)}	_{2.66s (± 0.70%)}	_~	_2.63s	_2.68s	_{p=0.934 n=6}
_{Total Time}	_{14.21s (± 0.59%)}	_{14.28s (± 0.45%)}	_~	_14.18s	_14.35s	_{p=0.109 n=6}
_{Monaco - node (v18.15.0, x64)}
_{Memory used}	_{347,387k (± 0.01%)}	_{347,386k (± 0.01%)}	_~	_347,366k	_347,417k	_{p=1.000 n=6}
_{Parse Time}	_{2.48s (± 0.49%)}	_{2.48s (± 0.49%)}	_~	_2.46s	_2.49s	_{p=0.406 n=6}
_{Bind Time}	_{0.93s (± 0.00%)}	_{0.92s (± 0.59%)}	_~	_0.92s	_0.93s	_{p=0.071 n=6}
_{Check Time}	_{7.00s (± 0.49%)}	_{7.03s (± 0.41%)}	_~	_6.98s	_7.07s	_{p=0.294 n=6}
_{Emit Time}	_{4.06s (± 0.50%)}	_{4.05s (± 0.25%)}	_~	_4.03s	_4.06s	_{p=0.181 n=6}
_{Total Time}	_{14.48s (± 0.31%)}	_{14.48s (± 0.27%)}	_~	_14.42s	_14.54s	_{p=0.686 n=6}
_{TFS - node (v18.15.0, x64)}
_{Memory used}	_{302,718k (± 0.00%)}	_{302,737k (± 0.01%)}	_~	_302,713k	_302,775k	_{p=0.173 n=6}
_{Parse Time}	_{2.01s (± 0.26%)}	_{2.00s (± 1.48%)}	_~	_1.95s	_2.04s	_{p=0.209 n=6}
_{Bind Time}	_{1.00s (± 0.75%)}	_{1.01s (± 1.16%)}	_~	_0.99s	_1.02s	_{p=0.279 n=6}
_{Check Time}	_{6.32s (± 0.23%)}	_{6.29s (± 0.46%)}	_~	_6.26s	_6.33s	_{p=0.089 n=6}
_{Emit Time}	_{3.61s (± 0.37%)}	_{3.62s (± 0.29%)}	_~	_3.60s	_3.63s	_{p=0.358 n=6}
_{Total Time}	_{12.94s (± 0.19%)}	_{12.91s (± 0.22%)}	_~	_12.87s	_12.95s	_{p=0.106 n=6}
_{material-ui - node (v18.15.0, x64)}
_{Memory used}	_{511,372k (± 0.00%)}	_{511,356k (± 0.00%)}	_~	_511,327k	_511,381k	_{p=0.173 n=6}
_{Parse Time}	_{2.65s (± 0.55%)}	_{2.65s (± 0.39%)}	_~	_2.64s	_2.67s	_{p=0.805 n=6}
_{Bind Time}	_{0.98s (± 1.58%)}	_{0.98s (± 0.52%)}	_~	_0.98s	_0.99s	_{p=0.929 n=6}
_{Check Time}	_{17.37s (± 0.50%)}	_{17.31s (± 0.51%)}	_~	_17.19s	_17.42s	_{p=0.298 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{21.00s (± 0.38%)}	_{20.95s (± 0.44%)}	_~	_20.83s	_21.08s	_{p=0.261 n=6}
_{mui-docs - node (v18.15.0, x64)}
_{Memory used}	_{1,719,111k (± 0.00%)}	_{1,719,101k (± 0.00%)}	_~	_1,719,052k	_1,719,152k	_{p=0.936 n=6}
_{Parse Time}	_{6.50s (± 0.48%)}	_{6.49s (± 0.53%)}	_~	_6.43s	_6.53s	_{p=1.000 n=6}
_{Bind Time}	_{2.36s (± 0.83%)}	_{2.36s (± 0.32%)}	_~	_2.35s	_2.37s	_{p=1.000 n=6}
_{Check Time}	_{56.34s (± 0.14%)}	_{56.28s (± 0.69%)}	_~	_55.90s	_56.77s	_{p=0.470 n=6}
_{Emit Time}	_{0.13s (± 3.10%)}	_{0.13s (± 3.10%)}	_~	_0.13s	_0.14s	_{p=1.000 n=6}
_{Total Time}	_{65.34s (± 0.13%)}	_{65.26s (± 0.62%)}	_~	_64.81s	_65.75s	_{p=0.688 n=6}
_{self-build-src - node (v18.15.0, x64)}
_{Memory used}	_{2,395,521k (± 0.02%)}	_{2,395,122k (± 0.03%)}	_~	_2,394,054k	_2,395,827k	_{p=0.230 n=6}
_{Parse Time}	_{5.01s (± 1.02%)}	_{4.97s (± 1.44%)}	_~	_4.87s	_5.05s	_{p=0.521 n=6}
_{Bind Time}	_{1.89s (± 1.02%)}	_{1.90s (± 0.91%)}	_~	_1.88s	_1.92s	_{p=0.557 n=6}
_{Check Time}	_{33.58s (± 0.35%)}	_{33.66s (± 0.46%)}	_~	_33.45s	_33.82s	_{p=0.423 n=6}
_{Emit Time}	_{2.71s (± 0.89%)}	_{2.74s (± 0.45%)}	_{+0.04s (+ 1.42%)}	_2.73s	_2.76s	_{p=0.022 n=6}
_{Total Time}	_{43.21s (± 0.36%)}	_{43.29s (± 0.43%)}	_~	_43.08s	_43.50s	_{p=0.471 n=6}
_{self-compiler - node (v18.15.0, x64)}
_{Memory used}	_{416,073k (± 0.01%)}	_{416,134k (± 0.01%)}	_{+61k (+ 0.01%)}	_416,093k	_416,190k	_{p=0.013 n=6}
_{Parse Time}	_{2.86s (± 1.23%)}	_{2.81s (± 1.38%)}	_~	_2.75s	_2.86s	_{p=0.122 n=6}
_{Bind Time}	_{1.06s (± 0.97%)}	_{1.07s (± 0.70%)}	_~	_1.06s	_1.08s	_{p=0.351 n=6}
_{Check Time}	_{15.32s (± 0.29%)}	_{15.28s (± 0.37%)}	_~	_15.19s	_15.36s	_{p=0.333 n=6}
_{Emit Time}	_{1.14s (± 1.43%)}	_{1.15s (± 1.23%)}	_~	_1.13s	_1.17s	_{p=0.459 n=6}
_{Total Time}	_{20.38s (± 0.11%)}	_{20.32s (± 0.18%)}	_{-0.06s (- 0.31%)}	_20.26s	_20.37s	_{p=0.016 n=6}
_{vscode - node (v18.15.0, x64)}
_{Memory used}	_{2,883,061k (± 0.00%)}	_{2,883,039k (± 0.00%)}	_~	_2,882,921k	_2,883,145k	_{p=0.575 n=6}
_{Parse Time}	_{10.82s (± 0.37%)}	_{10.82s (± 0.43%)}	_~	_10.77s	_10.88s	_{p=0.936 n=6}
_{Bind Time}	_{3.47s (± 0.34%)}	_{3.47s (± 0.24%)}	_~	_3.46s	_3.48s	_{p=1.000 n=6}
_{Check Time}	_{61.64s (± 0.54%)}	_{61.59s (± 0.71%)}	_~	_61.06s	_62.06s	_{p=1.000 n=6}
_{Emit Time}	_{16.92s (± 8.12%)}	_{17.62s (± 9.67%)}	_~	_16.32s	_19.89s	_{p=0.148 n=6}
_{Total Time}	_{92.85s (± 1.52%)}	_{93.50s (± 2.23%)}	_~	_91.80s	_96.19s	_{p=1.000 n=6}
_{webpack - node (v18.15.0, x64)}
_{Memory used}	_{407,994k (± 0.02%)}	_{407,945k (± 0.01%)}	_~	_407,894k	_408,008k	_{p=0.378 n=6}
_{Parse Time}	_{3.22s (± 0.46%)}	_{3.22s (± 0.38%)}	_~	_3.21s	_3.24s	_{p=0.934 n=6}
_{Bind Time}	_{1.38s (± 0.30%)}	_{1.38s (± 1.29%)}	_~	_1.35s	_1.40s	_{p=0.548 n=6}
_{Check Time}	_{14.30s (± 0.32%)}	_{14.29s (± 0.34%)}	_~	_14.22s	_14.35s	_{p=0.872 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{18.91s (± 0.25%)}	_{18.89s (± 0.27%)}	_~	_18.82s	_18.97s	_{p=0.687 n=6}
_{xstate - node (v18.15.0, x64)}
_{Memory used}	_{513,080k (± 0.02%)}	_{513,059k (± 0.01%)}	_~	_512,984k	_513,143k	_{p=0.575 n=6}
_{Parse Time}	_{3.27s (± 0.43%)}	_{3.28s (± 0.36%)}	_~	_3.27s	_3.30s	_{p=0.357 n=6}
_{Bind Time}	_{1.54s (± 0.67%)}	_{1.54s (± 0.49%)}	_~	_1.53s	_1.55s	_{p=0.931 n=6}
_{Check Time}	_{2.86s (± 0.82%)}	_{2.84s (± 0.47%)}	_~	_2.82s	_2.86s	_{p=0.418 n=6}
_{Emit Time}	_{0.07s (± 0.00%)}	_{0.07s (± 0.00%)}	_~	_0.07s	_0.07s	_{p=1.000 n=6}
_{Total Time}	_{7.74s (± 0.44%)}	_{7.74s (± 0.22%)}	_~	_7.71s	_7.76s	_{p=0.747 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Angular - node (v18.15.0, x64)
Compiler-Unions - node (v18.15.0, x64)
Monaco - node (v18.15.0, x64)
TFS - node (v18.15.0, x64)
material-ui - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

tsserver

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-UnionsTSServer - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{2,351ms (± 0.66%)}	_{2,355ms (± 0.49%)}	_~	_2,342ms	_2,368ms	_{p=0.872 n=6}
_{Req 2 - geterr}	_{5,779ms (± 0.53%)}	_{5,772ms (± 0.38%)}	_~	_5,738ms	_5,802ms	_{p=0.688 n=6}
_{Req 3 - references}	_{325ms (± 1.11%)}	_{325ms (± 0.89%)}	_~	_322ms	_330ms	_{p=0.934 n=6}
_{Req 4 - navto}	_{273ms (± 0.19%)}	_{272ms (± 0.19%)}	_~	_272ms	_273ms	_{p=0.311 n=6}
_{Req 5 - completionInfo count}	_{1,357 (± 0.00%)}	_{1,357 (± 0.00%)}	_~	_1,357	_1,357	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{94ms (± 0.80%)}	_{95ms (± 0.88%)}	_~	_93ms	_95ms	_{p=0.432 n=6}
_{CompilerTSServer - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{2,504ms (± 0.72%)}	_{2,491ms (± 0.54%)}	_~	_2,478ms	_2,517ms	_{p=0.261 n=6}
_{Req 2 - geterr}	_{4,262ms (± 0.21%)}	_{4,261ms (± 0.37%)}	_~	_4,242ms	_4,288ms	_{p=0.810 n=6}
_{Req 3 - references}	_{331ms (± 0.31%)}	_{332ms (± 0.25%)}	_~	_331ms	_333ms	_{p=0.546 n=6}
_{Req 4 - navto}	_{284ms (± 0.37%)}	_{284ms (± 0.56%)}	_~	_283ms	_287ms	_{p=0.615 n=6}
_{Req 5 - completionInfo count}	_{1,519 (± 0.00%)}	_{1,519 (± 0.00%)}	_~	_1,519	_1,519	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{78ms (± 0.66%)}	_{78ms (± 1.04%)}	_~	_77ms	_79ms	_{p=0.140 n=6}
_{xstateTSServer - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{2,620ms (± 0.19%)}	_{2,618ms (± 0.44%)}	_~	_2,601ms	_2,634ms	_{p=0.688 n=6}
_{Req 2 - geterr}	_{1,719ms (± 1.78%)}	_{1,722ms (± 2.50%)}	_~	_1,658ms	_1,782ms	_{p=1.000 n=6}
_{Req 3 - references}	_{121ms (± 8.29%)}	_{122ms (± 8.14%)}	_~	_108ms	_130ms	_{p=0.935 n=6}
_{Req 4 - navto}	_{373ms (± 0.53%)}	_{372ms (± 0.92%)}	_~	_369ms	_378ms	_{p=0.332 n=6}
_{Req 5 - completionInfo count}	_{2,079 (± 0.00%)}	_{2,079 (± 0.00%)}	_~	_2,079	_2,079	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{307ms (± 2.48%)}	_{308ms (± 1.57%)}	_~	_302ms	_315ms	_{p=0.423 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

CompilerTSServer - node (v18.15.0, x64)
Compiler-UnionsTSServer - node (v18.15.0, x64)
xstateTSServer - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

startup

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{tsc-startup - node (v18.15.0, x64)}
_{Execution time}	_{153.49ms (± 0.19%)}	_{153.60ms (± 0.19%)}	_{+0.12ms (+ 0.08%)}	_152.56ms	_157.44ms	_{p=0.000 n=600}
_{tsserver-startup - node (v18.15.0, x64)}
_{Execution time}	_{229.88ms (± 0.15%)}	_{229.89ms (± 0.18%)}	_~	_228.34ms	_236.39ms	_{p=0.624 n=600}
_{tsserverlibrary-startup - node (v18.15.0, x64)}
_{Execution time}	_{222.29ms (± 0.13%)}	_{222.24ms (± 0.15%)}	_~	_220.70ms	_229.06ms	_{p=0.054 n=600}
_{typescript-startup - node (v18.15.0, x64)}
_{Execution time}	_{221.86ms (± 0.15%)}	_{221.80ms (± 0.15%)}	_~	_220.39ms	_225.21ms	_{p=0.144 n=600}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

tsc-startup - node (v18.15.0, x64)
tsserver-startup - node (v18.15.0, x64)
tsserverlibrary-startup - node (v18.15.0, x64)
typescript-startup - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

typescript-bot · 2024-03-18T23:26:52Z

@gabritto Here are the results of running the top-repos suite comparing main and refs/pull/57837/merge:

Everything looks good!

gabritto · 2024-03-18T23:32:33Z

@typescript-bot perf test this faster

typescript-bot · 2024-03-18T23:32:36Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`perf test this faster`	✅ Started	👀 Results

typescript-bot · 2024-03-19T00:21:15Z

@gabritto
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Angular - node (v18.15.0, x64)}
_{Memory used}	_{295,756k (± 0.01%)}	_{295,754k (± 0.00%)}	_~	_295,733k	_295,770k	_{p=0.810 n=6}
_{Parse Time}	_{2.66s (± 0.15%)}	_{2.66s (± 0.70%)}	_~	_2.63s	_2.68s	_{p=0.473 n=6}
_{Bind Time}	_{0.83s (± 0.62%)}	_{0.83s (± 0.90%)}	_~	_0.82s	_0.84s	_{p=0.241 n=6}
_{Check Time}	_{8.20s (± 0.40%)}	_{8.20s (± 0.32%)}	_~	_8.15s	_8.22s	_{p=0.746 n=6}
_{Emit Time}	_{7.12s (± 0.25%)}	_{7.13s (± 0.32%)}	_~	_7.09s	_7.15s	_{p=0.463 n=6}
_{Total Time}	_{18.81s (± 0.30%)}	_{18.82s (± 0.32%)}	_~	_18.71s	_18.87s	_{p=1.000 n=6}
_{Compiler-Unions - node (v18.15.0, x64)}
_{Memory used}	_{192,053k (± 0.09%)}	_{192,189k (± 0.07%)}	_~	_191,915k	_192,301k	_{p=0.471 n=6}
_{Parse Time}	_{1.36s (± 1.42%)}	_{1.35s (± 0.73%)}	_~	_1.33s	_1.36s	_{p=0.081 n=6}
_{Bind Time}	_{0.72s (± 0.00%)}	_{0.72s (± 0.00%)}	_~	_0.72s	_0.72s	_{p=1.000 n=6}
_{Check Time}	_{9.53s (± 0.57%)}	_{9.52s (± 0.78%)}	_~	_9.40s	_9.61s	_{p=1.000 n=6}
_{Emit Time}	_{2.66s (± 0.62%)}	_{2.65s (± 0.31%)}	_~	_2.64s	_2.66s	_{p=0.616 n=6}
_{Total Time}	_{14.27s (± 0.41%)}	_{14.24s (± 0.55%)}	_~	_14.11s	_14.34s	_{p=0.936 n=6}
_{Monaco - node (v18.15.0, x64)}
_{Memory used}	_{347,383k (± 0.01%)}	_{347,383k (± 0.01%)}	_~	_347,362k	_347,419k	_{p=0.936 n=6}
_{Parse Time}	_{2.48s (± 0.54%)}	_{2.48s (± 0.40%)}	_~	_2.46s	_2.49s	_{p=0.934 n=6}
_{Bind Time}	_{0.93s (± 0.56%)}	_{0.93s (± 0.00%)}	_~	_0.93s	_0.93s	_{p=0.174 n=6}
_{Check Time}	_{7.03s (± 0.56%)}	_{7.03s (± 0.60%)}	_~	_6.95s	_7.08s	_{p=1.000 n=6}
_{Emit Time}	_{4.07s (± 0.29%)}	_{4.06s (± 0.63%)}	_~	_4.04s	_4.09s	_{p=0.744 n=6}
_{Total Time}	_{14.51s (± 0.30%)}	_{14.49s (± 0.26%)}	_~	_14.45s	_14.54s	_{p=0.520 n=6}
_{TFS - node (v18.15.0, x64)}
_{Memory used}	_{302,730k (± 0.00%)}	_{302,761k (± 0.01%)}	_~	_302,711k	_302,803k	_{p=0.108 n=6}
_{Parse Time}	_{2.01s (± 0.86%)}	_{1.99s (± 0.53%)}	_~	_1.98s	_2.01s	_{p=0.086 n=6}
_{Bind Time}	_{1.01s (± 0.81%)}	_{1.00s (± 1.22%)}	_~	_0.99s	_1.02s	_{p=0.730 n=6}
_{Check Time}	_{6.31s (± 0.16%)}	_{6.32s (± 0.44%)}	_~	_6.28s	_6.36s	_{p=0.802 n=6}
_{Emit Time}	_{3.61s (± 0.62%)}	_{3.62s (± 0.71%)}	_~	_3.57s	_3.64s	_{p=0.743 n=6}
_{Total Time}	_{12.94s (± 0.29%)}	_{12.93s (± 0.33%)}	_~	_12.87s	_12.97s	_{p=1.000 n=6}
_{material-ui - node (v18.15.0, x64)}
_{Memory used}	_{511,358k (± 0.00%)}	_{511,377k (± 0.00%)}	_~	_511,366k	_511,392k	_{p=0.149 n=6}
_{Parse Time}	_{2.66s (± 0.79%)}	_{2.65s (± 0.66%)}	_~	_2.63s	_2.68s	_{p=0.190 n=6}
_{Bind Time}	_{0.98s (± 1.06%)}	_{0.99s (± 0.83%)}	_~	_0.98s	_1.00s	_{p=0.865 n=6}
_{Check Time}	_{17.32s (± 0.41%)}	_{17.30s (± 0.42%)}	_~	_17.21s	_17.43s	_{p=0.629 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{20.97s (± 0.31%)}	_{20.93s (± 0.35%)}	_~	_20.83s	_21.05s	_{p=0.332 n=6}
_{mui-docs - node (v18.15.0, x64)}
_{Memory used}	_{1,719,093k (± 0.00%)}	_{1,719,130k (± 0.00%)}	_~	_1,719,032k	_1,719,175k	_{p=0.128 n=6}
_{Parse Time}	_{6.51s (± 0.24%)}	_{6.50s (± 0.64%)}	_~	_6.44s	_6.55s	_{p=0.685 n=6}
_{Bind Time}	_{2.36s (± 0.42%)}	_{2.36s (± 0.32%)}	_~	_2.35s	_2.37s	_{p=1.000 n=6}
_{Check Time}	_{56.21s (± 0.51%)}	_{56.42s (± 0.73%)}	_~	_55.77s	_57.07s	_{p=0.230 n=6}
_{Emit Time}	_{0.13s (± 0.00%)}	_{0.13s (± 0.00%)}	_~	_0.13s	_0.13s	_{p=1.000 n=6}
_{Total Time}	_{65.22s (± 0.46%)}	_{65.41s (± 0.64%)}	_~	_64.80s	_66.11s	_{p=0.298 n=6}
_{self-build-src - node (v18.15.0, x64)}
_{Memory used}	_{2,395,474k (± 0.02%)}	_{2,395,381k (± 0.02%)}	_~	_2,394,644k	_2,395,892k	_{p=0.810 n=6}
_{Parse Time}	_{4.99s (± 1.03%)}	_{4.95s (± 1.04%)}	_~	_4.89s	_5.01s	_{p=0.230 n=6}
_{Bind Time}	_{1.91s (± 1.14%)}	_{1.90s (± 0.90%)}	_~	_1.88s	_1.92s	_{p=0.805 n=6}
_{Check Time}	_{33.53s (± 0.32%)}	_{33.56s (± 0.36%)}	_~	_33.39s	_33.70s	_{p=0.748 n=6}
_{Emit Time}	_{2.72s (± 0.68%)}	_{2.73s (± 0.89%)}	_~	_2.68s	_2.74s	_{p=0.277 n=6}
_{Total Time}	_{43.15s (± 0.32%)}	_{43.16s (± 0.37%)}	_~	_42.95s	_43.35s	_{p=0.936 n=6}
_{self-compiler - node (v18.15.0, x64)}
_{Memory used}	_{416,067k (± 0.01%)}	_{416,118k (± 0.01%)}	_{+51k (+ 0.01%)}	_416,062k	_416,146k	_{p=0.045 n=6}
_{Parse Time}	_{2.82s (± 1.12%)}	_{2.81s (± 1.05%)}	_~	_2.76s	_2.84s	_{p=0.570 n=6}
_{Bind Time}	_{1.06s (± 0.60%)}	_{1.07s (± 0.51%)}	_~	_1.06s	_1.07s	_{p=0.201 n=6}
_{Check Time}	_{15.32s (± 0.50%)}	_{15.30s (± 0.18%)}	_~	_15.27s	_15.35s	_{p=0.226 n=6}
_{Emit Time}	_{1.14s (± 1.47%)}	_{1.15s (± 0.55%)}	_~	_1.14s	_1.16s	_{p=0.323 n=6}
_{Total Time}	_{20.34s (± 0.41%)}	_{20.33s (± 0.15%)}	_~	_20.27s	_20.36s	_{p=0.625 n=6}
_{vscode - node (v18.15.0, x64)}
_{Memory used}	_{2,883,054k (± 0.00%)}	_{2,883,078k (± 0.00%)}	_~	_2,882,966k	_2,883,165k	_{p=0.575 n=6}
_{Parse Time}	_{10.85s (± 0.34%)}	_{10.81s (± 0.35%)}	_~	_10.78s	_10.88s	_{p=0.076 n=6}
_{Bind Time}	_{3.45s (± 0.98%)}	_{3.48s (± 0.83%)}	_~	_3.45s	_3.53s	_{p=0.569 n=6}
_{Check Time}	_{61.52s (± 0.75%)}	_{61.80s (± 0.50%)}	_~	_61.42s	_62.32s	_{p=0.173 n=6}
_{Emit Time}	_{16.96s (± 8.33%)}	_{18.14s (±10.65%)}	_~	_16.30s	_20.01s	_{p=0.521 n=6}
_{Total Time}	_{92.79s (± 1.96%)}	_{94.23s (± 2.31%)}	_~	_92.09s	_96.51s	_{p=0.230 n=6}
_{webpack - node (v18.15.0, x64)}
_{Memory used}	_{407,998k (± 0.02%)}	_{407,960k (± 0.02%)}	_~	_407,838k	_408,102k	_{p=0.471 n=6}
_{Parse Time}	_{3.23s (± 0.28%)}	_{3.23s (± 0.46%)}	_~	_3.21s	_3.25s	_{p=0.804 n=6}
_{Bind Time}	_{1.38s (± 0.85%)}	_{1.38s (± 0.46%)}	_~	_1.37s	_1.39s	_{p=1.000 n=6}
_{Check Time}	_{14.30s (± 0.32%)}	_{14.30s (± 0.36%)}	_~	_14.22s	_14.35s	_{p=0.936 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{18.91s (± 0.29%)}	_{18.91s (± 0.30%)}	_~	_18.81s	_18.96s	_{p=0.809 n=6}
_{xstate - node (v18.15.0, x64)}
_{Memory used}	_{513,142k (± 0.01%)}	_{513,060k (± 0.01%)}	_~	_513,002k	_513,119k	_{p=0.093 n=6}
_{Parse Time}	_{3.28s (± 0.31%)}	_{3.27s (± 0.33%)}	_~	_3.26s	_3.29s	_{p=0.251 n=6}
_{Bind Time}	_{1.55s (± 0.53%)}	_{1.54s (± 0.68%)}	_~	_1.53s	_1.56s	_{p=0.865 n=6}
_{Check Time}	_{2.85s (± 0.31%)}	_{2.85s (± 0.59%)}	_~	_2.83s	_2.87s	_{p=0.934 n=6}
_{Emit Time}	_{0.07s (± 5.69%)}	_{0.07s (± 7.03%)}	_~	_0.07s	_0.08s	_{p=0.595 n=6}
_{Total Time}	_{7.75s (± 0.15%)}	_{7.74s (± 0.28%)}	_~	_7.72s	_7.77s	_{p=0.627 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Angular - node (v18.15.0, x64)
Compiler-Unions - node (v18.15.0, x64)
Monaco - node (v18.15.0, x64)
TFS - node (v18.15.0, x64)
material-ui - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

weswigham

The less-broadly used inferTypeForHomomorphicMappedType has caching/circularity prevention mechanisms already, but I guess since we use this lazily to generate the types of properties of reverse mapped types (directly, in more places than just the aforementioned function), it's gotta get dedicated circularity guards. I'm just wondering if the fail case should be unknown, or if it should be the constraint of the target?

gabritto · 2024-03-20T17:10:20Z

The less-broadly used inferTypeForHomomorphicMappedType has caching/circularity prevention mechanisms already, but I guess since we use this lazily to generate the types of properties of reverse mapped types (directly, in more places than just the aforementioned function), it's gotta get dedicated circularity guards.

What's the difference between calling inferTypeForHomomorphicMappedType and calling inferReverseMappedType directly?

I'm just wondering if the fail case should be unknown, or if it should be the constraint of the target?

I also have this same question. I'm returning unknown just because that's what inferReverseMappedType was already returning when inference failed (return getTypeFromInference(inference) || unknownType), but I don't know how we usually deal with failed inferences.

weswigham · 2024-03-21T21:20:02Z

What's the difference between calling inferTypeForHomomorphicMappedType and calling inferReverseMappedType directly?

inferTypeForHomomorphicMappedType is used to create the outer object type with lazily inferred properties, while inferReverseMappedType is used to make the types for the properties of that type on demand.

but I don't know how we usually deal with failed inferences.

getInferredType usually falls back to the constraint of the type parameter. I dunno if we wanna change the reverse mapped type fallback behavior to match. Maybe that should be a separate followup PR.

weswigham

This seems fine - definitely an improvement. Just wondering if we should also be doing caching within this function, rather than relying on callers of it to cache the results somehow.

weswigham · 2024-03-21T21:24:22Z

src/compiler/checker.ts

        const typeParameter = getIndexedAccessType(constraint.type, getTypeParameterFromMappedType(target)) as TypeParameter;
        const templateType = getTemplateTypeFromMappedType(target);
        const inference = createInferenceInfo(typeParameter);
        inferTypes([inference], sourceType, templateType);
        return getTypeFromInference(inference) || unknownType;
    }

+    function inferReverseMappedType(source: Type, target: MappedType, constraint: IndexType): Type {


Should we cache the results inside this, so we guarantee deeply nested results get cached? Of the callers of this function, only getTypeOfReverseMappedSymbol currently caches - the other uses don't (directly) cache the result, so could, in theory, witness different results for the same set of input types at different points. You can probably only easily trigger such a behavior with a reverse mapped type over an array...? Maybe?

I was adding the cache to inferReverseMappedType and looking at inferTypeForHomomorphicMappedType. I'm now wondering: could I do away with the recursion detection in inferTypeForHomomorphicMappedType (that uses homomorphicMappedTypeInferenceStack)?

I'm pretty sure that we can, however this once again begs the question of what to return when we find a circularity. inferTypeForHomomorphicMappedType returns undefined in this case. I'll have to think some more about this, but I'm planning on removing that circularity detection code in inferTypeForHomomorphicMappedType.

sandersn · 2024-03-27T21:03:43Z

I can't tell from the discussion if this is ready to merge. Do we want to investigate better caching before taking this? Do we need to figure out what happens in case of circularity?

gabritto · 2024-03-27T22:09:05Z

I can't tell from the discussion if this is ready to merge. Do we want to investigate better caching before taking this? Do we need to figure out what happens in case of circularity?

I want to do two things still: 1. think about what to return in case of circularity 2. get rid of the circularity detection in inferTypeForHomomorphicMappedType as I think the one in this PR supersedes that one. I might not succeed and decide to merge as is, but if I change something I'll re-request reviews.

Andarist · 2024-03-28T20:53:02Z

getInferredType usually falls back to the constraint of the type parameter. I dunno if we wanna change the reverse mapped type fallback behavior to match. Maybe that should be a separate followup PR.

I think that PR might already exist: #56300 ;p I need to take another look at it to see what is left to do there though

gabritto · 2024-04-10T19:59:35Z

@typescript-bot test it

typescript-bot · 2024-04-10T19:59:38Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`test top400`	✅ Started	✅ Results
`user test this`	✅ Started	✅ Results
`run dt`	✅ Started	✅ Results
`perf test this faster`	✅ Started	👀 Results

typescript-bot · 2024-04-10T20:20:57Z

Hey @gabritto, the results of running the DT tests are ready.

Everything looks the same!

You can check the log here.

typescript-bot · 2024-04-10T20:27:08Z

@gabritto Here are the results of running the user tests comparing main and refs/pull/57837/merge:

Everything looks good!

typescript-bot · 2024-04-10T20:35:41Z

@gabritto
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Angular - node (v18.15.0, x64)}
_{Memory used}	_{295,913k (± 0.01%)}	_{295,930k (± 0.01%)}	_~	_295,885k	_295,965k	_{p=0.575 n=6}
_{Parse Time}	_{2.65s (± 0.67%)}	_{2.65s (± 0.56%)}	_~	_2.63s	_2.66s	_{p=0.868 n=6}
_{Bind Time}	_{0.82s (± 1.33%)}	_{0.82s (± 1.33%)}	_~	_0.81s	_0.83s	_{p=1.000 n=6}
_{Check Time}	_{8.20s (± 0.47%)}	_{8.20s (± 0.34%)}	_~	_8.17s	_8.24s	_{p=1.000 n=6}
_{Emit Time}	_{7.05s (± 0.45%)}	_{7.06s (± 0.14%)}	_~	_7.05s	_7.07s	_{p=0.412 n=6}
_{Total Time}	_{18.72s (± 0.32%)}	_{18.73s (± 0.19%)}	_~	_18.69s	_18.78s	_{p=1.000 n=6}
_{Compiler-Unions - node (v18.15.0, x64)}
_{Memory used}	_{192,279k (± 0.74%)}	_{192,895k (± 1.01%)}	_~	_191,611k	_195,423k	_{p=0.575 n=6}
_{Parse Time}	_{2.02s (± 0.91%)}	_{2.03s (± 1.69%)}	_~	_1.99s	_2.07s	_{p=0.572 n=6}
_{Bind Time}	_{1.07s (± 1.29%)}	_{1.06s (± 1.39%)}	_~	_1.05s	_1.08s	_{p=0.734 n=6}
_{Check Time}	_{13.81s (± 0.35%)}	_{13.79s (± 0.21%)}	_~	_13.75s	_13.81s	_{p=0.418 n=6}
_{Emit Time}	_{3.85s (± 0.66%)}	_{3.86s (± 0.92%)}	_~	_3.80s	_3.89s	_{p=0.418 n=6}
_{Total Time}	_{20.74s (± 0.23%)}	_{20.74s (± 0.21%)}	_~	_20.67s	_20.79s	_{p=0.936 n=6}
_{Monaco - node (v18.15.0, x64)}
_{Memory used}	_{347,714k (± 0.00%)}	_{347,721k (± 0.01%)}	_~	_347,695k	_347,773k	_{p=1.000 n=6}
_{Parse Time}	_{3.68s (± 1.02%)}	_{3.70s (± 1.17%)}	_~	_3.64s	_3.76s	_{p=0.334 n=6}
_{Bind Time}	_{1.32s (± 0.91%)}	_{1.32s (± 0.75%)}	_~	_1.30s	_1.33s	_{p=0.557 n=6}
_{Check Time}	_{10.11s (± 0.57%)}	_{10.14s (± 0.53%)}	_~	_10.08s	_10.24s	_{p=0.627 n=6}
_{Emit Time}	_{6.02s (± 0.30%)}	_{6.03s (± 0.24%)}	_~	_6.01s	_6.05s	_{p=0.743 n=6}
_{Total Time}	_{21.14s (± 0.35%)}	_{21.19s (± 0.36%)}	_~	_21.10s	_21.28s	_{p=0.260 n=6}
_{TFS - node (v18.15.0, x64)}
_{Memory used}	_{302,567k (± 0.01%)}	_{302,588k (± 0.01%)}	_~	_302,554k	_302,645k	_{p=0.298 n=6}
_{Parse Time}	_{2.42s (± 0.58%)}	_{2.42s (± 1.34%)}	_~	_2.37s	_2.47s	_{p=0.871 n=6}
_{Bind Time}	_{1.16s (± 0.35%)}	_{1.16s (± 0.45%)}	_~	_1.15s	_1.16s	_{p=0.114 n=6}
_{Check Time}	_{7.45s (± 0.27%)}	_{7.47s (± 0.59%)}	_~	_7.41s	_7.52s	_{p=0.373 n=6}
_{Emit Time}	_{4.27s (± 0.78%)}	_{4.27s (± 0.58%)}	_~	_4.24s	_4.31s	_{p=0.936 n=6}
_{Total Time}	_{15.30s (± 0.34%)}	_{15.31s (± 0.26%)}	_~	_15.27s	_15.36s	_{p=0.747 n=6}
_{material-ui - node (v18.15.0, x64)}
_{Memory used}	_{510,539k (± 0.01%)}	_{510,568k (± 0.00%)}	_~	_510,544k	_510,590k	_{p=0.128 n=6}
_{Parse Time}	_{3.19s (± 0.38%)}	_{3.19s (± 0.55%)}	_~	_3.16s	_3.21s	_{p=0.317 n=6}
_{Bind Time}	_{1.17s (± 0.94%)}	_{1.17s (± 0.70%)}	_~	_1.16s	_1.18s	_{p=0.666 n=6}
_{Check Time}	_{20.40s (± 0.23%)}	_{20.49s (± 0.31%)}	_{+0.09s (+ 0.45%)}	_20.42s	_20.59s	_{p=0.030 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{24.76s (± 0.24%)}	_{24.86s (± 0.29%)}	_{+0.10s (+ 0.40%)}	_24.76s	_24.95s	_{p=0.045 n=6}
_{mui-docs - node (v18.15.0, x64)}
_{Memory used}	_{1,742,646k (± 0.00%)}	_{1,742,683k (± 0.00%)}	_~	_1,742,648k	_1,742,737k	_{p=0.109 n=6}
_{Parse Time}	_{9.72s (± 0.36%)}	_{9.68s (± 0.57%)}	_~	_9.63s	_9.79s	_{p=0.162 n=6}
_{Bind Time}	_{3.39s (± 1.12%)}	_{3.38s (± 1.01%)}	_~	_3.34s	_3.44s	_{p=0.748 n=6}
_{Check Time}	_{81.70s (± 0.52%)}	_{81.33s (± 0.45%)}	_~	_80.93s	_81.92s	_{p=0.199 n=6}
_{Emit Time}	_{0.19s (± 2.67%)}	_{0.19s (± 2.13%)}	_~	_0.19s	_0.20s	_{p=0.595 n=6}
_{Total Time}	_{95.00s (± 0.43%)}	_{94.58s (± 0.37%)}	_~	_94.13s	_95.14s	_{p=0.149 n=6}
_{self-build-src - node (v18.15.0, x64)}
_{Memory used}	_{2,302,220k (± 0.02%)}	_{2,301,909k (± 0.03%)}	_~	_2,301,225k	_2,302,612k	_{p=0.230 n=6}
_{Parse Time}	_{6.04s (± 1.06%)}	_{6.04s (± 0.82%)}	_~	_5.97s	_6.10s	_{p=0.687 n=6}
_{Bind Time}	_{2.23s (± 0.77%)}	_{2.25s (± 1.11%)}	_~	_2.22s	_2.28s	_{p=0.090 n=6}
_{Check Time}	_{39.69s (± 0.22%)}	_{39.65s (± 0.33%)}	_~	_39.44s	_39.77s	_{p=0.689 n=6}
_{Emit Time}	_{3.08s (± 2.11%)}	_{3.13s (± 2.80%)}	_~	_3.04s	_3.25s	_{p=0.295 n=6}
_{Total Time}	_{51.06s (± 0.23%)}	_{51.11s (± 0.39%)}	_~	_50.87s	_51.41s	_{p=0.423 n=6}
_{self-build-src-public-api - node (v18.15.0, x64)}
_{Memory used}	_{2,376,728k (± 0.04%)}	_{2,376,943k (± 0.03%)}	_~	_2,375,969k	_2,377,891k	_{p=0.936 n=6}
_{Parse Time}	_{6.21s (± 1.08%)}	_{6.18s (± 0.98%)}	_~	_6.11s	_6.27s	_{p=0.471 n=6}
_{Bind Time}	_{2.04s (± 0.68%)}	_{2.03s (± 0.91%)}	_~	_2.00s	_2.05s	_{p=0.935 n=6}
_{Check Time}	_{39.85s (± 0.39%)}	_{39.78s (± 0.28%)}	_~	_39.69s	_39.99s	_{p=0.336 n=6}
_{Emit Time}	_{3.12s (± 2.90%)}	_{3.09s (± 1.98%)}	_~	_3.01s	_3.16s	_{p=0.378 n=6}
_{Total Time}	_{51.22s (± 0.54%)}	_{51.11s (± 0.39%)}	_~	_50.89s	_51.46s	_{p=0.423 n=6}
_{self-compiler - node (v18.15.0, x64)}
_{Memory used}	_{418,302k (± 0.01%)}	_{418,401k (± 0.01%)}	_{+99k (+ 0.02%)}	_418,337k	_418,455k	_{p=0.013 n=6}
_{Parse Time}	_{3.39s (± 0.80%)}	_{3.38s (± 1.96%)}	_~	_3.25s	_3.42s	_{p=0.686 n=6}
_{Bind Time}	_{1.30s (± 1.57%)}	_{1.32s (± 4.88%)}	_~	_1.28s	_1.45s	_{p=0.808 n=6}
_{Check Time}	_{17.84s (± 0.23%)}	_{17.86s (± 0.29%)}	_~	_17.78s	_17.92s	_{p=0.687 n=6}
_{Emit Time}	_{1.36s (± 1.37%)}	_{1.39s (± 1.56%)}	_~	_1.36s	_1.42s	_{p=0.169 n=6}
_{Total Time}	_{23.89s (± 0.25%)}	_{23.94s (± 0.20%)}	_~	_23.89s	_24.02s	_{p=0.196 n=6}
_{vscode - node (v18.15.0, x64)}
_{Memory used}	_{2,906,120k (± 0.00%)}	_{2,906,119k (± 0.00%)}	_~	_2,906,049k	_2,906,161k	_{p=0.810 n=6}
_{Parse Time}	_{13.04s (± 0.35%)}	_{12.96s (± 0.16%)}	_{-0.07s (- 0.56%)}	_12.94s	_12.99s	_{p=0.020 n=6}
_{Bind Time}	_{4.07s (± 0.25%)}	_{4.07s (± 0.22%)}	_~	_4.06s	_4.08s	_{p=0.673 n=6}
_{Check Time}	_{71.42s (± 0.27%)}	_{71.37s (± 0.26%)}	_~	_71.08s	_71.58s	_{p=0.689 n=6}
_{Emit Time}	_{19.39s (± 0.73%)}	_{19.40s (± 0.64%)}	_~	_19.27s	_19.59s	_{p=0.688 n=6}
_{Total Time}	_{107.91s (± 0.26%)}	_{107.81s (± 0.22%)}	_~	_107.36s	_108.06s	_{p=0.422 n=6}
_{webpack - node (v18.15.0, x64)}
_{Memory used}	_{408,658k (± 0.02%)}	_{408,644k (± 0.01%)}	_~	_408,584k	_408,713k	_{p=1.000 n=6}
_{Parse Time}	_{3.22s (± 0.20%)}	_{3.21s (± 0.50%)}	_~	_3.19s	_3.23s	_{p=0.179 n=6}
_{Bind Time}	_{1.38s (± 1.09%)}	_{1.38s (± 0.30%)}	_~	_1.38s	_1.39s	_{p=0.473 n=6}
_{Check Time}	_{14.14s (± 0.62%)}	_{14.15s (± 0.21%)}	_~	_14.11s	_14.19s	_{p=1.000 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{18.75s (± 0.43%)}	_{18.74s (± 0.20%)}	_~	_18.70s	_18.79s	_{p=1.000 n=6}
_{xstate - node (v18.15.0, x64)}
_{Memory used}	_{670,758k (± 0.01%)}	_{670,799k (± 0.02%)}	_~	_670,700k	_671,006k	_{p=0.936 n=6}
_{Parse Time}	_{3.32s (± 0.44%)}	_{3.33s (± 0.23%)}	_~	_3.32s	_3.34s	_{p=0.117 n=6}
_{Bind Time}	_{1.56s (± 0.33%)}	_{1.57s (± 0.35%)}	_~	_1.56s	_1.57s	_{p=0.640 n=6}
_{Check Time}	_{2.89s (± 0.84%)}	_{2.88s (± 0.84%)}	_~	_2.85s	_2.91s	_{p=1.000 n=6}
_{Emit Time}	_{0.03s (±36.48%)}	_{0.02s (± 0.00%)}	_~	_0.02s	_0.02s	_{p=0.071 n=6}
_{Total Time}	_{7.80s (± 0.51%)}	_{7.81s (± 0.32%)}	_~	_7.78s	_7.84s	_{p=0.630 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Angular - node (v18.15.0, x64)
Compiler-Unions - node (v18.15.0, x64)
Monaco - node (v18.15.0, x64)
TFS - node (v18.15.0, x64)
material-ui - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-build-src-public-api - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

typescript-bot · 2024-04-10T21:55:12Z

@gabritto Here are the results of running the top 400 repos comparing main and refs/pull/57837/merge:

Everything looks good!

gabritto · 2024-04-10T22:25:39Z

Latest changes: I got rid of the circularity detection that existed in inferTypeForHomomorphicMappedType, as every circularity of that function is also a circularity of inferReverseMappedType. To do that but keep the existing behavior where inferTypeForHomomorphicMappedType returns undefined in cases of circularity, I changed inferReverseMappedType to also return undefined when a circularity is detected, and so I had to update the callers of inferReverseMappedType to handle the undefined.
We may be able to get rid of those undefineds in the future in something like #56300, where when inference fails due to circularity, we default to the constraint of the type.

track deeply nested types in inferReverseMappedType

700da65

typescript-bot assigned gabritto Mar 18, 2024

typescript-bot added Author: Team For Milestone Bug PRs that fix a bug with a specific milestone labels Mar 18, 2024

gabritto marked this pull request as ready for review March 19, 2024 01:18

gabritto requested review from weswigham and ahejlsberg March 19, 2024 01:18

gabritto changed the title ~~Avoid infinite recursion in inferReverseMappedType~~ Avoid infinite recursion with inferReverseMappedType Mar 19, 2024

weswigham reviewed Mar 19, 2024

View reviewed changes

weswigham approved these changes Mar 21, 2024

View reviewed changes

add caching to inferReverseMappedType

36e7e06

remove obsolete circularity detection; propagate undefined return

698335b

gabritto added 2 commits April 10, 2024 14:00

Merge branch 'main' into gabritto/issue57786

9b470ec

fix baselines

719e6c0

gabritto requested a review from weswigham April 10, 2024 22:25

weswigham approved these changes Apr 12, 2024

View reviewed changes

gabritto merged commit fd23885 into main Apr 16, 2024

gabritto deleted the gabritto/issue57786 branch April 16, 2024 17:43

This was referenced Jul 9, 2024

add TS 5.5 to test matrix reduxjs/redux-toolkit#4500

Closed

Fixed regression in reverse mapped type inference caused by cache leak #59232

Merged

Avoid infinite recursion with inferReverseMappedType #57837

Avoid infinite recursion with inferReverseMappedType #57837

Uh oh!

Conversation

gabritto commented Mar 18, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gabritto commented Mar 18, 2024

Uh oh!

typescript-bot commented Mar 18, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Mar 18, 2024

Uh oh!

typescript-bot commented Mar 18, 2024

Uh oh!

typescript-bot commented Mar 18, 2024

tsc

tsserver

startup

Uh oh!

typescript-bot commented Mar 18, 2024

Uh oh!

gabritto commented Mar 18, 2024

Uh oh!

typescript-bot commented Mar 18, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Mar 19, 2024

tsc

Uh oh!

weswigham left a comment

Choose a reason for hiding this comment

Uh oh!

gabritto commented Mar 20, 2024

Uh oh!

weswigham commented Mar 21, 2024

Uh oh!

weswigham left a comment

Choose a reason for hiding this comment

Uh oh!

weswigham Mar 21, 2024

Choose a reason for hiding this comment

Uh oh!

gabritto Mar 22, 2024

Choose a reason for hiding this comment

Uh oh!

gabritto Mar 22, 2024

Choose a reason for hiding this comment

Uh oh!

sandersn commented Mar 27, 2024

Uh oh!

gabritto commented Mar 27, 2024

Uh oh!

Andarist commented Mar 28, 2024

Uh oh!

gabritto commented Apr 10, 2024

Uh oh!

typescript-bot commented Apr 10, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Apr 10, 2024

Uh oh!

typescript-bot commented Apr 10, 2024

Uh oh!

typescript-bot commented Apr 10, 2024

tsc

Uh oh!

typescript-bot commented Apr 10, 2024

Uh oh!

gabritto commented Apr 10, 2024

Uh oh!

Uh oh!

Avoid infinite recursion with `inferReverseMappedType` #57837

Avoid infinite recursion with `inferReverseMappedType` #57837

gabritto commented Mar 18, 2024 •

edited

Loading

typescript-bot commented Mar 18, 2024 •

edited

Loading

typescript-bot commented Mar 18, 2024 •

edited

Loading

typescript-bot commented Apr 10, 2024 •

edited

Loading