Skip to content

Make sure virtual file system with watch behaves same way as sys/node so we have proper test coverage for symlinks #57607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sheetalkamat merged 2 commits into from
Mar 29, 2024
Merged

Make sure virtual file system with watch behaves same way as sys/node so we have proper test coverage for symlinks #57607

sheetalkamat merged 2 commits into from
Mar 29, 2024

Conversation

@sheetalkamat
Copy link
Member

@sheetalkamat sheetalkamat commented Mar 2, 2024 •
edited
Loading

  • With node.js watching, if the folder/file thats being watched is symlink the updates to target are observed. So i added test thats common for sys and our virtualFileSystemWithWatch so they are in sync and fixed vfswith watch issue where updates were not percolated.
  • Also added few additional test cases and fixed incorrect test as well .

@typescript-bot typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Mar 2, 2024
@sheetalkamat sheetalkamat force-pushed the symlinks branch 5 times, most recently from f7049ff to f1d7bcb Compare March 7, 2024 18:02
@sheetalkamat sheetalkamat changed the title [WIP] symlinks tests and updates Make sure virtual file system with watch behaves same way as sys/node so we have proper test coverage for symlinks Mar 7, 2024
@sheetalkamat sheetalkamat marked this pull request as ready for review March 7, 2024 18:27
sheetalkamat
sheetalkamat commented Mar 7, 2024
View reviewed changes
jakebailey
jakebailey reviewed Mar 7, 2024
View reviewed changes
@jakebailey
Copy link
Member

jakebailey commented Mar 13, 2024

Ah, good thing I made that change; the PR fails on macos.

@sheetalkamat sheetalkamat marked this pull request as draft March 13, 2024 21:49
@sheetalkamat sheetalkamat force-pushed the symlinks branch 14 times, most recently from ed17af5 to 11ea2bc Compare March 14, 2024 22:59
@sheetalkamat sheetalkamat force-pushed the symlinks branch 13 times, most recently from 16aaa6c to e7fb298 Compare March 15, 2024 23:46
@sheetalkamat sheetalkamat force-pushed the symlinks branch 6 times, most recently from 6c79316 to 07ad05b Compare March 28, 2024 20:11
@sheetalkamat sheetalkamat marked this pull request as ready for review March 28, 2024 21:29
@sheetalkamat sheetalkamat changed the title [WIP] Make sure virtual file system with watch behaves same way as sys/node so we have proper test coverage for symlinks Make sure virtual file system with watch behaves same way as sys/node so we have proper test coverage for symlinks Mar 28, 2024
@sheetalkamat sheetalkamat requested a review from jakebailey March 28, 2024 21:29
jakebailey
jakebailey reviewed Mar 28, 2024
View reviewed changes
@sheetalkamat sheetalkamat merged commit 26358d2 into main Mar 29, 2024
@sheetalkamat sheetalkamat deleted the symlinks branch March 29, 2024 16:48
@microsoft microsoft locked as resolved and limited conversation to collaborators Oct 16, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jakebailey jakebailey jakebailey approved these changes

@andrewbranch andrewbranch Awaiting requested review from andrewbranch

Assignees

@sheetalkamat sheetalkamat

Labels

Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sheetalkamat @jakebailey @typescript-bot