Skip to content

Conversation

a-tarasyuk
Copy link
Contributor

Fixes #57240

@typescript-bot typescript-bot added the For Backlog Bug PRs that fix a backlog bug label Feb 4, 2024
@typeholes
Copy link

Would it be possible to reword the error message so that the list is at the end?

Non-abstract class 'C' does not implement inherited abstract members 'bm1', 'bm2', 'bm3', 'm1', 'm2', 'm3' from class 'B'.ts(2654)

Something along the lines of

    "Type '{0}' is missing the following properties from type '{1}': {2}": {
        "category": "Error",
        "code": 2739
    },

@andrewbranch
Copy link
Member

I like @typeholes suggestion of moving the name of the abstract class before the list of members.

@a-tarasyuk
Copy link
Contributor Author

@andrewbranch Oke, I've changed diagnostic messages...

Copy link
Member

@andrewbranch andrewbranch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thanks!

@andrewbranch andrewbranch merged commit c1f0f7c into microsoft:main Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
For Backlog Bug PRs that fix a backlog bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unimplemented abstract methods result in verbose, repetitive message
4 participants