fix(57022): Rename of string literal property name doesn't rename all occurences

[Zzzen]

… occurences

Fixes #57022

[iisaduan]

@typescript-bot pack this

[typescript-bot]

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
pack this	✅ Started	✅ Results

[typescript-bot]

Hey @iisaduan, I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/161937/artifacts?artifactName=tgz&fileId=A85DC03F46FFD993606A4365BA384A6E1C5542D66F5366C8399E730013E6019902&fileName=/typescript-5.5.0-insiders.20240524.tgz"
    }
}

and then running npm install.

---

There is also a playground for this build and an npm module you can use via "typescript": "npm:@typescript-deploys/[email protected]".;

[iisaduan]

This PR doesn't quite do what the original bug report was asking for, however, I think it is the correct behavior that is in line with other renames that we offer. The foo immediately following the destructuring assignment is a separate variable than the one referred to by the string literal property.

Before this PR: rename only works when the property being renamed is not a string literal.

After this PR: foo is now properly assigned after renaming the property

Renaming the foo that doesn't change: the renamed variable is assigned properly

[iisaduan]

@gabritto pointed out that you can make the vscode behavior match the playground behavior by setting providePrefixAndSuffixTextForRename (or "Use Aliases For Renames" in vscode) to false. #49568 (comment)