Fix renaming of node_modules #49568
Merged
Fix renaming of node_modules #49568
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typescript-bot
added
Author: Team
For Milestone Bug
andrewbranch
approved these changes
Jun 16, 2022
| @@ -8822,6 +8822,7 @@ namespace ts { | |||
| readonly includeInlayPropertyDeclarationTypeHints?: boolean; | |||
| readonly includeInlayFunctionLikeReturnTypeHints?: boolean; | |||
| readonly includeInlayEnumMemberValueHints?: boolean; | |||
| readonly allowRenameOfImportPath?: boolean; | |||
There was a problem hiding this comment.
Ironically, I think this always belonged in UserPreferences, and providePrefixAndSuffixTextForRename always should have been a per-request option. 🙃 Baby steps in the right direction...
amcasey
approved these changes
Jun 16, 2022
amcasey
suggested changes
Jun 16, 2022
| @@ -5877,6 +5877,8 @@ declare namespace ts { | |||
| getBreakpointStatementAtPosition(fileName: string, position: number): TextSpan | undefined; | |||
| getSignatureHelpItems(fileName: string, position: number, options: SignatureHelpItemsOptions | undefined): SignatureHelpItems | undefined; | |||
| getRenameInfo(fileName: string, position: number, preferences: UserPreferences): RenameInfo; | |||
| /** @deprecated */ | |||
There was a problem hiding this comment.
Comment about using the other overload?
| @@ -6255,6 +6257,7 @@ declare namespace ts { | |||
| Insert = "insert", | |||
| Remove = "remove" | |||
| } | |||
| /** @deprecated - consider using EditorSettings instead */ | |||
There was a problem hiding this comment.
Could be a bad diff, but I'm seeing EditorOptions deprecated? What changed?
There was a problem hiding this comment.
It was marked deprecated before, but with a normal comment (/* */) as opposed to JSDoc (/** */), just a drive-by fix.
amcasey
approved these changes
Jun 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #45668.
I think it also fixes #48681.
The rule I'm trying to implement is the following:
node_modules/, don't allow that rename.node_modulespackage, only allow renames that would not affect a different package.I'd like some feedback on the wording in the diagnostic message.
I'll update the tests'
verify.renameInfoFails()calls once there's a definitive diagnostic message.Note: I had to change
getRenameInfoto take a user preferences parameter, because I needed to know ifprovidePrefixAndSuffixTextForRename(surfaced as "Use Aliases For Renames" in vscode) is set or not. Since that function was already taking as parameter another option that comes from user preferences, it made sense to me to change that. A lot of the diff is refactoring related to that change.