Deprioritize declaration emit paths from baseUrl containing node_modules #57145
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typescript-bot
added
Author: Team
For Uncommitted Bug
sheetalkamat
approved these changes
Jan 23, 2024
jakebailey
approved these changes
Jan 23, 2024
|
Does this need a cherry-pick or are we okay with a temporary break in the beta? |
|
IMO the beta only exists to be a timestamp; it’s not a build anyone should use. Every beta is expected to have all the features and none of the bugfixes. |
|
@typescript-bot cherry-pick to release-5.4 |
|
Heya @andrewbranch, I've started to cherry-pick this into |
typescript-bot
pushed a commit
that referenced
this pull request
Jan 25, 2024
|
Hey @andrewbranch, I've created #57162 for you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
error TS2742: The inferred type of 'resolveParserPlugins' cannot be named without a reference to 'packages/compiler-core/node_modules/@babel/parser/typings/babel-parser'. This is likely not portable. A type annotation is necessary.reported in #57117. (It bisected to #55015, though it’s not clear why, and doesn’t seem like that PR directly introduced the buggy behavior.)Also worth noting that Vue should almost certainly not be using
baseUrlat all.