Reduce buffer to string conversions. #56961
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typescript-bot
added
the
For Uncommitted Bug
dragomirtitian
force-pushed
the
buffer-to-string-conversions
branch
from
2b74554 to
b41fc37
Compare
jakebailey
approved these changes
Jan 5, 2024
There was a problem hiding this comment.
This seems reasonable to me, though I am not seeing quite the same speedup on my machine.
I'm interested in @sheetalkamat's thoughts.
typescript-bot
added
For Backlog Bug
I am curios if you are seeing any speedups on your machine? |
|
Barely, if anything; I can try and get more data but I ran it a couple times and saw roughly my normal 1m45s before and after. |
$ hyperfine --prepare 'git switch main' -n 'main' 'npm test -- --no-lint' --prepare 'git switch pr-56961' -n 'PR 56961' 'npm test -- --no-lint'
Benchmark 1: main
Time (mean ± σ): 114.415 s ± 1.469 s [User: 2134.875 s, System: 51.155 s]
Range (min … max): 110.731 s … 116.508 s 10 runs
Benchmark 2: PR 56961
Time (mean ± σ): 109.475 s ± 1.874 s [User: 2032.384 s, System: 37.635 s]
Range (min … max): 108.442 s … 114.625 s 10 runs
Summary
'PR 56961' ran
1.05 ± 0.02 times faster than 'main' |
|
Perhaps this has a better effect when fewer workers are in use; my machine ends up running with 19 workers. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #56960
This PR implements the suggested improvement of not converting between
Bufferandstringunless absolutely necessary in the virtual file system implementation used for tests.Some anecdotal tests:
This also helps with isolated declarations clawing back some of the time taken by ID tests: