Replace disk path operations to use fileNames instead of path #56476
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sheetalkamat
force-pushed
the
perVolumeCasing
branch
from
c7f6b45 to
3cc03d4
Compare
sheetalkamat
changed the title
typescript-bot
added
Author: Team
For Uncommitted Bug
|
@gluxon can you please try this build and see if this helps |
|
@typescript-bot pack this |
|
Heya @sheetalkamat, I've started to run the tarball bundle task on this PR at 3cc03d4. You can monitor the build here. |
|
Hey @sheetalkamat, I've packed this into an installable tgz. You can install it for testing by referencing it in your and then running There is also a playground for this build and an npm module you can use via |
|
@typescript-bot test this |
|
Heya @sheetalkamat, I've started to run the diff-based top-repos suite (tsserver) on this PR at 3cc03d4. You can monitor the build here. Update: The results are in! |
|
Heya @sheetalkamat, I've started to run the diff-based top-repos suite on this PR at 3cc03d4. You can monitor the build here. Update: The results are in! |
|
Heya @sheetalkamat, I've started to run the diff-based user code test suite on this PR at 3cc03d4. You can monitor the build here. Update: The results are in! |
|
Heya @sheetalkamat, I've started to run the diff-based user code test suite (tsserver) on this PR at 3cc03d4. You can monitor the build here. Update: The results are in! |
|
Heya @sheetalkamat, I've started to run the parallelized Definitely Typed test suite on this PR at 3cc03d4. You can monitor the build here. Update: The results are in! |
|
Heya @sheetalkamat, I've started to run the regular perf test suite on this PR at 3cc03d4. You can monitor the build here. Update: The results are in! |
|
@sheetalkamat Here they are:
CompilerComparison Report - baseline..pr
System info unknown
Hosts
Scenarios
tsserverComparison Report - baseline..pr
System info unknown
Hosts
Scenarios
StartupComparison Report - baseline..pr
System info unknown
Hosts
Scenarios
Developer Information: |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
@sheetalkamat Here are the results of running the user test suite comparing Everything looks good! |
|
@sheetalkamat Here are the results of running the user test suite comparing There were infrastructure failures potentially unrelated to your change:
Otherwise... Something interesting changed - please have a look. Details
|
|
Hey @sheetalkamat, the results of running the DT tests are ready. |
|
@sheetalkamat Here are the results of running the top-repos suite comparing Everything looks good! |
|
@sheetalkamat Here are the results of running the top-repos suite comparing Something interesting changed - please have a look. DetailsServer exited prematurely with code unknown and signal SIGABRTAffected reposcalcom/cal.comRaw error text:RepoResults7/calcom.cal.com.rawError.txt in the artifact folder
Last few requests{"seq":941,"type":"request","command":"navto","arguments":{"searchValue":"a1R","maxResultCount":256}}
{"seq":942,"type":"request","command":"updateOpen","arguments":{"changedFiles":[{"fileName":"@PROJECT_ROOT@/apps/swagger/pages/_app.tsx","textChanges":[{"newText":" //comment","start":{"line":1,"offset":42},"end":{"line":1,"offset":42}}]}],"closedFiles":[],"openFiles":[]}}
{"seq":943,"type":"request","command":"updateOpen","arguments":{"changedFiles":[],"closedFiles":["@PROJECT_ROOT@/apps/api/test/lib/middleware/withMiddleware.test.ts"],"openFiles":[]}}
{"seq":944,"type":"request","command":"updateOpen","arguments":{"changedFiles":[],"closedFiles":[],"openFiles":[{"file":"@PROJECT_ROOT@/apps/web/components/apps/AdditionalCalendarSelector.tsx","projectRootPath":"@PROJECT_ROOT@"}]}}
Repro steps
|
|
@typescript-bot perf test this |
|
Heya @sheetalkamat, I've started to run the regular perf test suite on this PR at 5468827. You can monitor the build here. Update: The results are in! |
|
@sheetalkamat Here they are:
CompilerComparison Report - baseline..pr
System info unknown
Hosts
Scenarios
tsserverComparison Report - baseline..pr
System info unknown
Hosts
Scenarios
StartupComparison Report - baseline..pr
System info unknown
Hosts
Scenarios
Developer Information: |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
sheetalkamat
force-pushed
the
perVolumeCasing
branch
from
5468827 to
aed1e9b
Compare
|
@typescript-bot perf test this |
|
Heya @sheetalkamat, I've started to run the regular perf test suite on this PR at aed1e9b. You can monitor the build here. Update: The results are in! |
|
@sheetalkamat Here they are:
CompilerComparison Report - baseline..pr
System info unknown
Hosts
Scenarios
tsserverComparison Report - baseline..pr
System info unknown
Hosts
Scenarios
StartupComparison Report - baseline..pr
System info unknown
Hosts
Scenarios
Developer Information: |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
andrewbranch
approved these changes
Nov 28, 2023
We have this somewhat in server with normalized path but not in absolute path and we probably want that distinction as well .. but that’s too much |
Co-authored-by: Andrew Branch <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#55427 reported that the new files are not detected and per @gluxon investigation it turned out that the case was when tsserver was on case-insensitive volume while the user code was on the case sensitive volume. While changing complete architecture of
useCaseSensitiveandgetCanonicalNameis huge change that needs to percolate everywhere, trying to use file names in all the host operations and using canonical path for comparing (though that's not perfect andbar.tsandBar.tswill be treated as same file) is minimal change that can help with some of the scenarios. While you may get wrong casing in say some of the auto imports but at least you should getcompletionsetc just like when you open tsserver.