Skip to content

fix(55823) - Remove Braces From Arrow function fails when using satisfies #55831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 22, 2023
Merged

fix(55823) - Remove Braces From Arrow function fails when using satisfies #55831

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a4c8507
fix(55823) - parenthesize satisfies expression
a-tarasyuk Sep 22, 2023
ccbf8e8
add tests
a-tarasyuk Sep 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/services/utilities.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,6 +226,7 @@ import {
isRequireVariableStatement,
isRightSideOfQualifiedNameOrPropertyAccess,
isRootedDiskPath,
isSatisfiesExpression,
isSetAccessorDeclaration,
isSourceFile,
isSourceFileJS,
Expand Down Expand Up @@ -3355,7 +3356,7 @@ function indexInTextChange(change: string, name: string): number {
export function needsParentheses(expression: Expression): boolean {
return isBinaryExpression(expression) && expression.operatorToken.kind === SyntaxKind.CommaToken
|| isObjectLiteralExpression(expression)
|| isAsExpression(expression) && isObjectLiteralExpression(expression.expression);
|| (isAsExpression(expression) || isSatisfiesExpression(expression)) && isObjectLiteralExpression(expression.expression);
}

/** @internal */
Expand Down
13 changes: 13 additions & 0 deletions tests/cases/fourslash/refactorAddOrRemoveBracesToArrowFunction35.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
/// <reference path='fourslash.ts' />

/////*a*/()/*b*/ => {
//// return {} satisfies any
////}

goTo.select("a", "b");
edit.applyRefactor({
refactorName: "Add or remove braces in an arrow function",
actionName: "Remove braces from arrow function",
actionDescription: "Remove braces from arrow function",
newContent: "() => ({} satisfies any)",
});