Use const context in intersections containing const type variables #55779

Andarist · 2023-09-18T19:47:15Z

jakebailey · 2023-09-19T00:02:07Z

This feels almost too simple... I feel like I remember the original PR not doing this on purpose. @ahejlsberg

@typescript-bot test top200
@typescript-bot user test this
@typescript-bot run dt
@typescript-bot perf test this
@typescript-bot pack this

typescript-bot · 2023-09-19T00:02:09Z

Heya @jakebailey, I've started to run the diff-based top-repos suite on this PR at cb06cde. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-09-19T00:02:09Z

Heya @jakebailey, I've started to run the diff-based user code test suite on this PR at cb06cde. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-09-19T00:02:09Z

Heya @jakebailey, I've started to run the tarball bundle task on this PR at cb06cde. You can monitor the build here.

typescript-bot · 2023-09-19T00:02:09Z

Heya @jakebailey, I've started to run the parallelized Definitely Typed test suite on this PR at cb06cde. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-09-19T00:02:09Z

Heya @jakebailey, I've started to run the regular perf test suite on this PR at cb06cde. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-09-19T00:04:06Z

Hey @jakebailey, I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/157795/artifacts?artifactName=tgz&fileId=9AF812C3E2572235F52FFF0141044055D42CE04BA80ED2B2F7ACD4CA1C98A04C02&fileName=/typescript-5.3.0-insiders.20230919.tgz"
    }
}

and then running npm install.

There is also a playground for this build and an npm module you can use via "typescript": "npm:@typescript-deploys/[email protected]".;

typescript-bot · 2023-09-19T00:22:31Z

@jakebailey Here are the results of running the user test suite comparing main and refs/pull/55779/merge:

There were infrastructure failures potentially unrelated to your change:

1 instance of "Unknown failure"
2 instances of "Package install failed"

Otherwise...

Everything looks good!

typescript-bot · 2023-09-19T00:24:54Z

@jakebailey
The results of the perf run you requested are in!

Here they are:

Compiler

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Angular - node (v18.15.0, x64)}
_{Memory used}	_{294,933k (± 0.01%)}	_{294,907k (± 0.01%)}	_~	_294,871k	_294,938k	_{p=0.128 n=6}
_{Parse Time}	_{2.64s (± 0.52%)}	_{2.64s (± 0.65%)}	_~	_2.62s	_2.67s	_{p=1.000 n=6}
_{Bind Time}	_{0.85s (± 0.61%)}	_{0.85s (± 0.89%)}	_~	_0.84s	_0.86s	_{p=0.784 n=6}
_{Check Time}	_{7.99s (± 0.39%)}	_{8.00s (± 0.32%)}	_~	_7.96s	_8.02s	_{p=0.747 n=6}
_{Emit Time}	_{7.02s (± 0.28%)}	_{7.01s (± 0.19%)}	_~	_6.99s	_7.02s	_{p=0.198 n=6}
_{Total Time}	_{18.50s (± 0.12%)}	_{18.49s (± 0.16%)}	_~	_18.45s	_18.53s	_{p=0.809 n=6}
_{Compiler-Unions - node (v18.15.0, x64)}
_{Memory used}	_{192,584k (± 1.53%)}	_{193,558k (± 1.62%)}	_~	_190,667k	_196,482k	_{p=0.471 n=6}
_{Parse Time}	_{1.35s (± 0.60%)}	_{1.36s (± 0.89%)}	_~	_1.35s	_1.38s	_{p=0.599 n=6}
_{Bind Time}	_{0.74s (± 0.00%)}	_{0.74s (± 0.00%)}	_~	_0.74s	_0.74s	_{p=1.000 n=6}
_{Check Time}	_{9.05s (± 0.46%)}	_{9.10s (± 0.31%)}	_~	_9.05s	_9.13s	_{p=0.091 n=6}
_{Emit Time}	_{2.60s (± 0.70%)}	_{2.61s (± 0.29%)}	_~	_2.60s	_2.62s	_{p=0.279 n=6}
_{Total Time}	_{13.75s (± 0.37%)}	_{13.80s (± 0.22%)}	_~	_13.75s	_13.83s	_{p=0.088 n=6}
_{Monaco - node (v18.15.0, x64)}
_{Memory used}	_{347,175k (± 0.00%)}	_{347,188k (± 0.01%)}	_~	_347,160k	_347,219k	_{p=0.378 n=6}
_{Parse Time}	_{2.46s (± 0.36%)}	_{2.46s (± 0.43%)}	_~	_2.44s	_2.47s	_{p=0.452 n=6}
_{Bind Time}	_{0.94s (± 0.55%)}	_{0.94s (± 0.55%)}	_~	_0.93s	_0.94s	_{p=1.000 n=6}
_{Check Time}	_{6.85s (± 0.51%)}	_{6.86s (± 0.66%)}	_~	_6.81s	_6.94s	_{p=0.686 n=6}
_{Emit Time}	_{4.04s (± 0.38%)}	_{4.06s (± 0.30%)}	_{+0.02s (+ 0.50%)}	_4.04s	_4.07s	_{p=0.045 n=6}
_{Total Time}	_{14.28s (± 0.27%)}	_{14.31s (± 0.38%)}	_~	_14.24s	_14.38s	_{p=0.376 n=6}
_{TFS - node (v18.15.0, x64)}
_{Memory used}	_{302,458k (± 0.00%)}	_{302,454k (± 0.00%)}	_~	_302,449k	_302,464k	_{p=0.628 n=6}
_{Parse Time}	_{2.02s (± 0.40%)}	_{2.01s (± 0.75%)}	_~	_1.99s	_2.03s	_{p=1.000 n=6}
_{Bind Time}	_{1.00s (± 0.41%)}	_{1.00s (± 1.17%)}	_~	_0.99s	_1.02s	_{p=0.787 n=6}
_{Check Time}	_{6.22s (± 0.44%)}	_{6.23s (± 0.50%)}	_~	_6.20s	_6.29s	_{p=0.805 n=6}
_{Emit Time}	_{3.53s (± 0.73%)}	_{3.51s (± 0.46%)}	_~	_3.48s	_3.52s	_{p=0.195 n=6}
_{Total Time}	_{12.76s (± 0.39%)}	_{12.75s (± 0.31%)}	_~	_12.72s	_12.83s	_{p=0.376 n=6}
_{material-ui - node (v18.15.0, x64)}
_{Memory used}	_{470,434k (± 0.01%)}	_{470,451k (± 0.00%)}	_~	_470,436k	_470,491k	_{p=0.689 n=6}
_{Parse Time}	_{2.59s (± 0.72%)}	_{2.60s (± 0.71%)}	_~	_2.58s	_2.62s	_{p=0.565 n=6}
_{Bind Time}	_{1.00s (± 0.75%)}	_{0.99s (± 0.90%)}	_~	_0.98s	_1.00s	_{p=0.053 n=6}
_{Check Time}	_{16.58s (± 0.40%)}	_{16.58s (± 0.43%)}	_~	_16.49s	_16.66s	_{p=1.000 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{20.18s (± 0.31%)}	_{20.18s (± 0.33%)}	_~	_20.10s	_20.25s	_{p=0.936 n=6}
_{xstate - node (v18.15.0, x64)}
_{Memory used}	_{512,205k (± 0.01%)}	_{512,255k (± 0.01%)}	_~	_512,217k	_512,291k	_{p=0.230 n=6}
_{Parse Time}	_{3.25s (± 0.50%)}	_{3.27s (± 0.17%)}	_~	_3.26s	_3.27s	_{p=0.056 n=6}
_{Bind Time}	_{1.55s (± 0.26%)}	_{1.55s (± 0.33%)}	_~	_1.54s	_1.55s	_{p=0.595 n=6}
_{Check Time}	_{2.78s (± 0.75%)}	_{2.79s (± 0.53%)}	_~	_2.76s	_2.80s	_{p=0.454 n=6}
_{Emit Time}	_{0.08s (± 4.99%)}	_{0.08s (± 0.00%)}	_~	_0.08s	_0.08s	_{p=0.405 n=6}
_{Total Time}	_{7.65s (± 0.24%)}	_{7.68s (± 0.30%)}	_~	_7.64s	_7.70s	_{p=0.061 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Angular - node (v18.15.0, x64)
Compiler-Unions - node (v18.15.0, x64)
Monaco - node (v18.15.0, x64)
TFS - node (v18.15.0, x64)
material-ui - node (v18.15.0, x64)
xstate - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

tsserver

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-UnionsTSServer - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{2,367ms (± 1.52%)}	_{2,384ms (± 1.45%)}	_~	_2,336ms	_2,424ms	_{p=0.423 n=6}
_{Req 2 - geterr}	_{5,319ms (± 1.52%)}	_{5,299ms (± 1.48%)}	_~	_5,235ms	_5,417ms	_{p=0.810 n=6}
_{Req 3 - references}	_{327ms (± 0.51%)}	_{326ms (± 0.27%)}	_~	_325ms	_327ms	_{p=0.362 n=6}
_{Req 4 - navto}	_{276ms (± 0.63%)}	_{277ms (± 0.50%)}	_~	_274ms	_278ms	_{p=0.803 n=6}
_{Req 5 - completionInfo count}	_{1,356 (± 0.00%)}	_{1,356 (± 0.00%)}	_~	_1,356	_1,356	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{84ms (± 6.34%)}	_{83ms (± 6.28%)}	_~	_75ms	_89ms	_{p=1.000 n=6}
_{CompilerTSServer - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{2,457ms (± 1.15%)}	_{2,489ms (± 0.96%)}	_~	_2,457ms	_2,528ms	_{p=0.128 n=6}
_{Req 2 - geterr}	_{4,113ms (± 2.07%)}	_{4,052ms (± 0.64%)}	_~	_4,015ms	_4,093ms	_{p=0.471 n=6}
_{Req 3 - references}	_{335ms (± 0.51%)}	_{337ms (± 0.91%)}	_~	_335ms	_343ms	_{p=0.245 n=6}
_{Req 4 - navto}	_{281ms (± 0.50%)}	_{282ms (± 0.43%)}	_~	_280ms	_283ms	_{p=0.458 n=6}
_{Req 5 - completionInfo count}	_{1,518 (± 0.00%)}	_{1,518 (± 0.00%)}	_~	_1,518	_1,518	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{75ms (± 2.98%)}	_{77ms (± 7.64%)}	_~	_72ms	_88ms	_{p=0.734 n=6}
_{xstateTSServer - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{2,591ms (± 0.21%)}	_{2,598ms (± 0.65%)}	_~	_2,582ms	_2,627ms	_{p=0.630 n=6}
_{Req 2 - geterr}	_{1,715ms (± 1.71%)}	_{1,701ms (± 2.86%)}	_~	_1,631ms	_1,760ms	_{p=0.810 n=6}
_{Req 3 - references}	_{117ms (± 9.75%)}	_{112ms (± 8.59%)}	_~	_104ms	_127ms	_{p=0.142 n=6}
_{Req 4 - navto}	_{365ms (± 0.40%)}	_{366ms (± 1.31%)}	_~	_363ms	_376ms	_{p=0.743 n=6}
_{Req 5 - completionInfo count}	_{2,071 (± 0.00%)}	_{2,071 (± 0.00%)}	_~	_2,071	_2,071	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{305ms (± 3.18%)}	_{308ms (± 0.93%)}	_~	_305ms	_312ms	_{p=0.414 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

CompilerTSServer - node (v18.15.0, x64)
Compiler-UnionsTSServer - node (v18.15.0, x64)
xstateTSServer - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Startup

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{tsc-startup - node (v18.15.0, x64)}
_{Execution time}	_{151.17ms (± 0.17%)}	_{151.13ms (± 0.17%)}	_~	_150.13ms	_153.05ms	_{p=0.114 n=600}
_{tsserver-startup - node (v18.15.0, x64)}
_{Execution time}	_{226.55ms (± 0.16%)}	_{226.17ms (± 0.15%)}	_{-0.37ms (- 0.16%)}	_224.93ms	_231.08ms	_{p=0.000 n=600}
_{tsserverlibrary-startup - node (v18.15.0, x64)}
_{Execution time}	_{228.07ms (± 0.17%)}	_{227.93ms (± 0.20%)}	_{-0.13ms (- 0.06%)}	_226.43ms	_235.62ms	_{p=0.000 n=600}
_{typescript-startup - node (v18.15.0, x64)}
_{Execution time}	_{227.98ms (± 0.16%)}	_{227.76ms (± 0.16%)}	_{-0.21ms (- 0.09%)}	_226.33ms	_234.25ms	_{p=0.000 n=600}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

tsc-startup - node (v18.15.0, x64)
tsserver-startup - node (v18.15.0, x64)
tsserverlibrary-startup - node (v18.15.0, x64)
typescript-startup - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

typescript-bot · 2023-09-19T01:34:11Z

Hey @jakebailey, it looks like the DT test run failed. Please check the log for more details.
You can check the log here.

typescript-bot · 2023-09-19T02:11:34Z

@jakebailey Here are the results of running the top-repos suite comparing main and refs/pull/55779/merge:

Everything looks good!

ahejlsberg · 2023-09-19T17:53:10Z

This feels almost too simple... I feel like I remember the original PR not doing this on purpose. @ahejlsberg

I can't recall anything, and this seems like a reasonable fix. So I'm good with it.

jakebailey · 2023-09-19T20:42:41Z

I will note that perf/DT don't really have const type params, and they don't have high usage yet, so it's hard to say if we'll get any feedback for this within the PR now. Probably we should just merge it and then wait for someone to come up with a bad case.

…icrosoft#55779)

Use const context in intersections containing const type variables

cb06cde

typescript-bot added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Sep 18, 2023

jakebailey approved these changes Sep 19, 2023

View reviewed changes

jakebailey merged commit 6e01b06 into microsoft:main Sep 19, 2023

Andarist deleted the const-context-intersection branch September 20, 2023 08:31

snovader pushed a commit to EG-A-S/TypeScript that referenced this pull request Sep 23, 2023

Use const context in intersections containing const type variables (m…

2aabdad

…icrosoft#55779)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Use const context in intersections containing const type variables #55779

Use const context in intersections containing const type variables #55779

Uh oh!

Andarist commented Sep 18, 2023

Uh oh!

jakebailey commented Sep 19, 2023

Uh oh!

typescript-bot commented Sep 19, 2023 •

edited

Loading

Uh oh!

typescript-bot commented Sep 19, 2023 •

edited

Loading

Uh oh!

typescript-bot commented Sep 19, 2023 •

edited

Loading

Uh oh!

typescript-bot commented Sep 19, 2023 •

edited

Loading

Uh oh!

typescript-bot commented Sep 19, 2023 •

edited

Loading

Uh oh!

typescript-bot commented Sep 19, 2023 •

edited

Loading

Uh oh!

typescript-bot commented Sep 19, 2023

Uh oh!

typescript-bot commented Sep 19, 2023

Compiler

tsserver

Startup

Uh oh!

typescript-bot commented Sep 19, 2023

Uh oh!

typescript-bot commented Sep 19, 2023

Uh oh!

ahejlsberg commented Sep 19, 2023

Uh oh!

jakebailey commented Sep 19, 2023

Uh oh!

Uh oh!

Use const context in intersections containing const type variables #55779

Use const context in intersections containing const type variables #55779

Uh oh!

Conversation

Andarist commented Sep 18, 2023

Uh oh!

jakebailey commented Sep 19, 2023

Uh oh!

typescript-bot commented Sep 19, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Sep 19, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Sep 19, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Sep 19, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Sep 19, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Sep 19, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Sep 19, 2023

Uh oh!

typescript-bot commented Sep 19, 2023

Compiler

tsserver

Startup

Uh oh!

typescript-bot commented Sep 19, 2023

Uh oh!

typescript-bot commented Sep 19, 2023

Uh oh!

ahejlsberg commented Sep 19, 2023

Uh oh!

jakebailey commented Sep 19, 2023

Uh oh!

Uh oh!

typescript-bot commented Sep 19, 2023 •

edited

Loading

typescript-bot commented Sep 19, 2023 •

edited

Loading

typescript-bot commented Sep 19, 2023 •

edited

Loading

typescript-bot commented Sep 19, 2023 •

edited

Loading

typescript-bot commented Sep 19, 2023 •

edited

Loading

typescript-bot commented Sep 19, 2023 •

edited

Loading