Fix issue with optional chaining and type inference in type guard #55613
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@typescript-bot test top100 |
|
Heya @jakebailey, I've started to run the diff-based top-repos suite on this PR at 1fddcab. You can monitor the build here. Update: The results are in! |
|
Heya @jakebailey, I've started to run the regular perf test suite on this PR at 1fddcab. You can monitor the build here. Update: The results are in! |
|
Heya @jakebailey, I've started to run the diff-based user code test suite on this PR at 1fddcab. You can monitor the build here. Update: The results are in! |
|
Heya @jakebailey, I've started to run the parallelized Definitely Typed test suite on this PR at 1fddcab. You can monitor the build here. Update: The results are in! |
|
@jakebailey Here are the results of running the user test suite comparing There were infrastructure failures potentially unrelated to your change:
Otherwise... Everything looks good! |
|
@jakebailey Here they are:
CompilerComparison Report - baseline..pr
System info unknown
Hosts
Scenarios
tsserverComparison Report - baseline..pr
System info unknown
Hosts
Scenarios
StartupComparison Report - baseline..pr
System info unknown
Hosts
Scenarios
Developer Information: |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
@jakebailey Here are the results of running the top-repos suite comparing Everything looks good! |
|
Hey @jakebailey, the results of running the DT tests are ready. |
Andarist
reviewed
Sep 3, 2023
| }; | ||
|
|
||
| const getName2 = (person?: Person): string => { | ||
| return isString(person?.name) ? person?.name : ''; |
There was a problem hiding this comment.
Shouldn't this be changed to this?
Suggested change
| return isString(person?.name) ? person?.name : ''; | |
| return isString(person?.name) ? person.name : ''; |
There was a problem hiding this comment.
Both should be fine. If I recall correctly, optional chaining does not alter the type of the expression it is applied to.
There was a problem hiding this comment.
Ye, right - i thought that previously the error was also raised within the truthy branch of the conditional expression (as in that the obj wasnt being proven to be non-nullable) but it seems that this part was already working ok
Andarist
reviewed
Sep 3, 2023
| type Person = { name: string; } | ||
|
|
||
| const getName1 = (person?: Person): string => { | ||
| return typeof person?.name === 'string' ? person?.name : ''; |
There was a problem hiding this comment.
similarly here:
Suggested change
| return typeof person?.name === 'string' ? person?.name : ''; | |
| return typeof person?.name === 'string' ? person.name : ''; |
|
It must be getting too close to spooky season because I read the issue title as "Fix issue with ... type gourd" 🎃 |
weswigham
approved these changes
Sep 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #34974