error on duplicate symbols in classes #55438
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@typescript-bot pack this |
|
Hey @gabritto, I've packed this into an installable tgz. You can install it for testing by referencing it in your and then running There is also a playground for this build and an npm module you can use via |
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
1 similar comment
|
@typescript-bot run DT |
|
Heya @gabritto, I've started to run the regular perf test suite on this PR at 04bd8cb. You can monitor the build here. Update: The results are in! |
|
Heya @gabritto, I've started to run the diff-based user code test suite on this PR at 04bd8cb. You can monitor the build here. Update: The results are in! |
|
Heya @gabritto, I've started to run the diff-based top-repos suite on this PR at 04bd8cb. You can monitor the build here. Update: The results are in! |
|
Heya @gabritto, I've started to run the parallelized Definitely Typed test suite on this PR at 04bd8cb. You can monitor the build here. Update: The results are in! |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
|
@gabritto Here are the results of running the user test suite comparing There were infrastructure failures potentially unrelated to your change:
Otherwise... Something interesting changed - please have a look. Details
|
|
@gabritto Here they are:
CompilerComparison Report - baseline..pr
System info unknown
Hosts
Scenarios
tsserverComparison Report - baseline..pr
System info unknown
Hosts
Scenarios
StartupComparison Report - baseline..pr
System info unknown
Hosts
Scenarios
Developer Information: |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
@gabritto Here are the results of running the top-repos suite comparing Everything looks good! |
|
Hey @gabritto, the results of running the DT tests are ready. |
gabritto
reviewed
Aug 29, 2023
| module M { | ||
| interface I { } | ||
| export class C { | ||
| [Symbol.iterator]: I; | ||
| [Symbol.toPrimitive](x: I) { } | ||
| ~~~~~~~~~~~~~~~~~~~~ |
There was a problem hiding this comment.
I'd say we'd ideally keep the elaboration "X was also declared here" in the errors, is that possible?
| @@ -65,11 +69,19 @@ mappedTypeProperties.ts(40,17): error TS2363: The right-hand side of an arithmet | |||
| [P in PlaceType]: any | |||
| ~~~~~~~~~~~~~~~~ | |||
| !!! error TS7061: A mapped type may not declare properties or methods. | |||
| ~ | |||
| !!! error TS2304: Cannot find name 'P'. | |||
There was a problem hiding this comment.
Those seem to be just noise but maybe it's ok to have them as a side effect of the change.
| [uniqueSymbol0] = "last"; | ||
| ~~~~~~~~~~~~~~~ | ||
| !!! error TS2300: Duplicate identifier '[uniqueSymbol0]'. |
There was a problem hiding this comment.
Not related to the PR changes, but the error here is way less specific/informative than the comparable one you get in object literals.
gabritto
approved these changes
Sep 1, 2023
snovader
pushed a commit
to EG-A-S/TypeScript
that referenced
this pull request
Sep 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #55163
This is a follow-up of #55193. I was testing whether
getEffectivePropertyNameForPropertyNameNodeshould be used more, and it turns out that the answer is yes. It helps identify more duplicate symbol properties.playground