do not report use-before-declaration error in async like IIFE initial… #55279

Zzzen · 2023-08-05T09:39:10Z

…izer

Fixes #30907

…izer

src/compiler/checker.ts

gabritto · 2023-08-24T19:20:17Z

@Zzzen could you fix the merge conflicts? I couldn't push to your branch myself

Zzzen · 2023-08-25T14:34:55Z

Of course, fixed.

gabritto · 2023-08-25T17:49:27Z

@typescript-bot run DT
@typescript-bot user test this
@typescript-bot test top100
@typescript-bot perf test this

typescript-bot · 2023-08-25T17:49:29Z

Heya @gabritto, I've started to run the parallelized Definitely Typed test suite on this PR at 3ae0fa4. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-08-25T17:49:29Z

Heya @gabritto, I've started to run the diff-based top-repos suite on this PR at 3ae0fa4. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-08-25T17:49:29Z

Heya @gabritto, I've started to run the diff-based user code test suite on this PR at 3ae0fa4. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-08-25T17:49:29Z

Heya @gabritto, I've started to run the regular perf test suite on this PR at 3ae0fa4. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-08-25T18:10:02Z

@gabritto Here are the results of running the user test suite comparing main and refs/pull/55279/merge:

There were infrastructure failures potentially unrelated to your change:

1 instance of "Unknown failure"
2 instances of "Package install failed"

Otherwise...

Something interesting changed - please have a look.

Details

rxjs-src

/mnt/ts_downloads/rxjs-src/build.sh

[NEW] error TS2428: All declarations of 'WeakMap' must have identical type parameters.
- /home/vsts/work/1/s/typescript-55279/lib/lib.es2015.collection.d.ts(62,11)
- /home/vsts/work/1/s/typescript-55279/lib/lib.es2015.iterable.d.ts(162,11)
- /home/vsts/work/1/s/typescript-55279/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
- /home/vsts/work/1/s/typescript-55279/lib/lib.es2015.collection.d.ts(62,11)
- /home/vsts/work/1/s/typescript-55279/lib/lib.es2015.iterable.d.ts(162,11)
- /home/vsts/work/1/s/typescript-55279/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
- /home/vsts/work/1/s/typescript-55279/lib/lib.es2015.collection.d.ts(62,11)
- /home/vsts/work/1/s/typescript-55279/lib/lib.es2015.iterable.d.ts(162,11)
- /home/vsts/work/1/s/typescript-55279/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
- /home/vsts/work/1/s/typescript-55279/lib/lib.es2015.collection.d.ts(62,11)
- /home/vsts/work/1/s/typescript-55279/lib/lib.es2015.iterable.d.ts(162,11)
- /home/vsts/work/1/s/typescript-55279/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
- /home/vsts/work/1/s/typescript-55279/lib/lib.es2015.collection.d.ts(62,11)
- /home/vsts/work/1/s/typescript-55279/lib/lib.es2015.iterable.d.ts(162,11)
- /home/vsts/work/1/s/typescript-55279/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
[MISSING] error TS2428: All declarations of 'WeakMap' must have identical type parameters.
- /home/vsts/work/1/s/typescript-main/lib/lib.es2015.collection.d.ts(62,11)
- /home/vsts/work/1/s/typescript-main/lib/lib.es2015.iterable.d.ts(162,11)
- /home/vsts/work/1/s/typescript-main/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
- /home/vsts/work/1/s/typescript-main/lib/lib.es2015.collection.d.ts(62,11)
- /home/vsts/work/1/s/typescript-main/lib/lib.es2015.iterable.d.ts(162,11)
- /home/vsts/work/1/s/typescript-main/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
- /home/vsts/work/1/s/typescript-main/lib/lib.es2015.collection.d.ts(62,11)
- /home/vsts/work/1/s/typescript-main/lib/lib.es2015.iterable.d.ts(162,11)
- /home/vsts/work/1/s/typescript-main/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
- /home/vsts/work/1/s/typescript-main/lib/lib.es2015.collection.d.ts(62,11)
- /home/vsts/work/1/s/typescript-main/lib/lib.es2015.iterable.d.ts(162,11)
- /home/vsts/work/1/s/typescript-main/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
- /home/vsts/work/1/s/typescript-main/lib/lib.es2015.collection.d.ts(62,11)
- /home/vsts/work/1/s/typescript-main/lib/lib.es2015.iterable.d.ts(162,11)
- /home/vsts/work/1/s/typescript-main/lib/lib.es2015.symbol.wellknown.d.ts(140,11)

typescript-bot · 2023-08-25T18:20:06Z

@gabritto
The results of the perf run you requested are in!

Here they are:

Compiler

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Angular - node (v16.17.1, x64)}
_{Memory used}	_{300,239k (± 0.00%)}	_{300,252k (± 0.01%)}	_~	_300,222k	_300,270k	_{p=0.199 n=6}
_{Parse Time}	_{3.03s (± 0.21%)}	_{3.03s (± 0.25%)}	_~	_3.02s	_3.04s	_{p=0.718 n=6}
_{Bind Time}	_{0.93s (± 0.00%)}	_{0.93s (± 0.00%)}	_~	_0.93s	_0.93s	_{p=1.000 n=6}
_{Check Time}	_{9.33s (± 1.27%)}	_{9.31s (± 0.30%)}	_~	_9.28s	_9.35s	_{p=0.293 n=6}
_{Emit Time}	_{7.63s (± 0.21%)}	_{7.62s (± 0.30%)}	_~	_7.59s	_7.65s	_{p=0.685 n=6}
_{Total Time}	_{20.91s (± 0.63%)}	_{20.89s (± 0.14%)}	_~	_20.87s	_20.94s	_{p=0.147 n=6}
_{Compiler-Unions - node (v16.17.1, x64)}
_{Memory used}	_{193,962k (± 0.01%)}	_{194,433k (± 0.67%)}	_~	_193,830k	_197,089k	_{p=0.128 n=6}
_{Parse Time}	_{1.58s (± 0.33%)}	_{1.58s (± 0.26%)}	_~	_1.58s	_1.59s	_{p=0.595 n=6}
_{Bind Time}	_{0.80s (± 0.65%)}	_{0.80s (± 0.51%)}	_~	_0.79s	_0.80s	_{p=0.595 n=6}
_{Check Time}	_{9.92s (± 0.28%)}	_{9.91s (± 0.41%)}	_~	_9.85s	_9.96s	_{p=0.936 n=6}
_{Emit Time}	_{2.73s (± 0.19%)}	_{2.73s (± 0.30%)}	_~	_2.72s	_2.74s	_{p=0.929 n=6}
_{Total Time}	_{15.03s (± 0.15%)}	_{15.02s (± 0.28%)}	_~	_14.95s	_15.06s	_{p=0.746 n=6}
_{Monaco - node (v16.17.1, x64)}
_{Memory used}	_{347,153k (± 0.00%)}	_{347,155k (± 0.00%)}	_~	_347,135k	_347,170k	_{p=0.872 n=6}
_{Parse Time}	_{2.68s (± 0.19%)}	_{2.68s (± 0.19%)}	_~	_2.68s	_2.69s	_{p=1.000 n=6}
_{Bind Time}	_{0.99s (± 0.00%)}	_{0.99s (± 0.00%)}	_~	_0.99s	_0.99s	_{p=1.000 n=6}
_{Check Time}	_{7.93s (± 0.19%)}	_{7.91s (± 0.22%)}	_{-0.03s (- 0.34%)}	_7.88s	_7.93s	_{p=0.029 n=6}
_{Emit Time}	_{4.26s (± 0.36%)}	_{4.27s (± 0.26%)}	_~	_4.26s	_4.29s	_{p=0.502 n=6}
_{Total Time}	_{15.87s (± 0.09%)}	_{15.85s (± 0.17%)}	_~	_15.81s	_15.89s	_{p=0.145 n=6}
_{TFS - node (v16.17.1, x64)}
_{Memory used}	_{301,147k (± 0.01%)}	_{301,144k (± 0.00%)}	_~	_301,127k	_301,167k	_{p=0.748 n=6}
_{Parse Time}	_{2.17s (± 0.56%)}	_{2.18s (± 0.63%)}	_~	_2.16s	_2.19s	_{p=1.000 n=6}
_{Bind Time}	_{1.11s (± 0.37%)}	_{1.11s (± 1.33%)}	_~	_1.08s	_1.12s	_{p=1.000 n=6}
_{Check Time}	_{7.21s (± 0.31%)}	_{7.21s (± 0.07%)}	_~	_7.21s	_7.22s	_{p=0.560 n=6}
_{Emit Time}	_{3.99s (± 0.40%)}	_{3.98s (± 0.19%)}	_~	_3.97s	_3.99s	_{p=0.209 n=6}
_{Total Time}	_{14.48s (± 0.25%)}	_{14.47s (± 0.14%)}	_~	_14.45s	_14.50s	_{p=0.572 n=6}
_{material-ui - node (v16.17.1, x64)}
_{Memory used}	_{479,452k (± 0.00%)}	_{479,450k (± 0.00%)}	_~	_479,429k	_479,480k	_{p=0.574 n=6}
_{Parse Time}	_{3.15s (± 0.00%)}	_{3.15s (± 0.26%)}	_~	_3.15s	_3.17s	_{p=0.405 n=6}
_{Bind Time}	_{0.91s (± 0.00%)}	_{0.91s (± 0.00%)}	_~	_0.91s	_0.91s	_{p=1.000 n=6}
_{Check Time}	_{17.76s (± 0.33%)}	_{17.75s (± 0.48%)}	_~	_17.63s	_17.89s	_{p=0.872 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{21.82s (± 0.27%)}	_{21.81s (± 0.42%)}	_~	_21.69s	_21.97s	_{p=0.872 n=6}
_{xstate - node (v16.17.1, x64)}
_{Memory used}	_{542,805k (± 0.01%)}	_{542,836k (± 0.01%)}	_~	_542,757k	_542,958k	_{p=0.689 n=6}
_{Parse Time}	_{3.70s (± 0.24%)}	_{3.70s (± 0.22%)}	_~	_3.69s	_3.71s	_{p=0.550 n=6}
_{Bind Time}	_{1.34s (± 0.39%)}	_{1.34s (± 0.30%)}	_~	_1.33s	_1.34s	_{p=0.595 n=6}
_{Check Time}	_{3.34s (± 0.72%)}	_{3.31s (± 0.68%)}	_~	_3.29s	_3.35s	_{p=0.064 n=6}
_{Emit Time}	_{0.08s (± 0.00%)}	_{0.08s (± 0.00%)}	_~	_0.08s	_0.08s	_{p=1.000 n=6}
_{Total Time}	_{8.46s (± 0.43%)}	_{8.43s (± 0.22%)}	_~	_8.40s	_8.46s	_{p=0.158 n=6}

System info unknown

Hosts

node (v16.17.1, x64)

Scenarios

Angular - node (v16.17.1, x64)
Compiler-Unions - node (v16.17.1, x64)
Monaco - node (v16.17.1, x64)
TFS - node (v16.17.1, x64)
material-ui - node (v16.17.1, x64)
xstate - node (v16.17.1, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

tsserver

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-UnionsTSServer - node (v16.17.1, x64)}
_{Req 1 - updateOpen}	_{2,490ms (± 0.11%)}	_{2,490ms (± 0.17%)}	_~	_2,483ms	_2,496ms	_{p=1.000 n=6}
_{Req 2 - geterr}	_{5,931ms (± 0.39%)}	_{5,964ms (± 0.37%)}	_{+34ms (+ 0.57%)}	_5,939ms	_5,996ms	_{p=0.031 n=6}
_{Req 3 - references}	_{343ms (± 0.52%)}	_{342ms (± 0.30%)}	_~	_341ms	_344ms	_{p=0.616 n=6}
_{Req 4 - navto}	_{278ms (± 0.88%)}	_{278ms (± 0.90%)}	_~	_276ms	_282ms	_{p=1.000 n=6}
_{Req 5 - completionInfo count}	_{1,356 (± 0.00%)}	_{1,356 (± 0.00%)}	_~	_1,356	_1,356	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{84ms (± 5.48%)}	_{83ms (± 6.88%)}	_~	_76ms	_93ms	_{p=0.560 n=6}
_{CompilerTSServer - node (v16.17.1, x64)}
_{Req 1 - updateOpen}	_{2,637ms (± 0.59%)}	_{2,621ms (± 0.70%)}	_~	_2,607ms	_2,647ms	_{p=0.172 n=6}
_{Req 2 - geterr}	_{4,769ms (± 0.30%)}	_{4,767ms (± 0.23%)}	_~	_4,752ms	_4,786ms	_{p=0.630 n=6}
_{Req 3 - references}	_{350ms (± 0.23%)}	_{351ms (± 0.43%)}	_~	_349ms	_353ms	_{p=0.354 n=6}
_{Req 4 - navto}	_{270ms (± 0.28%)}	_{269ms (± 0.30%)}	_~	_268ms	_270ms	_{p=0.383 n=6}
_{Req 5 - completionInfo count}	_{1,518 (± 0.00%)}	_{1,518 (± 0.00%)}	_~	_1,518	_1,518	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{79ms (± 0.52%)}	_{78ms (± 3.01%)}	_~	_73ms	_79ms	_{p=0.248 n=6}
_{xstateTSServer - node (v16.17.1, x64)}
_{Req 1 - updateOpen}	_{2,718ms (± 0.13%)}	_{2,714ms (± 0.20%)}	_~	_2,706ms	_2,720ms	_{p=0.260 n=6}
_{Req 2 - geterr}	_{1,952ms (± 1.98%)}	_{1,938ms (± 2.84%)}	_~	_1,853ms	_1,985ms	_{p=1.000 n=6}
_{Req 3 - references}	_{133ms (± 6.85%)}	_{137ms (± 2.87%)}	_~	_133ms	_143ms	_{p=1.000 n=6}
_{Req 4 - navto}	_{353ms (± 0.49%)}	_{353ms (± 0.45%)}	_~	_352ms	_356ms	_{p=1.000 n=6}
_{Req 5 - completionInfo count}	_{2,071 (± 0.00%)}	_{2,071 (± 0.00%)}	_~	_2,071	_2,071	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{315ms (± 1.52%)}	_{316ms (± 2.24%)}	_~	_310ms	_326ms	_{p=0.808 n=6}

System info unknown

Hosts

node (v16.17.1, x64)

Scenarios

CompilerTSServer - node (v16.17.1, x64)
Compiler-UnionsTSServer - node (v16.17.1, x64)
xstateTSServer - node (v16.17.1, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Startup

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{tsc-startup - node (v16.17.1, x64)}
_{Execution time}	_{155.73ms (± 0.20%)}	_{155.56ms (± 0.16%)}	_{-0.17ms (- 0.11%)}	_154.15ms	_157.78ms	_{p=0.000 n=600}
_{tsserver-startup - node (v16.17.1, x64)}
_{Execution time}	_{230.28ms (± 0.12%)}	_{231.02ms (± 0.15%)}	_{+0.74ms (+ 0.32%)}	_228.86ms	_236.19ms	_{p=0.000 n=600}
_{tsserverlibrary-startup - node (v16.17.1, x64)}
_{Execution time}	_{235.09ms (± 0.12%)}	_{235.86ms (± 0.15%)}	_{+0.78ms (+ 0.33%)}	_234.40ms	_239.91ms	_{p=0.000 n=600}
_{typescript-startup - node (v16.17.1, x64)}
_{Execution time}	_{235.72ms (± 0.13%)}	_{235.63ms (± 0.12%)}	_{-0.09ms (- 0.04%)}	_234.37ms	_238.09ms	_{p=0.002 n=600}

System info unknown

Hosts

node (v16.17.1, x64)

Scenarios

tsc-startup - node (v16.17.1, x64)
tsserver-startup - node (v16.17.1, x64)
tsserverlibrary-startup - node (v16.17.1, x64)
typescript-startup - node (v16.17.1, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

typescript-bot · 2023-08-25T18:52:38Z

@gabritto Here are the results of running the top-repos suite comparing main and refs/pull/55279/merge:

Everything looks good!

typescript-bot · 2023-08-25T19:59:36Z

Hey @gabritto, it looks like the DT test run failed. Please check the log for more details.
You can check the log here.

gabritto · 2023-08-25T21:51:18Z

@typescript-bot run DT

typescript-bot · 2023-08-25T21:51:23Z

Heya @gabritto, I've started to run the parallelized Definitely Typed test suite on this PR at 3ae0fa4. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-08-25T23:48:48Z

Hey @gabritto, it looks like the DT test run failed. Please check the log for more details.
You can check the log here.

gabritto · 2023-08-25T23:50:01Z

@typescript-bot run DT

typescript-bot · 2023-08-25T23:50:04Z

Heya @gabritto, I've started to run the parallelized Definitely Typed test suite on this PR at 3ae0fa4. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-08-26T02:00:48Z

Hey @gabritto, the results of running the DT tests are ready.
Everything looks the same!
You can check the log here.

microsoft#55279)

do not report use-before-declaration error in async like IIFE initial…

b8036a1

…izer

typescript-bot added the For Backlog Bug PRs that fix a backlog bug label Aug 5, 2023

jakebailey reviewed Aug 7, 2023

View reviewed changes

src/compiler/checker.ts Outdated Show resolved Hide resolved

Zzzen added 2 commits August 8, 2023 12:29

Merge branch 'microsoft:main' into iife-used-before-def

b93d62e

format

afa5273

sandersn requested a review from gabritto August 24, 2023 15:16

sandersn assigned gabritto Aug 24, 2023

gabritto approved these changes Aug 24, 2023

View reviewed changes

Merge remote-tracking branch 'origin/main' into iife-used-before-def

3ae0fa4

This comment was marked as duplicate.

Sign in to view

gabritto merged commit 788239f into microsoft:main Aug 28, 2023

snovader pushed a commit to EG-A-S/TypeScript that referenced this pull request Sep 23, 2023

do not report use-before-declaration error in async like IIFE initial… (

b2ecc2b

microsoft#55279)

do not report use-before-declaration error in async like IIFE initial… #55279

do not report use-before-declaration error in async like IIFE initial… #55279

Conversation

Zzzen commented Aug 5, 2023

Uh oh!

Uh oh!

gabritto commented Aug 24, 2023

Uh oh!

Zzzen commented Aug 25, 2023

Uh oh!

This comment was marked as duplicate.

gabritto commented Aug 25, 2023

Uh oh!

typescript-bot commented Aug 25, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Aug 25, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Aug 25, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Aug 25, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Aug 25, 2023

rxjs-src

/mnt/ts_downloads/rxjs-src/build.sh

Uh oh!

typescript-bot commented Aug 25, 2023

Compiler

tsserver

Startup

Uh oh!

typescript-bot commented Aug 25, 2023

Uh oh!

typescript-bot commented Aug 25, 2023

Uh oh!

gabritto commented Aug 25, 2023

Uh oh!

typescript-bot commented Aug 25, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Aug 25, 2023

Uh oh!

gabritto commented Aug 25, 2023

Uh oh!

typescript-bot commented Aug 25, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Aug 26, 2023

Uh oh!

Uh oh!

typescript-bot commented Aug 25, 2023 •

edited

Loading

typescript-bot commented Aug 25, 2023 •

edited

Loading

typescript-bot commented Aug 25, 2023 •

edited

Loading

typescript-bot commented Aug 25, 2023 •

edited

Loading

typescript-bot commented Aug 25, 2023 •

edited

Loading

typescript-bot commented Aug 25, 2023 •

edited

Loading